On Tue, 25 Mar 2025 00:39:17 GMT, Chen Liang wrote:
> Migrates the CreateSymbols tool to use the ClassFile API, away from
> com.sun.tools.classfile.
>
> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but this
> is open to reviews.
>
> Together with #24206, the old com.su
Migrates the CreateSymbols tool to use the ClassFile API, away from
com.sun.tools.classfile.
Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but this
is open to reviews.
Together with #24206, the old com.sun.tools.classfile can be removed from the
JDK.
-
Comm
On Mon, 7 Apr 2025 14:05:47 GMT, Erik Joelsson wrote:
>> We had a test setup failure in our distributed test system where the process
>> running jtreg crashed. This caused the hs_err file to end up in the root of
>> the source tree. Dropping crash files in the source tree is bad practice and
>
On Tue, 25 Mar 2025 00:39:17 GMT, Chen Liang wrote:
> Migrates the CreateSymbols tool to use the ClassFile API, away from
> com.sun.tools.classfile.
>
> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but this
> is open to reviews.
>
> Together with #24206, the old com.su
On Sat, 5 Apr 2025 04:45:00 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> c
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g. `cacerts` file for Linux distro builds of OpenJDK package
On Mon, 7 Apr 2025 12:11:51 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
On Fri, 4 Apr 2025 07:48:37 GMT, Christoph Langer wrote:
> Currently, when building with `--with-external-symbols-in-bundles=public`,
> the debug symbols bundle contains the stripped pdb files. It should better
> have the full pdb files since stripped pdbs are in the runtime image already.
Mar
On Mon, 7 Apr 2025 12:14:28 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments from Christoph
>
> test/jdk/tools/jlink/runtimeImage/UpgradeableFileCacertsTest.java line 42:
>
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote:
> In the JDK launcher, there is a codepath which would set/modify the
> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
> contains a li
On Mon, 7 Apr 2025 07:08:51 GMT, David Linus Briemann wrote:
> * How does it conflict with the jcheck rules? The rules defined in this
> editorconfig are stricter than the jcheck rules. So jcheck could not find
> issues after the editorconfig rules were applied.
No, it's not. The rules you pro
On Sat, 5 Apr 2025 04:49:03 GMT, Christoph Langer wrote:
> I see that you're actively on the upgradeable files. What about #24190?
Let's keep the discussion on #24190, please.
-
PR Comment: https://git.openjdk.org/jdk/pull/24388#issuecomment-2782507174
On Fri, 4 Apr 2025 14:32:30 GMT, Magnus Ihse Bursie wrote:
>> We have been sloppy in our use of `printf` in make code. Most of the time,
>> we should really use `echo` instead. If we do need to use `printf`, we
>> should never inline make or shell variables into the formatting string,
>> since
On Fri, 4 Apr 2025 14:59:35 GMT, Magnus Ihse Bursie wrote:
> We had a test setup failure in our distributed test system where the process
> running jtreg crashed. This caused the hs_err file to end up in the root of
> the source tree. Dropping crash files in the source tree is bad practice and
On Mon, 7 Apr 2025 10:10:57 GMT, Magnus Ihse Bursie wrote:
>> Alternative to https://github.com/openjdk/jdk/pull/23693 for implementing
>> JDK-8311227.
>>
>> This `.editorconfig` file is a 1-to-1 conversion of the checks done by
>> jcheck into .editorconfig format. I believe that is a better w
On Fri, 4 Apr 2025 07:48:37 GMT, Christoph Langer wrote:
> Currently, when building with `--with-external-symbols-in-bundles=public`,
> the debug symbols bundle contains the stripped pdb files. It should better
> have the full pdb files since stripped pdbs are in the runtime image already.
Thi
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g. `cacerts` file for Linux distro builds of OpenJDK package
On Mon, 7 Apr 2025 12:21:06 GMT, Severin Gehwolf wrote:
>> test/jdk/tools/jlink/runtimeImage/UpgradeableFileCacertsTest.java line 42:
>>
>>> 40: /*
>>> 41: * @test
>>> 42: * @summary Verify that no errors are reported for files the have been
>>
>> Suggestion:
>>
>> * @summary Verify that no
On Tue, 11 Mar 2025 09:12:45 GMT, David Linus Briemann wrote:
>> Add an .editorconfig to define indentation, trim trailing whitespace and
>> open curly brace position for C++ and Java.
>> This allows various editors to easily infer basics of the coding style.
>
> David Linus Briemann has updated
On Mon, 7 Apr 2025 10:10:57 GMT, Magnus Ihse Bursie wrote:
>> Alternative to https://github.com/openjdk/jdk/pull/23693 for implementing
>> JDK-8311227.
>>
>> This `.editorconfig` file is a 1-to-1 conversion of the checks done by
>> jcheck into .editorconfig format. I believe that is a better w
On Tue, 11 Mar 2025 09:12:45 GMT, David Linus Briemann wrote:
>> Add an .editorconfig to define indentation, trim trailing whitespace and
>> open curly brace position for C++ and Java.
>> This allows various editors to easily infer basics of the coding style.
>
> David Linus Briemann has updated
> Alternative to https://github.com/openjdk/jdk/pull/23693 for implementing
> JDK-8311227.
>
> This `.editorconfig` file is a 1-to-1 conversion of the checks done by jcheck
> into .editorconfig format. I believe that is a better way to introduce an
> `.editorconfig` file into the existing JDK p
On Mon, 7 Apr 2025 13:35:57 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
If there is something wrong with the build, the user can run "make doctor".
That is hard to do in a CI setting. Instead, if the build environment is
detected to be a CI, we should run the doctor automatically in case of a failed
build.
-
Commit messages:
- 8345874: Run make doctor
On Fri, 4 Apr 2025 09:22:10 GMT, Joachim Kern wrote:
>> In the JDK launcher, there is a codepath which would set/modify the
>> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can
>> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which
>> contains
On Tue, 11 Mar 2025 09:12:45 GMT, David Linus Briemann wrote:
>> Add an .editorconfig to define indentation, trim trailing whitespace and
>> open curly brace position for C++ and Java.
>> This allows various editors to easily infer basics of the coding style.
>
> David Linus Briemann has updated
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
Please review a patch to add a JavaDoc Taglet to the JDK build system that
allows to add preview-related notes to non-preview API elements, as well as a
hidden javadoc option to add elements with preview notes to the preview summary
page.
The {@previewNote} tag uses the following syntax:
{@pr
On Mon, 7 Apr 2025 05:25:39 GMT, David Holmes wrote:
>> No, there are embedded `\n` and that does not work with echo. I could split
>> it into three consecutive lines but I don't think that would be a gain.
>
> Ah I see. So basically the only time we actually need `printf` as far as I
> can see
On Mon, 7 Apr 2025 05:13:09 GMT, David Holmes wrote:
>> We had a test setup failure in our distributed test system where the process
>> running jtreg crashed. This caused the hs_err file to end up in the root of
>> the source tree. Dropping crash files in the source tree is bad practice and
>>
On Mon, 7 Apr 2025 07:08:51 GMT, David Linus Briemann wrote:
> * The editorconfig as defined in this PR follows the hotspot style guide and
> the indentation settings only apply to hotspot code.
Yes, you have a good point there. I included your `src/hotspot/.editorconfig`
in my PR.
--
On Thu, 3 Apr 2025 09:18:07 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only
> generate module-deps.gmk once at the start of Init.gmk. This causes `make
> clean ` to first generate and then remove module-deps.gmk
> after which the rest
> Alternative approach to #24012
>
> This keeps the current handling of *.pdb vs *.stripped.pdb which allows
> debugging at the cost of a little hack in jlink. Maybe the code in jlink can
> be improved, e.g. make it more conditional.
>
> I'm running this through our testing still to see whether
33 matches
Mail list logo
