Re: On passing --date to jrt-fs jar at build time

2025-04-05 Thread Galder Zamarreno
On Fri, Mar 28, 2025 at 10:43 AM Alan Bateman wrote: > On 28/03/2025 09:25, Galder Zamarreno wrote: > > : > > However, @Thomas Fitzsimmons had a very good point > to make: > > > I also wonder why the test harness is passing --date $SOURCE_DATE_EPOCH, > since the test jars are not distributed, no

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console() [v3]

2025-04-05 Thread Jan Lahoda
> The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problematic - JLine is > very powerful, possibly too powerfu

RE: broken dependencies when doing make all ?

2025-04-05 Thread Baesken, Matthias
>And the problem still persisted..? No, just the incremental build was bad ; after rm -rf and full rebuild everything was fine . Best regards, Matthias

Re: RFR: 8352481: Extra a.out generated after configure with clang [v4]

2025-04-05 Thread Magnus Ihse Bursie
On Mon, 24 Mar 2025 15:31:23 GMT, SendaoYan wrote: >> Hi all, >> >> There is an extra a.out file generated located in repository root directory >> after execute the configure command with llvm/clang compiler sometimes, not >> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

2025-04-05 Thread Erik Joelsson
On Thu, 20 Mar 2025 04:55:32 GMT, Patrick Zhang wrote: > > Wouldn't just the change in JvmFlags.gmk be enough to solve your issue? > > Forgot to mention, one of my initial try-outs (hacking) was: Remove > `$(EXTRA_CFLAGS)` from `JVM_CFLAGS`, based on an assumption that all source > files under

Re: RFR: 8352084: Add more test code in TestSetupAOT.java [v4]

2025-04-05 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 16:35:12 GMT, Ioi Lam wrote: >> I modified TestSetupAOT.java to exercise more functionalities in the JDK so >> that we can have a more substantial AOT cache when running tests with >> `AOT_JDK=true`. E.g: >> >> >> make test JTREG=AOT_JDK=true \ >> TEST=open/test/jdk/ja

Re: [Proposal] Add code signing on Windows to the JDK build system

2025-04-05 Thread Frederic Thevenet
Hi, I have reworked my PR so that using the signing hook is no longer restrained to a specific platform. Please note that I have not touched the current code signing implementation for macOS; to me, it seems simpler to have both options live side by side, at least for the time being. If yo

Re: RFR: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH [v3]

2025-04-05 Thread Christoph Langer
On Fri, 4 Apr 2025 09:22:10 GMT, Joachim Kern wrote: >> In the JDK launcher, there is a codepath which would set/modify the >> LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can >> also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which >> contains

Re: RFR: 8315844: $LSB_RELEASE is not defined before use

2025-04-05 Thread Erik Joelsson
On Thu, 3 Apr 2025 10:04:59 GMT, Magnus Ihse Bursie wrote: > When running configure on WSL, the following error message is printed, > instead of proper Linux environment info: > > > /build/.configure-support/generated-configure.sh: line 13102: -d: command > not found > > > This is due

RFR: 8352645: Add tool support to check order of includes

2025-04-05 Thread Doug Simon
This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of include statements in C++ files are sorted alphabetically and that there's at least one blank line between user and sys includes (as per the [style guide](https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md

Re: RFR: 8342984: Bump minimum boot jdk to JDK 24

2025-04-05 Thread Chen Liang
On Fri, 28 Mar 2025 23:44:19 GMT, Mikael Vidstedt wrote: > With the JDK 24 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 25. > > Testing: tier1-5, GHA Thanks for this bump. - Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jd

Re: RFR: 8352481: Enforce the use of lld with clang [v7]

2025-04-05 Thread Andrew Leonard
On Thu, 27 Mar 2025 02:21:30 GMT, SendaoYan wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Force use of lld when build os is not macosx > > make/autoconf/toolchain.m4 line 625: > >> 623: # Force use of lld, sinc

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-04-05 Thread Magnus Ihse Bursie
On Mon, 31 Mar 2025 08:58:20 GMT, Aleksey Shipilev wrote: >> Build and use SLEEF library as a backend implementation for Vector API >> trigonometric functions on macosx-aarch64 platform. >> >> It improves raw throughput and eliminates GC overhead of non-intrinsified >> Vector API operation. >>

Re: RFR: 8353005: AIX build broken after 8352481

2025-04-05 Thread Martin Doerr
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

Re: RFR: 8352618: Remove old deprecated functionality in the build system

2025-04-05 Thread Julian Waters
On Fri, 21 Mar 2025 15:17:27 GMT, Magnus Ihse Bursie wrote: > It's time for some spring cleaning in the build system. These checks are for > functionality that has long been deprecated, and should not be in use > anymore. We should remove it to keep the code base simpler. Go for it! -

Re: RFR: 8348282: Add option for syntax highlighting in javadoc snippets

2025-04-05 Thread Andrey Turbanov
On Thu, 3 Apr 2025 14:48:58 GMT, Hannes Wallnöfer wrote: > Please review a change to add a `javadoc` option to enable syntax > highlighting for code fragments in snippets and `` tags. The new > `--syntax-highlight` option uses the [highlight.js] JavaScript library and > supports Java, Propert

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v4]

2025-04-05 Thread duke
On Mon, 31 Mar 2025 14:31:56 GMT, Patrick Zhang wrote: >> Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` >> triggers 1000+ warning messages like `cc1plus: warning: command-line option >> ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. >> >> T

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-04-05 Thread Joachim Kern
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352935: Launcher should not add $JDK/../lib to LD_LIBRARY_PATH

2025-04-05 Thread Magnus Ihse Bursie
On Tue, 1 Apr 2025 09:13:45 GMT, Joachim Kern wrote: > In the JDK launcher, there is a codepath which would set/modify the > LD_LIBRARY_PATH. This happens unconditionally on AIX and Linux/musl and can > also happen on other Linux platforms if an LD_LIBRARY_PATH is pre-set which > contains a li

Re: RFR: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

2025-04-05 Thread Erik Joelsson
On Mon, 31 Mar 2025 13:27:32 GMT, Magnus Ihse Bursie wrote: > It turns out one instance of STATIC_LIB_CFLAGS was missed in Flags.gmk when > fixing [JDK-8345683](https://bugs.openjdk.org/browse/JDK-8345683). This was > noticed by @cnqpzhang in > https://github.com/openjdk/jdk/pull/24115/files#r

Re: RFR: 8350801: Add a code signing hook to the JDK build system [v4]

2025-04-05 Thread Frederic Thevenet
> OpenJDK vendors who provide binary distributions for the Windows and macOS > platforms generally need to ensure that every native executable file and > dynamic library that are part of the binary builds are digitally signed using > a set of OS specific APIs. > > The JDK build systems already

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-04-05 Thread Magnus Ihse Bursie
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Wait a minute. I re-read the discussion a bit more carefully, and let my brain re-pro

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-04-05 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 22:04:19 GMT, Alexander Zvegintsev wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove AIX special handling from endian.h > > src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipe

Integrated: 8349075: Once again allow -compilejdk in JAVA_OPTIONS

2025-04-05 Thread Magnus Ihse Bursie
On Wed, 2 Apr 2025 17:57:06 GMT, Magnus Ihse Bursie wrote: > [JDK-8348905](https://bugs.openjdk.org/browse/JDK-8348905) added the > possibility to set `JDK_FOR_COMPILE` on the command line to pass the > `-compilejdk:` argument to jtreg. Unfortunately the way it did this meant > that -compilejd

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-04-05 Thread Erik Joelsson
On Tue, 18 Mar 2025 13:12:16 GMT, Magnus Ihse Bursie wrote: >> make/modules/java.base/Copy.gmk line 128: >> >>> 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ >>> 127: $(eval $(import_jvm)_path := $(patsubst $(import_jvm):%,%,$(filter >>> $(import_jvm):%, $(IMPORT_JVMS \ >>> 128:

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port [v3]

2025-04-05 Thread Aleksey Shipilev
> This PR implements JEP 503: Remove the 32-bit x86 Port. > > The JEP is proposed to target 25, we would not integrate until JEP is ready. > Reviews are appreciated meanwhile. > > This is only the removal of obvious 32-bit x86 parts, mostly files with > `x86_32` in their name. Those are only b

Integrated: 8353217: Build libsleef on macos-aarch64

2025-04-05 Thread Vladimir Ivanov
On Sat, 29 Mar 2025 00:58:59 GMT, Vladimir Ivanov wrote: > Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-05 Thread Jan Lahoda
On Mon, 31 Mar 2025 17:22:45 GMT, David M. Lloyd wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewha

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-04-05 Thread Magnus Ihse Bursie
On Sat, 29 Mar 2025 00:58:59 GMT, Vladimir Ivanov wrote: > Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-04-05 Thread Vladimir Kozlov
On Sat, 29 Mar 2025 00:58:59 GMT, Vladimir Ivanov wrote: > Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR

Re: RFR: 8351842: Windows specific issues in combination of JEP 493 and --with-external-symbols-in-bundles=public

2025-04-05 Thread Christoph Langer
On Thu, 20 Mar 2025 17:28:54 GMT, Severin Gehwolf wrote: >> After running this patch through our testing I can confirm that it at least >> solves all existing test issues and does not create regressions. >> >> I, however, admit that the added code in JRTArchive.java is quite hacky and >> is ac

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v2]

2025-04-05 Thread Erik Joelsson
On Tue, 1 Apr 2025 19:59:20 GMT, Vladimir Ivanov wrote: >> Build and use SLEEF library as a backend implementation for Vector API >> trigonometric functions on macosx-aarch64 platform. >> >> It improves raw throughput and eliminates GC overhead of non-intrinsified >> Vector API operation. >>

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

2025-04-05 Thread Erik Joelsson
On Wed, 19 Mar 2025 14:43:28 GMT, Patrick Zhang wrote: > Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` > triggers 1000+ warning messages like `cc1plus: warning: command-line option > ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. > > The ro

Re: RFR: 8350801: Add a code signing hook to the JDK build system [v4]

2025-04-05 Thread Erik Joelsson
On Tue, 25 Mar 2025 15:50:36 GMT, Frederic Thevenet wrote: >> OpenJDK vendors who provide binary distributions for the Windows and macOS >> platforms generally need to ensure that every native executable file and >> dynamic library that are part of the binary builds are digitally signed >> us

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-04-05 Thread Julian Waters
On Sat, 29 Mar 2025 00:58:59 GMT, Vladimir Ivanov wrote: > Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR