Integrated: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

2025-04-01 Thread Magnus Ihse Bursie
On Mon, 31 Mar 2025 13:27:32 GMT, Magnus Ihse Bursie wrote: > It turns out one instance of STATIC_LIB_CFLAGS was missed in Flags.gmk when > fixing [JDK-8345683](https://bugs.openjdk.org/browse/JDK-8345683). This was > noticed by @cnqpzhang in > https://github.com/openjdk/jdk/pull/24115/files#r

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-04-01 Thread Matthias Baesken
On Mon, 31 Mar 2025 13:09:51 GMT, Julian Waters wrote: > but what happens if you replace both instances of -fuse-linker-plugin with > -fno-use-linker-plugin on Linux in JvmFeatures.gmk Then the compilation fails when lto is configured with this message cc1plus: error: '-fno-fat-lto-objects' ar

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-04-01 Thread David M . Lloyd
On Tue, 1 Apr 2025 11:18:14 GMT, Jan Lahoda wrote: >> src/jdk.internal.le/share/classes/jdk/internal/console/SimpleConsoleReader.java >> line 75: >> >>> 73: } >>> 74: continue READ; >>> 75: case '\033': >> >> If this is meant to be platfo

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-04-01 Thread Matthias Baesken
On Tue, 17 Dec 2024 14:54:03 GMT, Julian Waters wrote: >> This is a general cleanup and improvement of LTO, as well as a quick fix to >> remove a workaround in the Makefiles that disabled LTO for >> g1ParScanThreadState.cpp due to the old poisoning mechanism causing trouble. >> The -Wno-attrib

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-04-01 Thread Magnus Ihse Bursie
On Mon, 31 Mar 2025 21:53:21 GMT, Vladimir Ivanov wrote: > > That commit assumes that vector_math_sve.c should have $(SVE_CFLAGS) on mac > > as well as on linux. If that is not correct, then it needs to be adjusted. > > As of now, Apple Silicon doesn't support SVE/SVE2, so I intentionally > ex

Re: RFR: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

2025-04-01 Thread Alan Bateman
On Tue, 1 Apr 2025 12:41:48 GMT, David Holmes wrote: > Revert "8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683" > > This reverts commit cef5610b5d4f7c5c2ceda46995ef3a0d961294e5. > > This causes failures building the static libs on Windows and macOS. > > Thanks Marked as r

RFR: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

2025-04-01 Thread David Holmes
Revert "8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683" This reverts commit cef5610b5d4f7c5c2ceda46995ef3a0d961294e5. This causes failures building the static libs on Windows and macOS. Thanks - Commit messages: - Revert "8353272: One instance of STATIC_LIB_C

Integrated: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683

2025-04-01 Thread David Holmes
On Tue, 1 Apr 2025 12:41:48 GMT, David Holmes wrote: > Revert "8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683" > > This reverts commit cef5610b5d4f7c5c2ceda46995ef3a0d961294e5. > > This causes failures building the static libs on Windows and macOS. > > Thanks This pull r

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files [v4]

2025-04-01 Thread Magnus Ihse Bursie
On Mon, 31 Mar 2025 14:31:56 GMT, Patrick Zhang wrote: >> Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` >> triggers 1000+ warning messages like `cc1plus: warning: command-line option >> ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. >> >> T

Integrated: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

2025-04-01 Thread Patrick Zhang
On Wed, 19 Mar 2025 14:43:28 GMT, Patrick Zhang wrote: > Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` > triggers 1000+ warning messages like `cc1plus: warning: command-line option > ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. > > The ro

RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-01 Thread Magnus Ihse Bursie
The proper way to disable warnings is to use the DISABLED_WARNINGS arguments. In this particular case, there was already a pragma but due to incorrect restrictions it did not apply to clang. - Commit messages: - 8353458: Don't pass -Wno-format-nonliteral to CFLAGS Changes: https:/

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0 [v3]

2025-04-01 Thread Magnus Ihse Bursie
On Tue, 1 Apr 2025 12:07:09 GMT, SendaoYan wrote: >> Hi all, >> File src/java.base/share/native/libjli/java.c compile error: control reaches >> end of non-void function [-Werror=return-type] with gcc options >> -fsanitize=address -O0. The function int JavaMain(void* _args) in this file >> will

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v2]

2025-04-01 Thread Magnus Ihse Bursie
On Tue, 1 Apr 2025 19:59:20 GMT, Vladimir Ivanov wrote: >> Build and use SLEEF library as a backend implementation for Vector API >> trigonometric functions on macosx-aarch64 platform. >> >> It improves raw throughput and eliminates GC overhead of non-intrinsified >> Vector API operation. >>

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v2]

2025-04-01 Thread Vladimir Ivanov
> Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR includes build changes and libsleef sources relocation from

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v2]

2025-04-01 Thread Vladimir Ivanov
On Tue, 1 Apr 2025 19:59:20 GMT, Vladimir Ivanov wrote: >> Build and use SLEEF library as a backend implementation for Vector API >> trigonometric functions on macosx-aarch64 platform. >> >> It improves raw throughput and eliminates GC overhead of non-intrinsified >> Vector API operation. >>

Re: RFR: 8342984: Bump minimum boot jdk to JDK 24

2025-04-01 Thread Mikael Vidstedt
On Fri, 28 Mar 2025 23:44:19 GMT, Mikael Vidstedt wrote: > With the JDK 24 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 25. > > Testing: tier1-5, GHA Thank you for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/24305#issuecomment-277033279

Integrated: 8342984: Bump minimum boot jdk to JDK 24

2025-04-01 Thread Mikael Vidstedt
On Fri, 28 Mar 2025 23:44:19 GMT, Mikael Vidstedt wrote: > With the JDK 24 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 25. > > Testing: tier1-5, GHA This pull request has now been integrated. Changeset: 07fd666d Author:Mikael Vidstedt URL: https://git.

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds [v3]

2025-04-01 Thread Magnus Ihse Bursie
On Mon, 31 Mar 2025 18:11:27 GMT, Saint Wesonga wrote: >> The target selection configuration flag for Windows AArch64 should be added >> to the build documentation for improved discoverability and completeness. > > Saint Wesonga has updated the pull request incrementally with one additional > c

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v3]

2025-04-01 Thread Vladimir Ivanov
> Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR includes build changes and libsleef sources relocation from

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v2]

2025-04-01 Thread Vladimir Ivanov
On Tue, 1 Apr 2025 22:09:33 GMT, Erik Joelsson wrote: >> Vladimir Ivanov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Build changes >> - share/native -> unix/native > > src/jdk.incubator.vector/unix/native/libsleef/README.md line 1

Re: RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-01 Thread David Holmes
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote: > there was already a pragma but due to incorrect restrictions it did not apply > to clang. How does the `__GNUC__` check affect clang?? Isn't that just for gcc? - PR Comment: https://git.openjdk.org/jdk/pull/24357#issueco

Re: RFR: 8353217: Build libsleef on macos-aarch64 [v3]

2025-04-01 Thread Erik Joelsson
On Tue, 1 Apr 2025 22:45:09 GMT, Vladimir Ivanov wrote: >> Build and use SLEEF library as a backend implementation for Vector API >> trigonometric functions on macosx-aarch64 platform. >> >> It improves raw throughput and eliminates GC overhead of non-intrinsified >> Vector API operation. >>

Re: On passing --date to jrt-fs jar at build time

2025-04-01 Thread Alan Bateman
On 01/04/2025 08:52, Galder Zamarreno wrote: I'm not sure what "test harness" and "test jar" means here but just to say that jrt-fs.jar is in the JDK run-time. ^ Are you sure? The default make target, `exploded-image`, doesn't build the jrt-fs.jar. Aside from `test`, `images` does bu

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-04-01 Thread Magnus Ihse Bursie
On Sat, 29 Mar 2025 17:46:43 GMT, Julian Waters wrote: > That would implicitly mean to any developers that it's shared code for all > currently supported operating systems: Windows, macOS, Linux and AIX, which > may be rather confusing if it's only meant to be used on specific platforms. @TheS

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-04-01 Thread Magnus Ihse Bursie
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

Re: RFR: 8304674: File java.c compile error with -fsanitize=address -O0 [v3]

2025-04-01 Thread SendaoYan
> Hi all, > File src/java.base/share/native/libjli/java.c compile error: control reaches > end of non-void function [-Werror=return-type] with gcc options > -fsanitize=address -O0. The function int JavaMain(void* _args) in this file > will execute return ret in LEAVE() macro, but gcc with -O0 is

Posted a couple of JBS issues

2025-04-01 Thread Harald Eilertsen
Hi, I tries posting a couple of issues via the bugreport tool for some minor enhancements to the build system and configure scripts. These are: * libjpeg not found if not in system directories (internal ID 9078307) * Giflib not found when not in system directories (internal ID 9078316) Not sure

Re: RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-01 Thread Erik Joelsson
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote: > The proper way to disable warnings is to use the DISABLED_WARNINGS arguments. > In this particular case, there was already a pragma but due to incorrect > restrictions it did not apply to clang. Marked as reviewed by erikj (Reviewer)