Re: RFR: 8353063: make/ide/vscode: Invalid Configuration Values

2025-03-28 Thread Tobias Hartmann
On Thu, 27 Mar 2025 14:33:30 GMT, Manuel Hässig wrote: > The indexer setting templates used by the `vscode-project-*` `make` targets > contain invalid configuration values. For example, `C_Cpp.formatting": > "Disabled"`is invalid because VSCode (or rather the extension) expects the > value to

Integrated: 8353063: make/ide/vscode: Invalid Configuration Values

2025-03-28 Thread Manuel Hässig
On Thu, 27 Mar 2025 14:33:30 GMT, Manuel Hässig wrote: > The indexer setting templates used by the `vscode-project-*` `make` targets > contain invalid configuration values. For example, `C_Cpp.formatting": > "Disabled"`is invalid because VSCode (or rather the extension) expects the > value to

Re: On passing --date to jrt-fs jar at build time

2025-03-28 Thread Alan Bateman
On 28/03/2025 09:25, Galder Zamarreno wrote: : However, @Thomas Fitzsimmons  had a very good point to make: > I also wonder why the test harness is passing |--date $SOURCE_DATE_EPOCH|, since the test jars are not distributed, not sure why they'd need to be reprodu

Re: RFR: 8353217: Build libsleef on macos-aarch64

2025-03-28 Thread Vladimir Ivanov
On Sat, 29 Mar 2025 00:58:59 GMT, Vladimir Ivanov wrote: > Build and use SLEEF library as a backend implementation for Vector API > trigonometric functions on macosx-aarch64 platform. > > It improves raw throughput and eliminates GC overhead of non-intrinsified > Vector API operation. > > PR

RFR: 8353217: Build libsleef on macos-aarch64

2025-03-28 Thread Vladimir Ivanov
Build and use SLEEF library as a backend implementation for Vector API trigonometric functions on macosx-aarch64 platform. It improves raw throughput and eliminates GC overhead of non-intrinsified Vector API operation. PR includes build changes and libsleef sources relocation from `src/jdk.inc

Re: RFR: 8349638: Build libjdwp with SIZE optimization

2025-03-28 Thread Matthias Baesken
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote: > The libjdwp is currently built with LOW optimization level, it could be built > with SIZE optimization to lower the lib size by ~ 10 % on UNIX. > On Windows LOW and SIZE currently translate to the same O1 optimization flag > so no diff

RFR: 8342984: Bump minimum boot jdk to JDK 24

2025-03-28 Thread Mikael Vidstedt
With the JDK 24 GA out it's time to bump the minimum boot JDK version for mainline/JDK 25. Testing: tier1-5, GHA - Commit messages: - Update copyright year - 8342984: Bump minimum boot jdk to JDK 24 Changes: https://git.openjdk.org/jdk/pull/24305/files Webrev: https://webrevs.o

Re: RFR: 8342984: Bump minimum boot jdk to JDK 24

2025-03-28 Thread Iris Clark
On Fri, 28 Mar 2025 23:44:19 GMT, Mikael Vidstedt wrote: > With the JDK 24 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 25. > > Testing: tier1-5, GHA Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24305#pullrequest

Re: RFR: 8342984: Bump minimum boot jdk to JDK 24

2025-03-28 Thread Joe Darcy
On Fri, 28 Mar 2025 23:44:19 GMT, Mikael Vidstedt wrote: > With the JDK 24 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 25. > > Testing: tier1-5, GHA Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24305#pullreques

Re: On passing --date to jrt-fs jar at build time

2025-03-28 Thread Severin Gehwolf
On Fri, 2025-03-28 at 10:25 +0100, Galder Zamarreno wrote: > Hi, > > I continue experimenting with building mainline on Nix and I've made > some progress. Capstone, Ant and others are in, but I had to work > around an issue when trying to run JMH benchmarks [1]. > > Seems like when `test` make ta

Re: On passing --date to jrt-fs jar at build time

2025-03-28 Thread Galder Zamarreno
On Fri, Mar 28, 2025 at 11:00 AM Severin Gehwolf wrote: > On Fri, 2025-03-28 at 10:25 +0100, Galder Zamarreno wrote: > > Hi, > > > > I continue experimenting with building mainline on Nix and I've made > > some progress. Capstone, Ant and others are in, but I had to work > > around an issue when

On passing --date to jrt-fs jar at build time

2025-03-28 Thread Galder Zamarreno
Hi, I continue experimenting with building mainline on Nix and I've made some progress. Capstone, Ant and others are in, but I had to work around an issue when trying to run JMH benchmarks [1]. Seems like when `test` make target is run, `jrt-fs` jar file is created passing in `--date ...`. In Nix

Re: RFR: 8353005: AIX build broken after 8352481

2025-03-28 Thread Martin Doerr
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate