Re: RFR: 8353005: AIX build broken after 8352481

2025-03-27 Thread snake66
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread Erik Joelsson
On Thu, 27 Mar 2025 18:32:20 GMT, Saint Wesonga wrote: > I don't think `--build=aarch64-pc-cygwin` is equivalent to > `--openjdk-target=aarch64-unknown-cygwin`. The build experts can clarify this > but my understanding is that `--openjdk-target` automatically sets the --host > and --target opt

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-27 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

RFR: 8352618: Remove old deprecated functionality in the build system

2025-03-27 Thread Magnus Ihse Bursie
It's time for some spring cleaning in the build system. These checks are for functionality that has long been deprecated, and should not be in use anymore. We should remove it to keep the code base simpler. - Commit messages: - 8352618: Remove old deprecated functionality in the bu

Re: RFR: 8353005: AIX build broken after 8352481

2025-03-27 Thread Matthias Baesken
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

Re: RFR: 8353005: AIX build broken after 8352481

2025-03-27 Thread snake66
On Thu, 27 Mar 2025 09:09:52 GMT, Matthias Baesken wrote: > I wonder what to do with BSD , afaik they also use clang and probably have > the flag that is missing on AIX ? I'll have a look at it, but lld is the default linker, at least on FreeBSD, so I don't think we need the flag to begin with

Integrated: 8350801: Add a code signing hook to the JDK build system

2025-03-27 Thread Frederic Thevenet
On Wed, 26 Feb 2025 18:02:53 GMT, Frederic Thevenet wrote: > OpenJDK vendors who provide binary distributions for the Windows and macOS > platforms generally need to ensure that every native executable file and > dynamic library that are part of the binary builds are digitally signed using >

Re: RFR: 8353063: make/ide/vscode: Invalid Configuration Values

2025-03-27 Thread Erik Joelsson
On Thu, 27 Mar 2025 14:33:30 GMT, Manuel Hässig wrote: > The indexer setting templates used by the `vscode-project-*` `make` targets > contain invalid configuration values. For example, `C_Cpp.formatting": > "Disabled"`is invalid because VSCode (or rather the extension) expects the > value to

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-03-27 Thread Julian Waters
On Thu, 27 Mar 2025 12:49:10 GMT, Matthias Baesken wrote: > I did some builds today with gcc14.2.0 on Linux x86_64 . They looked good > with and without LTO . Without lto / normal opt build du -sh > images/jdk/lib/server/libjvm.so 27M images/jdk/lib/server/libjvm.so > > WITH lto du -sh images/

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread Erik Joelsson
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. I think this is fine for now, but ideally we should make configure understand that th

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread Saint Wesonga
On Thu, 27 Mar 2025 11:37:29 GMT, Matthias Baesken wrote: > Thanks for documenting it ! My colleague used instead > '--build=aarch64-pc-cygwin' , is this equivalent ? I don't think `--build=aarch64-pc-cygwin` is equivalent to `--openjdk-target=aarch64-unknown-cygwin`. The build experts can cla

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread duke
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. @swesonga Your change (at version c15306a8213b48e369c2b40648a4fd1af2fe2dea) is now re

Re: RFR: 8353005: AIX build broken after 8352481

2025-03-27 Thread Erik Joelsson
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

RFR: 8353063: make/ide/vscode: Invalid Configuration Values

2025-03-27 Thread Manuel Hässig
The indexer setting templates used by the `vscode-project-*` `make` targets contain invalid configuration values. For example, `C_Cpp.formatting": "Disabled"`is invalid because VSCode (or rather the extension) expects the value to be non-capitalized. This PR fixes these invalid configuration opt

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-03-27 Thread Matthias Baesken
On Thu, 27 Mar 2025 14:16:38 GMT, Julian Waters wrote: > Wait, sorry to trouble you further, but what does nm --demangle > --reverse-sort --print-size --size-sort libjvm.so on HotSpot compiled by gcc > 14 with LTO active yield as the largest symbol in the binary? (It should be > the symbol lis

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-27 Thread Naoto Sato
On Wed, 26 Mar 2025 07:54:48 GMT, Jan Lahoda wrote: > The `java.io.Console` has several backends: a simple on in `java.base`, a > more convenient one in `jdk.internal.le` (with line-reading based on JLine) > and one for JShell. > > The backend based on JLine is proving to be a somewhat problem

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-03-27 Thread Julian Waters
On Thu, 27 Mar 2025 14:32:35 GMT, Matthias Baesken wrote: > > Wait, sorry to trouble you further, but what does nm --demangle > > --reverse-sort --print-size --size-sort libjvm.so on HotSpot compiled by > > gcc 14 with LTO active yield as the largest symbol in the binary? (It > > should be the

Re: RFR: 8353005: AIX build broken after 8352481

2025-03-27 Thread SendaoYan
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

Integrated: 8353005: AIX build broken after 8352481

2025-03-27 Thread SendaoYan
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

Re: RFR: 8352693: Use a simpler console reader instead of JLine for System.console()

2025-03-27 Thread Naoto Sato
On Thu, 27 Mar 2025 19:29:29 GMT, Naoto Sato wrote: >> The `java.io.Console` has several backends: a simple on in `java.base`, a >> more convenient one in `jdk.internal.le` (with line-reading based on JLine) >> and one for JShell. >> >> The backend based on JLine is proving to be a somewhat pr

Re: RFR: 8353005: AIX build broken after 8352481

2025-03-27 Thread Matthias Baesken
On Thu, 27 Mar 2025 02:57:23 GMT, SendaoYan wrote: > Hi all, > > Apologize for the inconvenience, fix of > [JDK-8352481](https://bugs.openjdk.org/browse/JDK-8352481) make AIX build > broekn. > > According to the implementation of makefile function > `FLAGS_SETUP_LDFLAGS_HELPER` which locate

Re: RFR: 8350801: Add a code signing hook to the JDK build system [v5]

2025-03-27 Thread Frederic Thevenet
On Wed, 26 Mar 2025 09:28:49 GMT, Frederic Thevenet wrote: >> OpenJDK vendors who provide binary distributions for the Windows and macOS >> platforms generally need to ensure that every native executable file and >> dynamic library that are part of the binary builds are digitally signed >> us

Re: RFR: 8353009: Document target selection flag for Windows AArch64 builds

2025-03-27 Thread Matthias Baesken
On Wed, 26 Mar 2025 22:38:40 GMT, Saint Wesonga wrote: > The target selection configuration flag for Windows AArch64 should be added > to the build documentation for improved discoverability and completeness. Thanks for documenting it ! My colleague used instead '--build=aarch64-pc-cygwin' ,

Re: RFR: 8350801: Add a code signing hook to the JDK build system [v5]

2025-03-27 Thread duke
On Wed, 26 Mar 2025 09:28:49 GMT, Frederic Thevenet wrote: >> OpenJDK vendors who provide binary distributions for the Windows and macOS >> platforms generally need to ensure that every native executable file and >> dynamic library that are part of the binary builds are digitally signed >> us

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-03-27 Thread Matthias Baesken
On Tue, 17 Dec 2024 14:54:03 GMT, Julian Waters wrote: >> This is a general cleanup and improvement of LTO, as well as a quick fix to >> remove a workaround in the Makefiles that disabled LTO for >> g1ParScanThreadState.cpp due to the old poisoning mechanism causing trouble. >> The -Wno-attrib

Re: RFR: 8345265: Minor improvements for LTO across all compilers [v2]

2025-03-27 Thread Julian Waters
On Tue, 17 Dec 2024 14:54:03 GMT, Julian Waters wrote: >> This is a general cleanup and improvement of LTO, as well as a quick fix to >> remove a workaround in the Makefiles that disabled LTO for >> g1ParScanThreadState.cpp due to the old poisoning mechanism causing trouble. >> The -Wno-attrib