Re: RFR: 8352481: Extra a.out generated after configure with clang

2025-03-21 Thread Jaikiran Pai
On Sat, 22 Mar 2025 03:43:58 GMT, SendaoYan wrote: >> Hi all, >> >> There is an extra a.out file generated located in repository root directory >> after execute the configure command with llvm/clang compiler sometimes, not >> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`

Re: RFR: 8352481: Extra a.out generated after configure with clang [v3]

2025-03-21 Thread SendaoYan
> Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows > as below. This PR add a command to remove the

Re: RFR: 8352481: Extra a.out generated after configure with clang

2025-03-21 Thread SendaoYan
On Fri, 21 Mar 2025 10:40:34 GMT, Magnus Ihse Bursie wrote: > Are you saying that running `clang -Wl,-v` sometimes, but not consistently, > generated an `a.out` file for you? That's really absurd and clearly a bug in > clang/lld. Have you reported this upstream? > > If this really happens and

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v4]

2025-03-21 Thread Magnus Ihse Bursie
On Fri, 21 Mar 2025 11:44:49 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-21 Thread Matthias Baesken
On Thu, 20 Mar 2025 22:45:47 GMT, Magnus Ihse Bursie wrote: >> I do not see a problem here, but in this case the >> `Java_sun_awt_screencast_ScreencastHelper_getRGBPixelsImpl` is missing, as >> the ScreencastHelper has 3 native methods. > > Ah, I see. I agree, that it makes more sense to either

Re: RFR: 8352481: Extra a.out generated after configure with clang

2025-03-21 Thread SendaoYan
On Thu, 20 Mar 2025 06:57:04 GMT, SendaoYan wrote: > Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, sho

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-03-21 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v3]

2025-03-21 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 14:30:58 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352481: Extra a.out generated after configure with clang

2025-03-21 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 06:57:04 GMT, SendaoYan wrote: > Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, sho

Re: RFR: 8351277: Remove pipewire from AIX build [v3]

2025-03-21 Thread Magnus Ihse Bursie
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

Re: RFR: 8351277: Remove pipewire from AIX build [v3]

2025-03-21 Thread Matthias Baesken
> Seems Wayland is not supported on AIX, so we most likely do not need to build > pipewire on AIX and can remove it from the build. > Reason is that pipewire updates can break the AIX build, so better avoid it > if possible. > > To check if it works, I move the 'pipewire/include' folder away, an

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v4]

2025-03-21 Thread Joachim Kern
> After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now with this change we can enable the statically linked launch

Re: RFR: 8196896: Use SYSROOT_CFLAGS in dtrace gensrc

2025-03-21 Thread Erik Joelsson
On Fri, 21 Mar 2025 15:30:58 GMT, Magnus Ihse Bursie wrote: > We are missing `$(SYSROOT_CFLAGS)` when calling `$(CPP)` directly (instead of > going via `SetupNativeCompilation`). Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24160#pullreques

RFR: 8196896: Use SYSROOT_CFLAGS in dtrace gensrc

2025-03-21 Thread Magnus Ihse Bursie
We are missing `$(SYSROOT_CFLAGS)` when calling `$(CPP)` directly (instead of going via `SetupNativeCompilation`). - Commit messages: - 8196896: Use SYSROOT_CFLAGS in dtrace gensrc Changes: https://git.openjdk.org/jdk/pull/24160/files Webrev: https://webrevs.openjdk.org/?repo=jdk

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-21 Thread Joachim Kern
> After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now with this change we can enable the statically linked launch

Re: RFR: 8352618: Remove old deprecated functionality in the build system

2025-03-21 Thread Erik Joelsson
On Fri, 21 Mar 2025 15:17:27 GMT, Magnus Ihse Bursie wrote: > It's time for some spring cleaning in the build system. These checks are for > functionality that has long been deprecated, and should not be in use > anymore. We should remove it to keep the code base simpler. Marked as reviewed by

Re: RFR: 8352481: Extra a.out generated after configure with clang

2025-03-21 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 06:57:04 GMT, SendaoYan wrote: > Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, sho

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v5]

2025-03-21 Thread Martin Doerr
On Fri, 21 Mar 2025 16:19:38 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352618: Remove old deprecated functionality in the build system

2025-03-21 Thread Kim Barrett
On Fri, 21 Mar 2025 15:17:27 GMT, Magnus Ihse Bursie wrote: > It's time for some spring cleaning in the build system. These checks are for > functionality that has long been deprecated, and should not be in use > anymore. We should remove it to keep the code base simpler. Nice cleanup. --

Integrated: 8352506: Simplify make/test/JtregNativeHotspot.gmk

2025-03-21 Thread Magnus Ihse Bursie
On Thu, 20 Mar 2025 12:32:53 GMT, Magnus Ihse Bursie wrote: > The file to setup special arguments to native JTReg Hotspot tests is > needlessly complicated. With some generalisation, we can make it much simpler. This pull request has now been integrated. Changeset: 07667ca2 Author:Magnus I

Re: RFR: 8351277: Remove pipewire from AIX build [v3]

2025-03-21 Thread Alexander Zvegintsev
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

javac stack overflow on loongson3 with zero variant

2025-03-21 Thread Bingwu Zhang
Hi! Recently when packaging OpenJDK 24-ga for AOSC OS, I hit an compilation error on loongson3 (which is a variant of mips64), saying that javac is running out of stack space: > java.lang.StackOverflowError > at jdk.compiler.interim/ com.sun.tools.javac.code.Type.constValue(Type.java:186)

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v4]

2025-03-21 Thread Martin Doerr
On Fri, 21 Mar 2025 11:44:49 GMT, Joachim Kern wrote: >> After "JDK-8339480: Build static-jdk image with a statically linked >> launcher" AIX was not able to build the new target. Therefore with >> "JDK-8345590 AIX 'make all' fails after JDK-8339480" the new target was >> disabled again. >> >

Re: RFR: 8352481: Extra a.out generated after configure with clang [v2]

2025-03-21 Thread SendaoYan
> Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows > as below. This PR add a command to remove the

Re: RFR: 8352481: Extra a.out generated after configure with clang

2025-03-21 Thread SendaoYan
On Thu, 20 Mar 2025 06:57:04 GMT, SendaoYan wrote: > Hi all, > > There is an extra a.out file generated located in repository root directory > after execute the configure command with llvm/clang compiler sometimes, not > always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, sho