Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

2025-03-19 Thread Patrick Zhang
On Wed, 19 Mar 2025 18:28:50 GMT, Erik Joelsson wrote: > The `EXTRA_[C|CXX]FLAGS` variables are not meant to be parameters to > SetupNativeCompilation Actually, the content of EXTRA_[C|CXX]FLAGS is hidden (and mixed together) inside the `JVM_CFLAGS` and get passed to as a parameter to `SetupN

Re: RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

2025-03-19 Thread Patrick Zhang
On Thu, 20 Mar 2025 01:10:19 GMT, Patrick Zhang wrote: > Wouldn't just the change in JvmFlags.gmk be enough to solve your issue? Forgot to mention, one of my initial try-outs (hacking) was: Remove `$(EXTRA_CFLAGS)` from `JVM_CFLAGS`, based on an assumption that all source files under `$(TOPDIR

RFR: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files

2025-03-19 Thread Patrick Zhang
Building jdk with `--with-extra-cflags='-Wno-incompatible-pointer-types'` triggers 1000+ warning messages like `cc1plus: warning: command-line option ‘-Wno-incompatible-pointer-types’ is valid for C/ObjC but not for C++`. The root cause is that `JVM_CFLAGS ` which contains both `EXTRA_CXXFLAGS`

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-19 Thread Alan Bateman
On Tue, 18 Mar 2025 12:31:27 GMT, Magnus Ihse Bursie wrote: > And to be absolutely clear: this PR is just about adding new functionality > that was not present before. Sure but I think it's also an attractive nuisance. The VM is very tightly coupled to java.base and a few other core modules. I

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-19 Thread Erik Joelsson
On Wed, 19 Mar 2025 09:11:05 GMT, Alan Bateman wrote: > For the folks targeting embedded/small environments then I think the right > thing is to publish the packaged modules (JMOD files) for the target platform > and then use `jlink` to create the run-image with the right VM + small set of > m