Integrated: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-18 Thread Matthias Baesken
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. This pull req

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-18 Thread Matthias Baesken
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. Thanks for th

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Erik Joelsson
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. make/modules/java.base/Copy.gmk line 128: > 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ >

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Erik Joelsson
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. If we want to support CDS archives for the imported JVMs, then we would need to modify the loop i

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v2]

2025-03-18 Thread Joachim Kern
> After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now with this change we can enable the statically linked launch

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Joachim Kern
On Mon, 17 Mar 2025 15:01:10 GMT, Joachim Kern wrote: >> Looks like this variable is misspelled (missing "S"). >> >> DEPS := $(STATIC_LIB_FILE), \ >> >> Also note that by default log level INFO is not printed. You would need to >> run the build with `make LOG=info` to see the message. > > Ups,

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. And to be absolutely clear: this PR is just about adding new functionality that was not present b

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Magnus Ihse Bursie
On Tue, 18 Mar 2025 13:09:10 GMT, Erik Joelsson wrote: > If we want to support CDS archives for the imported JVMs, then we would need > to modify the loop in Images.gmk so that it covers them as well. I think that > makes sense to do. Yes, I agree. That, and importing the whole directory, is t

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-18 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. Marked as rev

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now wit

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Magnus Ihse Bursie
On Tue, 18 Mar 2025 10:44:46 GMT, Joachim Kern wrote: >> Ups, thank you for giving me the 'S'. But nevertheless if I make with >> `make all LOG=info` an `$(info generate_export_list: >> $(generate_export_list))` still shows an empty list > > I did not get the SetupExecute to function, even if I

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Joachim Kern
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now wit

Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

2025-03-18 Thread Julian Waters
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse