Re: [Proposal] Add code signing on Windows to the JDK build system

2025-03-13 Thread Magnus Ihse Bursie
On 2025-03-11 20:29, Frederic Thevenet wrote: Hi Magnus, As mentioned before, the core idea here is really just providing a hook for a script to be invoked after the native linker has been called. So while thinking about making this more generic and not Windows specific, it struck me that it

Integrated: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings

2025-03-13 Thread Matthias Baesken
On Mon, 10 Mar 2025 15:38:45 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that > are most likely not needed any more and could be removed. This pull request has now been integrated. Changeset: c3db6671 Author:Matthias Baesken URL:

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-13 Thread Matthias Baesken
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote: >> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > Matthias Baesken has updated the pull request incrementally with one > additional commit sin

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Erik Joelsson
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-13 Thread Magnus Ihse Bursie
On Thu, 13 Mar 2025 13:03:16 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-13 Thread Matthias Baesken
> Seems Wayland is not supported on AIX, so we most likely do not need to build > pipewire on AIX and can remove it from the build. > Reason is that pipewire updates can break the AIX build, so better avoid it > if possible. > > To check if it works, I move the 'pipewire/include' folder away, an

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

2025-03-13 Thread snake66
On Thu, 13 Mar 2025 13:28:32 GMT, Magnus Ihse Bursie wrote: >> snake66 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Unbreak libjdwp build > > Then I think the current solution is fine. Even if OpenBSD is not the primary > goal of you

RFR: JDK-8348598 : Update Libpng to 1.6.47

2025-03-13 Thread Harshitha Onkar
Upgraded Libpng to v1.6.47 - Commit messages: - unused-function added for gcc - libpng upgrade Changes: https://git.openjdk.org/jdk/pull/24021/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24021&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348598 Stats: 4982

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47

2025-03-13 Thread Harshitha Onkar
On Thu, 13 Mar 2025 00:27:46 GMT, Harshitha Onkar wrote: > Upgraded Libpng to v1.6.47 make/modules/java.desktop/lib/ClientLibraries.gmk line 249: > 247: DISABLED_WARNINGS_clang_dgif_lib.c := sign-compare, \ > 248: DISABLED_WARNINGS_clang_gzwrite.c := format-nonliteral, \ > 249:

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

2025-03-13 Thread duke
On Thu, 13 Mar 2025 11:39:14 GMT, snake66 wrote: >> Allows for future support for platforms that require different flags for >> libiconv support. >> >> Sponsored-by: The FreeBSD Foundation > > snake66 has updated the pull request incrementally with one additional commit > since the last revisi

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

2025-03-13 Thread snake66
> Allows for future support for platforms that require different flags for > libiconv support. > > Sponsored-by: The FreeBSD Foundation snake66 has updated the pull request incrementally with one additional commit since the last revision: Unbreak libjdwp build - Changes: - al

Re: RFR: 8351277: Remove pipewire from AIX build

2025-03-13 Thread Matthias Baesken
On Thu, 13 Mar 2025 09:29:38 GMT, Magnus Ihse Bursie wrote: > Can you include a revert of JDK-8349751, which is not needed anymore after > this change? Okay I removed the AIX code from endian.h . - PR Comment: https://git.openjdk.org/jdk/pull/24009#issuecomment-2721177888

RFR: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle

2025-03-13 Thread Mikael Vidstedt
Background: Oracle is updating the version of GCC for building the JDK on Linux to 14.2.0. This change updates the versions of the components used for the (Linux) devkit. Newer versions of ccache use cmake for the build, so some of the logic in `make/devkit/Tools.gmk` had to be updated to suppo

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v3]

2025-03-13 Thread Magnus Ihse Bursie
On Thu, 13 Mar 2025 11:39:14 GMT, snake66 wrote: >> Allows for future support for platforms that require different flags for >> libiconv support. >> >> Sponsored-by: The FreeBSD Foundation > > snake66 has updated the pull request incrementally with one additional commit > since the last revisi

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Severin Gehwolf
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Erik Joelsson
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]

2025-03-13 Thread Alexander Zvegintsev
On Thu, 13 Mar 2025 17:30:33 GMT, Harshitha Onkar wrote: >> Upgraded Libpng to v1.6.47 > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > header update Marked as reviewed by azvegint (Reviewer). - PR Review:

Re: RFR: 8351277: Remove pipewire from AIX build [v2]

2025-03-13 Thread Phil Race
On Thu, 13 Mar 2025 13:06:38 GMT, Matthias Baesken wrote: >> Seems Wayland is not supported on AIX, so we most likely do not need to >> build pipewire on AIX and can remove it from the build. >> Reason is that pipewire updates can break the AIX build, so better avoid it >> if possible. >> >> T

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-13 Thread Severin Gehwolf
On Wed, 12 Mar 2025 15:57:40 GMT, Christoph Langer wrote: > This PR addresses an issue that can be observed when building on Windows with > configure options `--enable-linkable-runtime` and > `--with-external-symbols-in-bundles=public`. > > The problem is that whith this special build configur

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Christoph Langer
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Integrated: 8351323: Parameterize compiler and linker flags for iconv

2025-03-13 Thread snake66
On Tue, 11 Mar 2025 19:22:34 GMT, snake66 wrote: > Allows for future support for platforms that require different flags for > libiconv support. > > Sponsored-by: The FreeBSD Foundation This pull request has now been integrated. Changeset: 771e160d Author:Harald Eilertsen URL: http

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47

2025-03-13 Thread Erik Joelsson
On Thu, 13 Mar 2025 00:27:46 GMT, Harshitha Onkar wrote: > Upgraded Libpng to v1.6.47 Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/24021#pullrequestreview-2682753294

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-13 Thread Matthias Baesken
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote: >> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > Matthias Baesken has updated the pull request incrementally with one > additional commit sin

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v2]

2025-03-13 Thread Harshitha Onkar
> Upgraded Libpng to v1.6.47 Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: header update - Changes: - all: https://git.openjdk.org/jdk/pull/24021/files - new: https://git.openjdk.org/jdk/pull/24021/files/b8f10b8

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]

2025-03-13 Thread Harshitha Onkar
> Upgraded Libpng to v1.6.47 Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision: header update - Changes: - all: https://git.openjdk.org/jdk/pull/24021/files - new: https://git.openjdk.org/jdk/pull/24021/files/e1954bc

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-13 Thread Kevin Walls
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote: >> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > Matthias Baesken has updated the pull request incrementally with one > additional commit sin

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]

2025-03-13 Thread Phil Race
On Thu, 13 Mar 2025 17:30:33 GMT, Harshitha Onkar wrote: >> Upgraded Libpng to v1.6.47 > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > header update I was surprised by how many changes there are. - Marked

Re: RFR: JDK-8348598 : Update Libpng to 1.6.47 [v3]

2025-03-13 Thread Sergey Bylokhov
On Thu, 13 Mar 2025 15:45:12 GMT, Harshitha Onkar wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> header update > > make/modules/java.desktop/lib/ClientLibraries.gmk line 249: > >> 247: DISABLED_WARNINGS_

Re: RFR: 8351603: Change to GCC 14.2.0 for building on Linux at Oracle [v2]

2025-03-13 Thread Mikael Vidstedt
> Background: > > Oracle is updating the version of GCC for building the JDK on Linux to 14.2.0. > > This change updates the versions of the components used for the (Linux) > devkit. Newer versions of ccache use cmake for the build, so some of the > logic in `make/devkit/Tools.gmk` had to be up

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Magnus Ihse Bursie
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8351277: Remove pipewire from AIX build

2025-03-13 Thread Magnus Ihse Bursie
On Wed, 12 Mar 2025 14:52:10 GMT, Matthias Baesken wrote: > Seems Wayland is not supported on AIX, so we most likely do not need to build > pipewire on AIX and can remove it from the build. > Reason is that pipewire updates can break the AIX build, so better avoid it > if possible. > > To chec

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-13 Thread Kevin Walls
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote: >> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > Matthias Baesken has updated the pull request incrementally with one > additional commit sin

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Christoph Langer
> This PR addresses an issue that can be observed when building on Windows with > configure options `--enable-linkable-runtime` and > `--with-external-symbols-in-bundles=public`. > > The problem is that with this special build configuration, we build two sets > of .pdb files for the binaries. T

Re: RFR: 8351323: Parameterize compiler and linker flags for iconv [v2]

2025-03-13 Thread snake66
On Wed, 12 Mar 2025 16:56:32 GMT, Magnus Ihse Bursie wrote: > Also, to double check, are the new variables `ICONV_CFLAGS` and > `ICONV_LDFLAGS` going to be non-empty on BSD? Yes, the current BSD port has the following in `libraries.m4`: if test "x$OPENJDK_TARGET_OS" = "xbsd"; then if te

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public

2025-03-13 Thread Frederic Thevenet
On Wed, 12 Mar 2025 20:00:29 GMT, Erik Joelsson wrote: > What happens with the local debugging experience in the exploded image if you > configure with ` --with-external-symbols-in-bundles=public`? Then the full > debug symbols are only present in the *.full.pdb files. Will the debugger > tool

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Severin Gehwolf
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings [v5]

2025-03-13 Thread Matthias Baesken
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote: >> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > Matthias Baesken has updated the pull request incrementally with one > additional commit sin

Re: RFR: 8351842: Test issues on Windows with combination of --enable-linkable-runtime and --with-external-symbols-in-bundles=public [v2]

2025-03-13 Thread Christoph Langer
On Thu, 13 Mar 2025 07:39:20 GMT, Christoph Langer wrote: >> This PR addresses an issue that can be observed when building on Windows >> with configure options `--enable-linkable-runtime` and >> `--with-external-symbols-in-bundles=public`. >> >> The problem is that with this special build conf