On Mon, 10 Mar 2025 18:28:44 GMT, Jiangli Zhou wrote:
>> Please review this PR that excludes `libjsig` from being statically linked
>> with `static-jdk` `java` launcher by default. Please see details in
>> https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks
>
> Jiangli
On Tue, 11 Mar 2025 13:18:55 GMT, Kevin Walls wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> do not handle the unused variables stuff in this change
>
> make/modules/java.management/Lib.gmk line 35:
>
>> 33:
On Tue, 11 Mar 2025 09:07:40 GMT, Matthias Baesken wrote:
>> My motivation was that the comment brings not much value because it just
>> states the obvious. But if you like I can bring back the comment.
>
> I brought back the comment, maybe it is better to keep it because of
> consistency.
Tha
On Wed, 12 Mar 2025 11:15:02 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
> are most likely not needed any more and could be removed.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
do not handle the unused variables stuff i
On Mon, 10 Mar 2025 11:03:06 GMT, Magnus Ihse Bursie wrote:
>> Please review this PR that excludes `libjsig` from being statically linked
>> with `static-jdk` `java` launcher by default. Please see details in
>> https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks
>
> Wi
Seems Wayland is not supported on AIX, so we most likely do not need to build
pipewire on AIX and can remove it from the build.
Reason is that pipewire updates can break the AIX build, so better avoid it if
possible.
To check if it works, I move the 'pipewire/include' folder away, and the build
On Wed, 12 Mar 2025 11:15:01 GMT, Magnus Ihse Bursie wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adjust jdk.management/Lib.gmk
>
> src/java.management/share/native/libmanagement/VMManagementImpl.c line 41:
> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
> are most likely not needed any more and could be removed.
Matthias Baesken has updated the pull request incrementally with one additional
commit since the last revision:
move code back in VMManagementImpl
--
> Allows for future support for platforms that require different flags for
> libiconv support.
>
> Sponsored-by: The FreeBSD Foundation
snake66 has updated the pull request incrementally with one additional commit
since the last revision:
Set ICONV_* flags for aix and macosx only
--
This PR addresses an issue that can be observed when building on Windows with
configure options `--enable-linkable-runtime` and
`--with-external-symbols-in-bundles=public`.
The problem is that whith this special build configuration, we build two sets
of .pdb files for the binaries. The first se
On Wed, 5 Mar 2025 22:59:06 GMT, Jiangli Zhou wrote:
> Please review this PR that excludes `libjsig` from being statically linked
> with `static-jdk` `java` launcher by default. Please see details in
> https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks
This pull reque
On Wed, 12 Mar 2025 12:45:48 GMT, Matthias Baesken wrote:
>> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that
>> are most likely not needed any more and could be removed.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit sin
On Wed, 12 Mar 2025 17:17:41 GMT, Magnus Ihse Bursie wrote:
>> David Linus Briemann has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> make editorconfig hotspot specific
>
> src/hotspot/.editorconfig line 1:
>
>> 1: [*.{cpp,hpp,c,h}]
>
>
On Wed, 12 Mar 2025 15:57:40 GMT, Christoph Langer wrote:
> This PR addresses an issue that can be observed when building on Windows with
> configure options `--enable-linkable-runtime` and
> `--with-external-symbols-in-bundles=public`.
>
> The problem is that whith this special build configur
On Wed, 12 Mar 2025 11:13:41 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.management/Lib.gmk line 35:
>>
>>> 33:
>>> 34: LIBMANAGEMENT_OPTIMIZATION := HIGH
>>> 35: ifeq ($(call isTargetOs, linux)+$(COMPILE_WITH_DEBUG_SYMBOLS),
>>> true+true)
>>
>> On removal of `ifeq ($(call isTargetOs
On Wed, 12 Mar 2025 12:15:18 GMT, Magnus Ihse Bursie wrote:
> > Another way to phrase this is perhaps: "why don't we need iconv on linux?"
>
> I googled this and can answer it myself: because `iconv()` is built into
> glibc.
Yes, that's what I came to as well. Sorry I didn't include that info
On Tue, 11 Mar 2025 19:45:58 GMT, snake66 wrote:
> We could just do:
>
> ```
> CFLAGS := $(LIBSPLASHSCREEN_CFLAGS) \
> $(GIFLIB_CFLAGS) $(LIBJPEG_CFLAGS) $(PNG_CFLAGS) $(LIBZ_CFLAGS) \
> $(ICONV_CFLAGS), \
> ```
>
> The reason I kept it separate for now is that it used
On Tue, 11 Mar 2025 09:12:45 GMT, David Linus Briemann wrote:
>> Add an .editorconfig to define indentation, trim trailing whitespace and
>> open curly brace position for C++ and Java.
>> This allows various editors to easily infer basics of the coding style.
>
> David Linus Briemann has updated
On Wed, 12 Mar 2025 13:57:43 GMT, snake66 wrote:
>> Allows for future support for platforms that require different flags for
>> libiconv support.
>>
>> Sponsored-by: The FreeBSD Foundation
>
> snake66 has updated the pull request incrementally with one additional commit
> since the last revisi
On Wed, 12 Mar 2025 20:00:29 GMT, Erik Joelsson wrote:
> What happens with the local debugging experience in the exploded image if you
> configure with ` --with-external-symbols-in-bundles=public`?
Do we care about the local debugging experience in that case? I'd argue if good
debug experience
On Wed, 12 Mar 2025 20:07:21 GMT, Severin Gehwolf wrote:
> > What happens with the local debugging experience in the exploded image if
> > you configure with ` --with-external-symbols-in-bundles=public`?
>
> Do we care about the local debugging experience in that case? I'd argue if
> good debu
On Wed, 12 Mar 2025 19:51:51 GMT, David Linus Briemann wrote:
>> src/hotspot/.editorconfig line 1:
>>
>>> 1: [*.{cpp,hpp,c,h}]
>>
>> There are no C files in Hotspot, nor should there ever be. (There are a
>> handful of .h files, though, for interop purposes)
>
> Yes I saw that there are no C f
On Wed, 12 Mar 2025 12:12:37 GMT, Magnus Ihse Bursie wrote:
> Another way to phrase this is perhaps: "why don't we need iconv on linux?"
I googled this and can answer it myself: because `iconv()` is built into glibc.
So then I guess it makes sense to add ICONV variables globally, and define it
24 matches
Mail list logo
