Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Mon, 10 Mar 2025 09:49:44 GMT, Aleksey Shipilev wrote: >> This PR implements JEP 503: Remove the 32-bit x86 Port. >> >> The JEP is proposed to target 25, we would not integrate until JEP is ready. >> Reviews are appreciated meanwhile. >> >> This is only the removal of obvious 32-bit x86 par

Re: RFR: 8345940: Migrate security-related resources from Java classes to properties files [v9]

2025-03-10 Thread Justin Lu
On Mon, 10 Mar 2025 17:57:42 GMT, Artur Barashev wrote: >> These resources files are in Java classes. If converted to properties files, >> the localized versions can use UTF-8 encoding directly. >> >> ./src/java.base/share/classes/sun/security/tools/keytool/Resources.java >> ./src/java.base/sha

Re: RFR: 8345940: Migrate security-related resources from Java classes to properties files [v4]

2025-03-10 Thread Justin Lu
On Mon, 10 Mar 2025 14:33:14 GMT, Artur Barashev wrote: >> src/jdk.jartool/share/classes/sun/security/tools/jarsigner/resources/jarsigner_de.properties >> line 40: >> >>> 38: >>> If.keystore.is.not.password.protected.then.storepass.and.keypass.must.not.be.specified=Wenn >>> der Keystore nicht

Re: RFR: 8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace

2025-03-10 Thread David Linus Briemann
On Wed, 19 Feb 2025 12:27:58 GMT, David Linus Briemann wrote: > Add an .editorconfig to define indentation, trim trailing whitespace and open > curly brace position for C++ and Java. > This allows various editors to easily infer basics of the coding style. Thank you both for your input. I added

Integrated: 8351399: AIX: clang pollutes the burned-in library search paths of the generated executables / Second try with a better solution than JDK8348663

2025-03-10 Thread Joachim Kern
On Fri, 7 Mar 2025 09:28:15 GMT, Joachim Kern wrote: > With > [JDK-8348663](https://bugs.openjdk.org/browse/JDK-8348663) [AIX] clang > pollutes the burned-in library search paths of the generated executables > an ugly workaround was introduced to get rid of the unwanted list of search > librari

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v3]

2025-03-10 Thread Magnus Ihse Bursie
On Wed, 5 Mar 2025 02:10:34 GMT, SendaoYan wrote: >> Hi all, >> >> This PR fix the makefile bug when there is no gtest 'disable tests' then >> report syntax error. >> >> Before this PR makefile used below command to get the 'disable tests' >> number, when there is no 'YOU HAVE [0-9]+ DISABLED

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: 8351309: test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java fails on static-jdk

2025-03-10 Thread Paul Woegerer
On Fri, 7 Mar 2025 09:22:44 GMT, Doug Simon wrote: >>> It seems we agree that we need, at some point, to have a high-level >>> discussion on if libjsig should be supported on static builds, and if so, >>> how it should be implemented. We also agree that having signal chaining >>> enabled by de

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Mon, 10 Mar 2025 09:49:44 GMT, Aleksey Shipilev wrote: >> This PR implements JEP 503: Remove the 32-bit x86 Port. >> >> The JEP is proposed to target 25, we would not integrate until JEP is ready. >> Reviews are appreciated meanwhile. >> >> This is only the removal of obvious 32-bit x86 par

Re: RFR: 8351440: Link with -reproducible on macOS

2025-03-10 Thread Magnus Ihse Bursie
On Fri, 7 Mar 2025 20:46:32 GMT, Mikael Vidstedt wrote: > Background (from JBS): > > Recent versions of Xcode, most likely starting with Xcode 15, do not produce > deterministic binaries/libraries out of the box. In particular, the UUID data > in the LC_UUID load command is not stable. > > Af

Re: RFR: 8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace

2025-03-10 Thread Kim Barrett
On Mon, 10 Mar 2025 08:57:11 GMT, David Linus Briemann wrote: > As for the coding style (indentation), I followed the official style guides > to define this. > > For C++ we have > https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md#whitespace > > which states: > > > Indentation l

Re: RFR: 8351309: test/hotspot/jtreg/runtime/posixSig/TestPosixSig.java fails on static-jdk

2025-03-10 Thread Magnus Ihse Bursie
On Wed, 5 Mar 2025 22:59:06 GMT, Jiangli Zhou wrote: > Please review this PR that excludes `libjsig` from being statically linked > with `static-jdk` `java` launcher by default. Please see details in > https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks With that confi

Re: RFR: 8351542: LIBMANAGEMENT_OPTIMIZATION remove special optimization settings

2025-03-10 Thread Matthias Baesken
On Mon, 10 Mar 2025 17:32:07 GMT, Erik Joelsson wrote: >> On Linux there are some special settings for LIBMANAGEMENT_OPTIMIZATION that >> are most likely not needed any more and could be removed. > > make/modules/java.management/Lib.gmk line 33: > >> 31: ## Build libmanagement >> 32: >> ##

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port [v2]

2025-03-10 Thread Coleen Phillimore
On Mon, 10 Mar 2025 09:49:44 GMT, Aleksey Shipilev wrote: >> This PR implements JEP 503: Remove the 32-bit x86 Port. >> >> The JEP is proposed to target 25, we would not integrate until JEP is ready. >> Reviews are appreciated meanwhile. >> >> This is only the removal of obvious 32-bit x86 par

Re: LIBMANAGEMENT_OPTIMIZATION special settings on Linux with debug symbols

2025-03-10 Thread Erik Joelsson
On 3/10/25 5:02 AM, Baesken, Matthias wrote: Hello, while looking at the JDK native lib optimization levels, I noticed this special setting : make/modules/java.management/Lib.gmk ifeq ($(call isTargetOs, linux)+$(COMPILE_WITH_DEBUG_SYMBOLS), true+true) LIBMANAGEMENT_OPTIMIZATION := LOW end

Re: RFR: 8345169: Implement JEP 503: Remove the 32-bit x86 Port [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Mon, 10 Mar 2025 09:46:38 GMT, Aleksey Shipilev wrote: >> The `--enable-deprecated-ports` is still there. All that is removed is an if >> statement and a print line. I know the make syntax can seem intimidating, >> but just ask me or any other build team member if you need help to recreate

Re: RFR: 8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace [v2]

2025-03-10 Thread Kim Barrett
On Mon, 10 Mar 2025 09:03:40 GMT, David Linus Briemann wrote: >> Add an .editorconfig to define indentation, trim trailing whitespace and >> open curly brace position for C++ and Java. >> This allows various editors to easily infer basics of the coding style. > > David Linus Briemann has updated