Re: RFR: 8351154: Use -ftrivial-auto-var-init=pattern for clang too

2025-03-04 Thread Erik Joelsson
On Tue, 4 Mar 2025 11:31:03 GMT, Magnus Ihse Bursie wrote: > This is a trivial (no pun intended) follow-up to > [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), which just > enables the -ftrivial-auto-var-init=pattern on debug builds for clang too. In > contrast to gcc, the clang op

Re: RFR: 8351154: Use -ftrivial-auto-var-init=pattern for clang too

2025-03-04 Thread Kim Barrett
On Tue, 4 Mar 2025 11:31:03 GMT, Magnus Ihse Bursie wrote: > This is a trivial (no pun intended) follow-up to > [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), which just > enables the -ftrivial-auto-var-init=pattern on debug builds for clang too. In > contrast to gcc, the clang op

Re: RFR: 8351154: Use -ftrivial-auto-var-init=pattern for clang too

2025-03-04 Thread Matthias Baesken
On Tue, 4 Mar 2025 14:53:13 GMT, Magnus Ihse Bursie wrote: > @MBaesken Can you or your colleagues check that this works on AIX? A fastdebug build with the patch applied worked on AIX . - PR Comment: https://git.openjdk.org/jdk/pull/23892#issuecomment-2698127030

Re: RFR: 8351154: Use -ftrivial-auto-var-init=pattern for clang too

2025-03-04 Thread Magnus Ihse Bursie
On Tue, 4 Mar 2025 11:31:03 GMT, Magnus Ihse Bursie wrote: > This is a trivial (no pun intended) follow-up to > [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), which just > enables the -ftrivial-auto-var-init=pattern on debug builds for clang too. In > contrast to gcc, the clang op

Re: RFR: 8351138: Running subset of gtests gets error printing result information

2025-03-04 Thread Erik Joelsson
On Tue, 4 Mar 2025 16:22:43 GMT, SendaoYan wrote: > Hi all, > > This PR fix the makefile bug when there is no gtest 'disable tests' then > report syntax error. > > Before this PR makefile used below command to get the 'disable tests' number, > when there is no 'YOU HAVE [0-9]+ DISABLED TEST'

RFR: 8351138: Running subset of gtests gets error printing result information

2025-03-04 Thread SendaoYan
Hi all, This PR fix the makefile bug when there is no gtest 'disable tests' then report syntax error. Before this PR makefile used below command to get the 'disable tests' number, when there is no 'YOU HAVE [0-9]+ DISABLED TEST' string line in gtest result file gtest.txt, this gawk command wil

RFR: 8350952: Remove some non present files from OPT_SPEED_SRC list

2025-03-04 Thread Matthias Baesken
JvmFeatures.gmk contains a file list OPT_SPEED_SRC , the list contains files that have to be optimized for speed when the other files are optimized for binary size. However some non present files are mentioned and should be removed e.g. genCollectedHeap.cpp hashtable.cpp markSweep.cpp Maybe they

RFR: JDK-8348597 : Update HarfBuzz to 10.4.0

2025-03-04 Thread Harshitha Onkar
Harfbuzz upgraded to v10.4.0 File changes - **Newly added files** libharfbuzz/OT/Var/VARC/VARC.hh libharfbuzz/OT/Var/VARC/coord-setter.hh libharfbuzz/hb-decycler.hh libharfbuzz/hb-geometry.hh libharfbuzz/hb-ot-var-varc-table.hh libharfbuzz/hb-subset-instancer-iup.hh libharfbuzz/hb-subset-ser

RFR: 8351241: Require minimum gcc version 12

2025-03-04 Thread SendaoYan
Hi all, After [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), the minumum gcc version should be 12. [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627) add gcc compile option -ftrivial-auto-var-init=pattern for debug build, -ftrivial-auto-var-init=pattern gcc option was supp

Re: RFR: 8351241: Require minimum gcc version 12

2025-03-04 Thread David Holmes
On Wed, 5 Mar 2025 07:21:17 GMT, SendaoYan wrote: > After [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), the minumum > gcc version should be 12 Or JDK-8345627 change should only be enabled when gcc version is >= 12. - PR Comment: https://git.openjdk.org/jdk/pull/23913

Re: RFR: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds [v2]

2025-03-04 Thread Magnus Ihse Bursie
On Fri, 28 Feb 2025 10:28:57 GMT, Kim Barrett wrote: > Visual Studio provides a similar mechanism, InitAll. Unfortunately, the option to enable this (`/initall`) is not officially documented, so I guess that implies that we should not use it. :-( - PR Comment: https://git.openjdk.

RFR: 8351154: Use -ftrivial-auto-var-init=pattern for clang too

2025-03-04 Thread Magnus Ihse Bursie
This is a trivial (no pun intended) follow-up to [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), which just enables the -ftrivial-auto-var-init=pattern on debug builds for clang too. In contrast to gcc, the clang option did not trigger any additional warnings, so it is just about en

Integrated: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds

2025-03-04 Thread Magnus Ihse Bursie
On Wed, 11 Dec 2024 21:14:04 GMT, Magnus Ihse Bursie wrote: > This is a retry to add `-ftrivial-auto-var-init=pattern` to gcc debug builds. > The first attempt was buggy in multiple ways and had to be backed out. > > This is the description of the original bug report: > > gcc12 has added -ftri

Re: RFR: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds [v2]

2025-03-04 Thread Magnus Ihse Bursie
On Fri, 28 Feb 2025 10:28:57 GMT, Kim Barrett wrote: > I think we still want this new option, but maybe there should be some way to turn it off? Either with a configure argument explicitly, or a way for enabling something like msan (which we don't currently support) to disable this warning. Let'

Re: RFR: 8351241: Require minimum gcc version 12

2025-03-04 Thread SendaoYan
On Wed, 5 Mar 2025 07:32:32 GMT, David Holmes wrote: > > After [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), the > > minumum gcc version should be 12 > > Or JDK-8345627 change should only be enabled when gcc version is >= 12. JDK-8345627 has already check the gcc compiler support

Integrated: 8351154: Use -ftrivial-auto-var-init=pattern for clang too

2025-03-04 Thread Magnus Ihse Bursie
On Tue, 4 Mar 2025 11:31:03 GMT, Magnus Ihse Bursie wrote: > This is a trivial (no pun intended) follow-up to > [JDK-8345627](https://bugs.openjdk.org/browse/JDK-8345627), which just > enables the -ftrivial-auto-var-init=pattern on debug builds for clang too. In > contrast to gcc, the clang op

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v3]

2025-03-04 Thread SendaoYan
On Tue, 4 Mar 2025 17:17:32 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert regex change in if expr > > make/RunTests.gmk line 543: > >> 541: '/YOU HAVE [0-9]+ DISABLED TEST/ {

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v2]

2025-03-04 Thread SendaoYan
On Tue, 4 Mar 2025 17:16:41 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make END keyword at the same level as the regrex line > > make/RunTests.gmk line 546: > >> 544: found

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v2]

2025-03-04 Thread SendaoYan
> Hi all, > > This PR fix the makefile bug when there is no gtest 'disable tests' then > report syntax error. > > Before this PR makefile used below command to get the 'disable tests' number, > when there is no 'YOU HAVE [0-9]+ DISABLED TEST' string line in gtest result > file gtest.txt, this

Re: RFR: 8351138: Running subset of gtests gets error printing result information [v3]

2025-03-04 Thread SendaoYan
> Hi all, > > This PR fix the makefile bug when there is no gtest 'disable tests' then > report syntax error. > > Before this PR makefile used below command to get the 'disable tests' number, > when there is no 'YOU HAVE [0-9]+ DISABLED TEST' string line in gtest result > file gtest.txt, this