On Wed, 26 Feb 2025 22:26:58 GMT, Mikael Vidstedt wrote:
> Core files may from time to time end up in the source tree of the JDK, adding
> noise in git etc. Because we have valid files and directories called "core*"
> in the tree it's non-trivial to exclude any and all core files, but as a
> s
On Wed, 26 Feb 2025 22:26:58 GMT, Mikael Vidstedt wrote:
> Core files may from time to time end up in the source tree of the JDK, adding
> noise in git etc. Because we have valid files and directories called "core*"
> in the tree it's non-trivial to exclude any and all core files, but as a
> s
On Fri, 21 Feb 2025 00:01:36 GMT, Chen Liang wrote:
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by
On Fri, 28 Feb 2025 15:57:18 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 14:39:23 GMT, Magnus Ihse Bursie wrote:
>> Left a space and an extra note to make the comment hash more obvious.
>
> Unless you plan to shortly push a new PR where you either enable this
> functionality, or remove the commented-out lines, I strongly prefer *not* to
> have co
On Wed, 26 Feb 2025 13:24:57 GMT, Matthias Baesken wrote:
>> I think it might be worth trying to take a more structured approach to the
>> optimizations used. Maybe setup a wiki page with all native libraries, what
>> current optimization levels they use, and what the difference in size would
On Fri, 28 Feb 2025 15:57:18 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 25 Feb 2025 00:51:55 GMT, Calvin Cheung wrote:
> A simple fix in `os::jvm_path()` so that gtest can be run with CDS
> (`-Xshare:on`). The fix is just to change the directory name from `hotspot`
> to `server`.
> Note that the bug doesn't exist on macOS and thus no change is required for
On Fri, 28 Feb 2025 10:37:17 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> noStride -> constantOffset, optimize VH classes to have only 2 instead of
>> 3 classes for each type
>
> src/jav
On Tue, 18 Feb 2025 13:44:56 GMT, Matthias Baesken wrote:
> > @MBaesken Currently with LTO active on gcc 14 commit
> > [e648a90](https://github.com/openjdk/jdk/commit/e648a907b31fd0d6b746d149fda2a8d5fbe26dc0)
> > is causing serious trouble on my end by mass inlining everything, bloating
> > th
On Fri, 28 Feb 2025 15:57:18 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Thu, 27 Feb 2025 12:42:35 GMT, David Holmes wrote:
>>> Also,
>>>
>>> > That presumes you are dealing with a single variant JDK, not one that has
>>> > both client and server.
>>>
>>> Is this even relevant anymore? Afaik, the last platform to have both client
>>> and server where 32-bit Win
> Simplify the layout access var handles to be direct in some common cases.
> Also made `VarHandle::isAccessModeSupported` report if an access mode is
> supported for a VH.
>
> Reduces the instructions to execute this code in a simple main by 47%:
>
> long[] arr = new long[8];
> var ms = Memory
On Wed, 26 Feb 2025 13:24:57 GMT, Matthias Baesken wrote:
>> I think it might be worth trying to take a more structured approach to the
>> optimizations used. Maybe setup a wiki page with all native libraries, what
>> current optimization levels they use, and what the difference in size would
On Fri, 28 Feb 2025 10:21:27 GMT, Maurizio Cimadamore
wrote:
>> Maybe something like `isOffsetFixed` or `hasFixedOffset` would be better?
>
> (I suggested renaming to something that didn't contain the term "offset" --
> it's a subjective thing and if I'm in the minority that's ok. Maybe
> `noI
On Fri, 28 Feb 2025 10:38:28 GMT, Maurizio Cimadamore
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> noStride -> constantOffset, optimize VH classes to have only 2 instead of
>> 3 classes for each type
>
> src/jav
On Thu, 27 Feb 2025 14:17:27 GMT, Jorn Vernee wrote:
>> Well, the reason I removed the eager init is that their creation in clinit
>> is super costly. Also I think one pair of getter + creator is better than 3
>> pairs.
>
>> ... their creation in clinit is super costly
>
> You mean because th
On Fri, 28 Feb 2025 10:29:46 GMT, Maurizio Cimadamore
wrote:
> I have observed the same thing -- these helper method handles lead to some
> bytecode spinning
Although - that was before; in the new code these helpers don't do
adaptation... so it should be ok. (I also see the code has been upda
On Tue, 25 Feb 2025 09:51:08 GMT, Maurizio Cimadamore
wrote:
>> Benchmark results for the latest revision appears performance neutral.
>> bytestacks same as last revision. 11 jobs left in tier 1-3, no failure so
>> far. Also created CSR for this minor behavioral change.
>>
>> Benchmark
On Thu, 27 Feb 2025 16:00:47 GMT, Chen Liang wrote:
>> Simplify the layout access var handles to be direct in some common cases.
>> Also made `VarHandle::isAccessModeSupported` report if an access mode is
>> supported for a VH.
>>
>> Reduces the instructions to execute this code in a simple ma
On Tue, 19 Nov 2024 16:15:42 GMT, Ivan Bereziuk wrote:
> The output for Jtreg v7.5 was
> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947)
> with [information about skipped
> tests](https://github.com/openjdk/j
On Thu, 27 Feb 2025 14:21:17 GMT, Jorn Vernee wrote:
>> In last revision I called it `fixedOffset`, but it becomes confusing with
>> the actual fixed value of the offset.
>
> Maybe something like `isOffsetFixed` or `hasFixedOffset` would be better?
(I suggested renaming to something that didn't
On Tue, 25 Feb 2025 15:36:39 GMT, Magnus Ihse Bursie wrote:
>> This is a retry to add `-ftrivial-auto-var-init=pattern` to gcc debug
>> builds. The first attempt was buggy in multiple ways and had to be backed
>> out.
>>
>> This is the description of the original bug report:
>>
>> gcc12 has a
On Fri, 28 Feb 2025 00:37:24 GMT, Calvin Cheung wrote:
>> A simple fix in `os::jvm_path()` so that gtest can be run with CDS
>> (`-Xshare:on`). The fix is just to change the directory name from `hotspot`
>> to `server`.
>> Note that the bug doesn't exist on macOS and thus no change is required
On Wed, 26 Feb 2025 19:07:12 GMT, Magnus Ihse Bursie wrote:
>> Ivan Bereziuk has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> co
25 matches
Mail list logo
