On Thu, 20 Feb 2025 21:39:17 GMT, Chris Plummer wrote:
> I just don't feel comfortable tinkering with the flags in this manner when we
> aren't sure of the potential performance impact. The footprint improvement is
> somewhat negligible in the big picture.
Without good benchmarks it is hard to
On Thu, 20 Feb 2025 23:44:44 GMT, Jiangli Zhou wrote:
> Updated to skipping
> `java/lang/String/nativeEncoding/StringPlatformChars.java` on static JDK.
Thanks. If you can bump the copyright header date then I think we are done with
this one.
-
PR Comment: https://git.openjdk.org/
Simplify the layout access var handles to be direct in some common cases. Also
made `VarHandle::isAccessModeSupported` report if an access mode is supported
for a VH.
Reduces the instructions to execute this code in a simple main by 47%:
long[] arr = new long[8];
var ms = MemorySegment.ofArray(
> Please review the fix to make
> `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test:
>
> - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and
> `JNU_NewStringPlatform` dynamically
> - Remove `#include "jni_util.h"` and don't link `libstringPlatformChars.so`
> with `
On Fri, 14 Feb 2025 18:31:52 GMT, Jiangli Zhou wrote:
> Please review the fix to make
> `java/lang/String/nativeEncoding/StringPlatformChars.java` jtreg test:
>
> - Lookup `JNU_GetStringPlatformChars`, `JNU_ClassString` and
> `JNU_NewStringPlatform` dynamically
> - Remove `#include "jni_util.
On Wed, 19 Feb 2025 17:12:55 GMT, Chris Plummer wrote:
> I'm not sure how the decision was made to go with LOW for libjdwp.
>From what I heard from Magnus, those settings were done ages ago , before
>recent compiler switches and even before the current build system was
>introduced.
We switch
On Wed, 19 Feb 2025 14:34:37 GMT, Nizar Benalla wrote:
> This patch fixes a regression where the windows tools man pages appeared on
> the Linux and the MacOS builds
>
> The man pages found using `FindModuleManDirs` were used in both `Docs.gmk`
> used to generate the documentation for the JDK
On Thu, 6 Feb 2025 17:01:04 GMT, Aleksey Shipilev wrote:
>> Please review this change that adds a `linux-x86-static` job in GHA. The job
>> builds the `static-jdk-image` release binary on linux-x64. Please see
>> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for
>> so
On Thu, 20 Feb 2025 15:52:19 GMT, Nizar Benalla wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> respond to feedback
>
> Thanks for reviewing Erik.
Thank you @nizarbenalla and @erikj79 for resolving this!
---
On Wed, 19 Feb 2025 16:05:15 GMT, Nizar Benalla wrote:
>> This patch fixes a regression where the windows tools man pages appeared on
>> the Linux and the MacOS builds
>>
>> The man pages found using `FindModuleManDirs` were used in both `Docs.gmk`
>> used to generate the documentation for the
On Wed, 12 Feb 2025 20:37:26 GMT, Erik Joelsson wrote:
> The new framework for tracing makefile inclusion has a bug. In the
> Make[Include|Snippet]End.gmk files, the variables THIS_INCLUDE and
> THIS_SNIPPET respectively are restored from the HELPER_STACK variable. The
> problem is that we can
Noticed this when reviewing
[JDK-8349399](https://bugs.openjdk.org/browse/JDK-8349399), which had to kludgy
workaround the hunk introduced by `static-libs-bundles` addition
([JDK-8337265](https://bugs.openjdk.org/browse/JDK-8337265)). I am somewhat
surprised we even have `static-libs-bundles` a
On Wed, 12 Feb 2025 20:37:26 GMT, Erik Joelsson wrote:
> The new framework for tracing makefile inclusion has a bug. In the
> Make[Include|Snippet]End.gmk files, the variables THIS_INCLUDE and
> THIS_SNIPPET respectively are restored from the HELPER_STACK variable. The
> problem is that we can
On Thu, 20 Feb 2025 15:58:03 GMT, Aleksey Shipilev wrote:
> > @shipilev Can you help review/approve the change, if no other questions?
>
> Sorry for not looking at this sooner.
>
> It looks to me that you are trying to work-around a little mess introduced by
> `static-libs-bundles` addition
>
On Thu, 20 Feb 2025 17:15:13 GMT, Aleksey Shipilev wrote:
> Noticed this when reviewing
> [JDK-8349399](https://bugs.openjdk.org/browse/JDK-8349399), which had to
> kludgy workaround the hunk introduced by `static-libs-bundles` addition
> ([JDK-8337265](https://bugs.openjdk.org/browse/JDK-8337
This PR is a prototype to stimulate discussion of
[JDK-8261669](https://bugs.openjdk.org/browse/JDK-8261669), which seeks to add
more warnings when an implicit cast of a primitive value might lose
information. This can possibly happen when converting an `int` to `float`, or
when converting a `l
On Thu, 20 Feb 2025 17:15:13 GMT, Aleksey Shipilev wrote:
> Noticed this when reviewing
> [JDK-8349399](https://bugs.openjdk.org/browse/JDK-8349399), which had to
> kludgy workaround the hunk introduced by `static-libs-bundles` addition
> ([JDK-8337265](https://bugs.openjdk.org/browse/JDK-8337
On Tue, 11 Feb 2025 15:56:39 GMT, Matthias Baesken wrote:
> The libjdwp is currently built with LOW optimization level, it could be built
> with SIZE optimization to lower the lib size by ~ 10 % on UNIX.
> On Windows LOW and SIZE currently translate to the same O1 optimization flag
> so no diff
On Thu, 20 Feb 2025 20:57:47 GMT, Archie Cobbs wrote:
> This PR is a prototype to stimulate discussion of
> [JDK-8261669](https://bugs.openjdk.org/browse/JDK-8261669), which seeks to
> add more warnings when an implicit cast of a primitive value might lose
> information. This can possibly happ
19 matches
Mail list logo
