Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Phil Race
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary [v2]

2025-02-07 Thread Leonid Mesnik
> The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: Update make/test/BuildTestLib.gmk Co-authored-by: Erik Joelsson <375974

Re: RFR: 8349284: Make libExplicitAttach work on static JDK [v2]

2025-02-07 Thread Jiangli Zhou
> This is similar to https://github.com/openjdk/jdk/pull/23431 change. It > removes libjvm.so as a recorded dependency for libExplicitAttach.so by not > explicitly link libExplicitAttach.so with libjvm.so at build time. To do > that, it also changes libExplicitAttach.c to dynamically lookup the

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Harshitha Onkar
On Fri, 7 Feb 2025 14:11:15 GMT, Matthias Baesken wrote: >> What tests have you run? > >> What tests have you run? > > Had this in our internal test queue with jtreg / JCK plus some additional > SAP internal tests. No issues seen. > However I think I have to run some more manual tests on clien

RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary

2025-02-07 Thread Leonid Mesnik
The fix add remaining classes to the testlibrary jar and fix some warnings in security-related classes. - Commit messages: - 8346050: Update BuildTestLib.gmk to build whole testlibrary Changes: https://git.openjdk.org/jdk/pull/23525/files Webrev: https://webrevs.openjdk.org/?repo

Re: RFR: 8349284: Make libExplicitAttach work on static JDK

2025-02-07 Thread Jiangli Zhou
On Fri, 7 Feb 2025 10:38:37 GMT, Alan Bateman wrote: > Can you look at adding native init method instead? This could be called from > the System.loadLibraray and avoid introduce a side effect of startThreads > initialising GetCreatedJavaVMs. Done, thanks. Moved `JNI_GetCreatedJavaVMs` lookup i

Re: RFR: 8349178: runtime/jni/atExit/TestAtExit.java should be supported on static JDK

2025-02-07 Thread Jiangli Zhou
On Tue, 4 Feb 2025 19:04:22 GMT, Alan Bateman wrote: >> Also to point it out if it's not clear already, `libjvm.so` is >> implementation detail. One cannot safely that exists at runtime. The static >> JDK case is a good example. > >> @jianglizhou I will be brutally honest and say that I do not

Re: RFR: 8346050: Update BuildTestLib.gmk to build whole testlibrary

2025-02-07 Thread Erik Joelsson
On Fri, 7 Feb 2025 21:15:36 GMT, Leonid Mesnik wrote: > The fix add remaining classes to the testlibrary jar and fix some warnings in > security-related classes. make/test/BuildTestLib.gmk line 61: > 59: > 60: ifeq ($(call isTargetOs, linux), false) > 61: EXCLUDE_DIRS := jdk/test/lib/cont

Re: RFR: 8349284: Make libExplicitAttach work on static JDK

2025-02-07 Thread Alan Bateman
On Thu, 6 Feb 2025 20:14:36 GMT, Jiangli Zhou wrote: > This is similar to https://github.com/openjdk/jdk/pull/23431 change. It > removes libjvm.so as a recorded dependency for libExplicitAttach.so by not > explicitly link libExplicitAttach.so with libjvm.so at build time. To do > that, it also

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Matthias Baesken
On Thu, 6 Feb 2025 14:03:16 GMT, Erik Joelsson wrote: >> The splashscreen lib is currently built with LOW optimization. >> This might be fine because it is not very performance critical (and LOW is >> not really low when looking at the opt-flags used). >> But building it with SIZE optimization

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Magnus Ihse Bursie
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Matthias Baesken
On Fri, 7 Feb 2025 13:08:17 GMT, Magnus Ihse Bursie wrote: > What tests have you run? Had this in our internal test queue with jtreg / JCK plus some additional SAP internal tests. No issues seen. However I think I have to run some more manual tests on client like setups. Unfortunately my Li

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-02-07 Thread Magnus Ihse Bursie
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote: >> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on >> clang 17) as a feasible compiler for jdk25, because in combination with the >> 17.1.3 runtime this would enable the support for ubsan. >> Unfortunately, the new