Re: RFR: 8343832: Enhance test summary with number of skipped tests [v6]

2025-02-06 Thread Ivan Bereziuk
On Tue, 7 Jan 2025 09:04:28 GMT, Ivan Bereziuk wrote: >> The output for Jtreg v7.5 was >> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) >> with [information about skipped >> tests](https://github.com/openjd

Integrated: 8349140: Size optimization (opt-size) build fails after recent PCH changes

2025-02-06 Thread Matthias Baesken
On Tue, 4 Feb 2025 15:35:03 GMT, Matthias Baesken wrote: > When using the configure flag --enable-jvm-feature-opt-size (linux x86_64 opt > build, gcc 11 devkit) we run into this error after the recent PCH related > changes : > > > cc1plus: error: > /build_optsize/hotspot/variant-server/libjv

Re: RFR: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Martin Doerr
On Thu, 6 Feb 2025 08:58:17 GMT, Matthias Baesken wrote: > The special optimization settings for jvmtiEnterTrace.cpp on AIX can be > removed ; the file compiles now some seconds with or without this workaround. > The special settings were needed for ancient versions of xlC. LGTM.

RFR: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Matthias Baesken
The special optimization settings for jvmtiEnterTrace.cpp on AIX can be removed ; the file compiles now some seconds with or without this workaround. The special settings were needed for ancient versions of xlC. - Commit messages: - JDK-8349375 Changes: https://git.openjdk.org/jdk

Re: RFR: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads

2025-02-06 Thread David Holmes
On Thu, 6 Feb 2025 01:42:41 GMT, Jiangli Zhou wrote: > Please review this minor cleanup. The related jtreg test, > TracePinnedThreads.java/libTracePinnedThreads.c has already been removed by > https://github.com/openjdk/jdk/pull/21565 work (for > [JDK-8338383](https://bugs.openjdk.org/browse/J

Re: RFR: 8323158: HotSpot Style Guide should specify more include ordering [v2]

2025-02-06 Thread Kim Barrett
On Mon, 3 Feb 2025 12:14:35 GMT, Stefan Karlsson wrote: >> The HotSpot Style Guide has a section about source files and includes. The >> style used for includes have mostly been introduced by scripts when >> includeDB was replaced, but also when various other enhancements to our >> includes we

RFR: 8349284: Make libExplicitAttach work on static JDK

2025-02-06 Thread Jiangli Zhou
This is similar to https://github.com/openjdk/jdk/pull/23431 change. It removes libjvm.so as a recorded dependency for libExplicitAttach.so by not explicitly link libExplicitAttach.so with libjvm.so at build time. To do that, it also changes libExplicitAttach.c to dynamically lookup the JNI_GetC

Re: RFR: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Christoph Langer
On Thu, 6 Feb 2025 08:58:17 GMT, Matthias Baesken wrote: > The special optimization settings for jvmtiEnterTrace.cpp on AIX can be > removed ; the file compiles now some seconds with or without this workaround. > The special settings were needed for ancient versions of xlC. Marked as reviewed

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-06 Thread Erik Joelsson
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8348286: [AIX] clang 17 introduces new warning Wtentative-Definitions which produces Build errors [v3]

2025-02-06 Thread Kim Barrett
On Thu, 23 Jan 2025 13:48:06 GMT, Joachim Kern wrote: >> We (SAP) try to introduce the ‘IBM Open XL C/C++ for AIX 17.1.2’ (based on >> clang 17) as a feasible compiler for jdk25, because in combination with the >> 17.1.3 runtime this would enable the support for ubsan. >> Unfortunately, the new

RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-06 Thread Matthias Baesken
The splashscreen lib is currently built with LOW optimization. This might be fine because it is not very performance critical (and LOW is not really low when looking at the opt-flags used). But building it with SIZE optimization makes it 10-20 % smaller on some platforms which helps to reduce im

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-06 Thread Jiangli Zhou
On Thu, 6 Feb 2025 17:01:04 GMT, Aleksey Shipilev wrote: >> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> so

Re: RFR: 8349178: runtime/jni/atExit/TestAtExit.java should be supported on static JDK

2025-02-06 Thread Jiangli Zhou
On Wed, 5 Feb 2025 01:12:49 GMT, David Holmes wrote: >> Also to point it out if it's not clear already, `libjvm.so` is >> implementation detail. One cannot safely that exists at runtime. The static >> JDK case is a good example. > >> Also to point it out if it's not clear already, libjvm.so is

Re: RFR: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Julian Waters
On Thu, 6 Feb 2025 08:58:17 GMT, Matthias Baesken wrote: > The special optimization settings for jvmtiEnterTrace.cpp on AIX can be > removed ; the file compiles now some seconds with or without this workaround. > The special settings were needed for ancient versions of xlC. AIX is typically no

Integrated: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Matthias Baesken
On Thu, 6 Feb 2025 08:58:17 GMT, Matthias Baesken wrote: > The special optimization settings for jvmtiEnterTrace.cpp on AIX can be > removed ; the file compiles now some seconds with or without this workaround. > The special settings were needed for ancient versions of xlC. This pull request h

Re: RFR: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Matthias Baesken
On Thu, 6 Feb 2025 08:58:17 GMT, Matthias Baesken wrote: > The special optimization settings for jvmtiEnterTrace.cpp on AIX can be > removed ; the file compiles now some seconds with or without this workaround. > The special settings were needed for ancient versions of xlC. Thanks for the revi

Re: RFR: 8349375: Cleanup AIX special file build settings

2025-02-06 Thread Erik Joelsson
On Thu, 6 Feb 2025 08:58:17 GMT, Matthias Baesken wrote: > The special optimization settings for jvmtiEnterTrace.cpp on AIX can be > removed ; the file compiles now some seconds with or without this workaround. > The special settings were needed for ancient versions of xlC. Marked as reviewed

Re: RFR: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads

2025-02-06 Thread Erik Joelsson
On Thu, 6 Feb 2025 01:42:41 GMT, Jiangli Zhou wrote: > Please review this minor cleanup. The related jtreg test, > TracePinnedThreads.java/libTracePinnedThreads.c has already been removed by > https://github.com/openjdk/jdk/pull/21565 work (for > [JDK-8338383](https://bugs.openjdk.org/browse/J

Integrated: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads

2025-02-06 Thread Jiangli Zhou
On Thu, 6 Feb 2025 01:42:41 GMT, Jiangli Zhou wrote: > Please review this minor cleanup. The related jtreg test, > TracePinnedThreads.java/libTracePinnedThreads.c has already been removed by > https://github.com/openjdk/jdk/pull/21565 work (for > [JDK-8338383](https://bugs.openjdk.org/browse/J

Re: RFR: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads

2025-02-06 Thread Jiangli Zhou
On Thu, 6 Feb 2025 08:15:48 GMT, David Holmes wrote: >> Please review this minor cleanup. The related jtreg test, >> TracePinnedThreads.java/libTracePinnedThreads.c has already been removed by >> https://github.com/openjdk/jdk/pull/21565 work (for >> [JDK-8338383](https://bugs.openjdk.org/brow

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-06 Thread Jiangli Zhou
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

Re: RFR: 8349399: GHA: Add static-jdk build on linux-x64

2025-02-06 Thread Aleksey Shipilev
On Wed, 5 Feb 2025 19:41:51 GMT, Jiangli Zhou wrote: > Please review this change that adds a `linux-x86-static` job in GHA. The job > builds the `static-jdk-image` release binary on linux-x64. Please see > https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for > some addit

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-06 Thread Matthias Baesken
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m