Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Jiangli Zhou
On Mon, 2 Dec 2024 15:12:24 GMT, Magnus Ihse Bursie wrote: >> Hotspot changes look fine. >> >> Thanks > > @dholmes-ora @coleenp @erikj79 Thanks for your reviews! @magicus Thanks for integrating the changes, particularly reworking and making the statically linked launcher build changes cleaner!

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Magnus Ihse Bursie
On Mon, 2 Dec 2024 15:10:08 GMT, Coleen Phillimore wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into static-jdk-image >> - Remove LDFLAGS_STATIC_JDK >> -

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Coleen Phillimore
On Mon, 2 Dec 2024 15:11:54 GMT, Magnus Ihse Bursie wrote: >> src/hotspot/os/linux/os_linux.cpp line 590: >> >>> 588: >>> 589: // Found the full path to the binary. It is normally of this >>> structure: >>> 590: // /lib//libjvm.so >> >> You could change to server I believe, since t

Integrated: 8339480: Build static-jdk image with a statically linked launcher

2024-12-02 Thread Magnus Ihse Bursie
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote: > As a prerequisite for Hermetic Java, we need a statically linked `java` > launcher. It should behave like the normal, dynamically linked `java` > launcher, except that all JDK native libraries should be statically, not > dynamically,

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Coleen Phillimore
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Magnus Ihse Bursie
On Tue, 26 Nov 2024 21:20:10 GMT, David Holmes wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into static-jdk-image >> - Remove LDFLAGS_STATIC_JDK >> - Ren

Re: RFR: 8344318: Enhance configure help for enabling/disabling single JVM features

2024-12-02 Thread Erik Joelsson
On Tue, 26 Nov 2024 18:08:24 GMT, Magnus Ihse Bursie wrote: >> For any `--enable-` flag autoconf generates a corresponding >> `--disable-` flag. Using `--enable-` is equivalent to >> `--enable-=yes` and using `--disable-` is equivalent to >> `--enable-=no`. It's encouraged (from autoconf) to h

Re: RFR: 8343832: Enhance test summary with number of skipped tests [v2]

2024-12-02 Thread Erik Joelsson
On Wed, 27 Nov 2024 15:40:22 GMT, Ivan Bereziuk wrote: >> The output for Jtreg v7.5 was >> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) >> with [information about skipped >> tests](https://github.com/openj

Integrated: 8344041: Re-enable external specs page

2024-12-02 Thread Hannes Wallnöfer
On Tue, 19 Nov 2024 15:45:18 GMT, Hannes Wallnöfer wrote: > Please review a change to enable the External Specifications page in API > docs. The page was disabled because of missing `@spec` tags in OpenJDK > sources. This is a straightforward undo of of #13127 / [JDK-8304689], which > means th

Re: RFR: 8342979: Start of release updates for JDK 25 [v7]

2024-12-02 Thread Joe Darcy
On Mon, 25 Nov 2024 11:40:16 GMT, Pavel Rappo wrote: >> Prepare for JDK 25. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 11 addi

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Erik Joelsson
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v3]

2024-12-02 Thread Magnus Ihse Bursie
On Fri, 29 Nov 2024 09:24:15 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linu

Re: RFR: 8306579: Consider building with /Zc:throwingNew [v2]

2024-12-02 Thread Magnus Ihse Bursie
On Mon, 18 Nov 2024 05:48:57 GMT, Julian Waters wrote: >> [JDK-8305590](https://bugs.openjdk.org/browse/JDK-8305590) removed >> `-fcheck-new` when building with gcc. It turns out Visual Studio has a >> similar option, though inverted in behavior and default. >> >> It seems like /Zc:throwingNew

Integrated: 8345218: Clean out references to windows-x86 in jib profiles

2024-12-02 Thread Magnus Ihse Bursie
On Thu, 28 Nov 2024 15:38:27 GMT, Magnus Ihse Bursie wrote: > I forgot to remove the references to windows-x86 in the JIB profiles in > [JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783). This pull request has now been integrated. Changeset: d589bafe Author:Magnus Ihse Bursie URL:

Re: RFR: 8342979: Start of release updates for JDK 25 [v8]

2024-12-02 Thread Pavel Rappo
> Prepare for JDK 25. Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Update --release 24 symbol information for JDK 24 build 26 The macOS/AArch64 build 26 was taken from https://jdk.java.net/24/ - M

Re: RFR: 8345343: Hide java.lang.classfile.components package to implementation

2024-12-02 Thread Adam Sotona
On Mon, 2 Dec 2024 23:55:00 GMT, Chen Liang wrote: > The java.lang.classfile.components package was underused and had almost no > usage feedback; as a result, it did not caught attention during the preview > process of the Class-File API, until the late adoption when Class-File API is > sure t

Re: RFR: 8342979: Start of release updates for JDK 25 [v8]

2024-12-02 Thread Iris Clark
On Mon, 2 Dec 2024 22:57:01 GMT, Pavel Rappo wrote: >> Prepare for JDK 25. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 13 commits: > > - Update --release 24 symbol information for JDK 24 build 26 > >The

RFR: 8345343: Hide java.lang.classfile.components package to implementation

2024-12-02 Thread Chen Liang
Draft for preliminary review. Writing CSR right now. - Commit messages: - 8345344: Hide java.lang.classfile.components package to implementation Changes: https://git.openjdk.org/jdk/pull/22503/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22503&range=00 Issue: https://b