The checks added by [JDK-8344093](https://bugs.openjdk.org/browse/JDK-8344093)
are apparently too broad: configuring `--with-jvm-variants=zero` says the port
is deprecated, while it is actually not. I should have checked it with
[JDK-8344093](https://bugs.openjdk.org/browse/JDK-8344093), mea cul
On Thu, 28 Nov 2024 15:38:27 GMT, Magnus Ihse Bursie wrote:
> I forgot to remove the references to windows-x86 in the JIB profiles in
> [JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783).
Marked as reviewed by jwaters (Committer).
-
PR Review: https://git.openjdk.org/jdk/p
On Wed, 27 Nov 2024 15:40:22 GMT, Ivan Bereziuk wrote:
>> The output for Jtreg v7.5 was
>> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947)
>> with [information about skipped
>> tests](https://github.com/openj
On Wed, 27 Nov 2024 08:21:52 GMT, Aleksey Shipilev wrote:
>> WIP, as the JEP is still not targeted. We can review code meanwhile.
>>
>> Additional testing:
>> - [x] Linux x86-32 build configure fails by default
>> - [x] Linux x86-32 build configures well with
>> `--enable-deprecated-ports=yes
On Wed, 13 Nov 2024 10:18:26 GMT, Aleksey Shipilev wrote:
> WIP, as the JEP is still not targeted. We can review code meanwhile.
>
> Additional testing:
> - [x] Linux x86-32 build configure fails by default
> - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes`
> - [x
On Thu, 28 Nov 2024 02:29:26 GMT, David Holmes wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update build docs
>
> doc/building.html line 396:
>
>> 394: Windows
>> 395: Windows XP is not a supported platform
On Thu, 28 Nov 2024 15:38:27 GMT, Magnus Ihse Bursie wrote:
> I forgot to remove the references to windows-x86 in the JIB profiles in
> [JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783).
LGTM
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/
I forgot to remove the references to windows-x86 in the JIB profiles in
[JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783).
-
Commit messages:
- 8345218: Clean out references to windows-x86 in jib profiles
Changes: https://git.openjdk.org/jdk/pull/22443/files
Webrev: http
On Thu, 28 Nov 2024 15:38:27 GMT, Magnus Ihse Bursie wrote:
> I forgot to remove the references to windows-x86 in the JIB profiles in
> [JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783).
Looks good.
-
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.open
On Thu, 28 Nov 2024 07:52:37 GMT, Matthias Baesken wrote:
> Hi Julian, the assembler local labels seem to work (see current commit). If
> this approach is used, we probably need a comment about this ? Btw. the
> NOINLINE is most likely okay too, this function does not need to be inlined I
> th
On Thu, 28 Nov 2024 07:56:27 GMT, Matthias Baesken wrote:
>> Support the clang toolchain when link time optimization is configured.
>> Please note that this is NOT intended to enable lto by default and NOT to
>> fix all possible clang-supporting builds or test issues .
>>
>> It works on my Linu
On Thu, 28 Nov 2024 15:38:27 GMT, Magnus Ihse Bursie wrote:
> I forgot to remove the references to windows-x86 in the JIB profiles in
> [JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783).
Marked as reviewed by shade (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull
12 matches
Mail list logo
