Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Julian Waters
On Fri, 15 Nov 2024 06:20:53 GMT, Kim Barrett wrote: >> Yes, I think it's an acceptable workaround to disable attribute-warning >> (It's one of the solutions I mentioned earlier, but I'm guessing you mean >> more aggressively). LTO is not the typical way of compiling HotSpot, so this >> should

Re: RFR: 8344056: Use markdown format for man pages [v3]

2024-11-15 Thread Christian Stein
On Fri, 15 Nov 2024 14:46:33 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344056: Use markdown format for man pages [v3]

2024-11-15 Thread Magnus Ihse Bursie
On Fri, 15 Nov 2024 15:00:39 GMT, Christian Stein wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix regexes in CheckManPageOptions > > test/langtools/jdk/javadoc/tool/CheckManPageOptions.java line 277: > >

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Julian Waters
On Fri, 15 Nov 2024 18:18:37 GMT, Magnus Ihse Bursie wrote: >> For the record, I'm seeing 3 warnings, 2 of which are for the same code. Both >> are -Walloc-size-larger-than= warnings for calls to operator new[]. >> >> In gtestMain.cpp, in init_jvm, `new JavaVMOption[num_jvm_options]` is being >>

Re: RFR: 8342979: Start of release updates for JDK 25 [v6]

2024-11-15 Thread Iris Clark
On Fri, 15 Nov 2024 11:35:40 GMT, Pavel Rappo wrote: >> Prepare for JDK 25. > > Pavel Rappo has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains nine ad

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-15 Thread Christian Stein
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-15 Thread Kim Barrett
On Thu, 14 Nov 2024 14:15:38 GMT, Matthias Baesken wrote: > > In utilities/macros.hpp, there > > should be a conditional #define to the default value (0) if the macro is not > > already defined, so that we can consistently use #if INCLUDE_LTO and > > #if !INCLUDE_LTO. > > If you want me to chang

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Kim Barrett
On Fri, 15 Nov 2024 08:08:27 GMT, Julian Waters wrote: >> As mentioned in the JBS issue, some of my problems are a result of the >> devkit I'm using not putting >> the lto-plugin in the necessary spot. So I think I'm now where @MBaesken is >> at. >> >> I worry that LTO could become the defaul

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Kim Barrett
On Fri, 15 Nov 2024 10:12:07 GMT, Kim Barrett wrote: >> I misspoke a bit earlier, I do not think LTO will become the Standard way of >> compiling HotSpot, even if all the issues with it are fixed. It simply takes >> too long, which I think is the main reason Erik mentioned why it is not used >

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v57]

2024-11-15 Thread Magnus Ihse Bursie
On Thu, 7 Nov 2024 17:25:40 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> previ

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-15 Thread Magnus Ihse Bursie
On Fri, 15 Nov 2024 01:25:43 GMT, David Holmes wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix CheckManPageOptions test >> - Remove classpath exception > >> > Now `CheckManPageOptions` finds the `.md`

Re: RFR: 8344056: Use markdown format for man pages [v4]

2024-11-15 Thread Magnus Ihse Bursie
> Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms of editing, we make changes to > the man pages in markdown and

Re: RFR: 8344056: Use markdown format for man pages [v3]

2024-11-15 Thread Magnus Ihse Bursie
> Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms of editing, we make changes to > the man pages in markdown and

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-15 Thread Magnus Ihse Bursie
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8342979: Start of release updates for JDK 25 [v6]

2024-11-15 Thread Pavel Rappo
> Prepare for JDK 25. Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision: - Update --release

Re: RFR: 8344093: Implementation of JEP 501: Deprecate the 32-bit x86 Port for Removal [v3]

2024-11-15 Thread Aleksey Shipilev
> WIP, as the JEP is still not targeted. We can review code meanwhile. > > Additional testing: > - [x] Linux x86-32 build configure fails by default > - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes` > - [x] GHA Aleksey Shipilev has updated the pull request with a

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v11]

2024-11-15 Thread Magnus Ihse Bursie
> As a prerequisite for Hermetic Java, we need a statically linked `java` > launcher. It should behave like the normal, dynamically linked `java` > launcher, except that all JDK native libraries should be statically, not > dynamically, linked. > > This patch is the first step towards this goal.

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Magnus Ihse Bursie
On Fri, 15 Nov 2024 10:37:31 GMT, Kim Barrett wrote: >> LTO seems to be less than a factor of 2 longer build times. If it makes a >> measurable difference in performance, that seems like a clear win for >> production builds. Certainly hotspot developers wouldn't want it on, but we >> will know ab

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Magnus Ihse Bursie
On Thu, 14 Nov 2024 14:15:45 GMT, Matthias Baesken wrote: >> When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on >> Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into >> this error : >> >> .. tons of free and malloc related warnings ... >> >> >>

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status [v2]

2024-11-15 Thread Kim Barrett
On Fri, 15 Nov 2024 18:19:51 GMT, Magnus Ihse Bursie wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use -DINCLUDE_LINK_TIME_OPTIMIZATION=1 in lto build > > make/hotspot/lib/JvmFeatures.gmk line 173: > >> 171: