RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Matthias Baesken
When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this error : .. tons of free and malloc related warnings ... inlined from 'pop_segment' at src/hotspot/share/utilities/stack.inline.hpp:188:

Re: RFR: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners [v3]

2024-11-13 Thread Magnus Ihse Bursie
On Wed, 13 Nov 2024 10:20:48 GMT, Aleksey Shipilev wrote: >> We use macos-14 images for macos-aarch64 runners. We use Xcode 14.3.1 there. >> Xcode 14 goes away from those runners, as per: >> https://github.com/actions/runner-images/issues/10703. Current GH runner >> docs say macos-14 image def

Re: RFR: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners [v2]

2024-11-13 Thread Aleksey Shipilev
On Mon, 11 Nov 2024 10:45:20 GMT, Aleksey Shipilev wrote: >> We use macos-14 images for macos-aarch64 runners. We use Xcode 14.3.1 there. >> Xcode 14 goes away from those runners, as per: >> https://github.com/actions/runner-images/issues/10703. Current GH runner >> docs say macos-14 image def

Integrated: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners

2024-11-13 Thread Aleksey Shipilev
On Mon, 11 Nov 2024 09:24:14 GMT, Aleksey Shipilev wrote: > We use macos-14 images for macos-aarch64 runners. We use Xcode 14.3.1 there. > Xcode 14 goes away from those runners, as per: > https://github.com/actions/runner-images/issues/10703. Current GH runner docs > say macos-14 image default

Re: RFR: 8344093: Implementation of JEP XXX: Deprecate the 32-bit x86 Port for Removal [v2]

2024-11-13 Thread Aleksey Shipilev
> WIP, as the JEP is still not targeted. We can review code meanwhile. > > Additional testing: > - [x] Linux x86-32 build configure fails by default > - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes` > - [ ] GHA Aleksey Shipilev has updated the pull request with a

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Matthias Baesken
On Wed, 13 Nov 2024 12:17:07 GMT, Matthias Baesken wrote: > When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inli

Re: RFR: 8344093: Implementation of JEP XXX: Deprecate the 32-bit x86 Port for Removal [v2]

2024-11-13 Thread Magnus Ihse Bursie
On Wed, 13 Nov 2024 15:39:42 GMT, Aleksey Shipilev wrote: >> WIP, as the JEP is still not targeted. We can review code meanwhile. >> >> Additional testing: >> - [x] Linux x86-32 build configure fails by default >> - [x] Linux x86-32 build configures well with >> `--enable-deprecated-ports=yes

Re: RFR: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners [v3]

2024-11-13 Thread Aleksey Shipilev
> We use macos-14 images for macos-aarch64 runners. We use Xcode 14.3.1 there. > Xcode 14 goes away from those runners, as per: > https://github.com/actions/runner-images/issues/10703. Current GH runner docs > say macos-14 image defaults to Xcode 15.4: > https://github.com/actions/runner-images

RFR: 8344093: Implementation of JEP XXX: Deprecate the 32-bit x86 Port for Removal

2024-11-13 Thread Aleksey Shipilev
WIP, as the JEP is still not targeted. We can review code meanwhile. Additional testing: - [x] Linux x86-32 build configure fails by default - [x] Linux x86-32 build configures well with `--enable-deprecated-ports=yes` - [ ] GHA - Commit messages: - Initial work Changes: https:/

Integrated: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port

2024-11-13 Thread Magnus Ihse Bursie
On Mon, 28 Oct 2024 18:09:41 GMT, Magnus Ihse Bursie wrote: > This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 > Port_](https://openjdk.org/jeps/479). > > This is the summary of JEP 479: >> Remove the source code and build support for the Windows 32-bit x86 port. >> This

RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Magnus Ihse Bursie
Currently, the man pages are stored as troff (a text format) in the open repo, and a content-wise identical copy is stored as markdown (another text format) in the closed repo. Since markdown is preferred to troff in terms of editing, we make changes to the man pages in markdown and then conver

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Jonathan Gibbons
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives

2024-11-13 Thread Ioi Lam
On Tue, 12 Nov 2024 23:27:27 GMT, Calvin Cheung wrote: > With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` b

Re: RFR: 8343923: GHA: Switch to Xcode 15 on MacOS AArch64 runners [v3]

2024-11-13 Thread Aleksey Shipilev
On Wed, 13 Nov 2024 10:24:24 GMT, Aleksey Shipilev wrote: >> We use macos-14 images for macos-aarch64 runners. We use Xcode 14.3.1 there. >> Xcode 14 goes away from those runners, as per: >> https://github.com/actions/runner-images/issues/10703. Current GH runner >> docs say macos-14 image def

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Matthias Baesken
On Wed, 13 Nov 2024 12:17:07 GMT, Matthias Baesken wrote: > When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inli

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Julian Waters
On Wed, 13 Nov 2024 12:17:07 GMT, Matthias Baesken wrote: > When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inli

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Julian Waters
On Wed, 13 Nov 2024 12:17:07 GMT, Matthias Baesken wrote: > When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inli

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Kevin Walls
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Christian Stein
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Jonathan Gibbons
On Wed, 13 Nov 2024 20:17:24 GMT, Kevin Walls wrote: > I think this means the one-true-master copy of a man page is now the public > .md file. All contributors can now change and improve man pages, and would be > expected to make necessary man page updates when making other changes. (Which > i

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread David Holmes
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o

Re: RFR: 8340574: Drop stackMapTable.cpp to -O1 for MacOS on XCode 16 to work around JDK-8340341

2024-11-13 Thread Simon Tooke
On Sun, 22 Sep 2024 09:46:43 GMT, Thomas Stuefe wrote: > Trivial change to drop the optimization level (for both fastdebug and > release) of stackMapTable.cpp to O1 on MacOS with Xcode 16. > > This is a workaround for https://bugs.openjdk.org/browse/JDK-8340341, which > prevents building on Ma

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Iris Clark
On Wed, 13 Nov 2024 21:27:02 GMT, David Holmes wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in terms of

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Calvin Cheung
> With this change, the compact object headers related CDS archives > (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by > default. If the user needs them, the user can specify the > `--enable-cds-archive-coh=yes` build configure option. > This change also modified the Te

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Calvin Cheung
On Wed, 13 Nov 2024 19:43:54 GMT, Ioi Lam wrote: > I think it's best to avoid modifying the test JVM. It could be used in > parallel by another jtreg process, and it could also be in a read-only > directory. > > I would suggest checking for the existence of the COH files, and skip the > test

Re: RFR: 8344128: Regression: make help broken after JDK-8340818

2024-11-13 Thread Roger Riggs
On Wed, 13 Nov 2024 22:56:47 GMT, Nizar Benalla wrote: > I was not successful in writing a test to check to return value of `make > help`, but this patch should fix the current bug. > > > % make help >/dev/null; echo $? > >

Re: RFR: 8344128: Regression: make help broken after JDK-8340818

2024-11-13 Thread David Holmes
On Wed, 13 Nov 2024 22:56:47 GMT, Nizar Benalla wrote: > I was not successful in writing a test to check to return value of `make > help`, but this patch should fix the current bug. > > > % make help >/dev/null; echo $? > >

RFR: 8344128: Regression: make help broken after JDK-8340818

2024-11-13 Thread Nizar Benalla
I was not successful in writing a test to check to return value of `make help`, but this patch should fix the current bug. % make help >/dev/null; echo $? 0 % make help OpenJDK Makefile help = Common make

Re: RFR: 8341553: Remove UseCompactObjectHeaders extra CDS archives [v2]

2024-11-13 Thread Ioi Lam
On Wed, 13 Nov 2024 23:15:47 GMT, Calvin Cheung wrote: >> With this change, the compact object headers related CDS archives >> (`classes_coh.jsa` and `classes_nocoops_coh.jsa`) will not be generated by >> default. If the user needs them, the user can specify the >> `--enable-cds-archive-coh=ye

Re: RFR: 8344056: Use markdown format for man pages

2024-11-13 Thread Christian Stein
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Julian Waters
On Thu, 14 Nov 2024 07:06:10 GMT, Kim Barrett wrote: >> When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on >> Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into >> this error : >> >> .. tons of free and malloc related warnings ... >> >> >> i

Re: RFR: 8343698: Linux x86_64 lto build gives a lot of warnings and fails lto-wrapper: fatal error: make returned 2 exit status

2024-11-13 Thread Kim Barrett
On Wed, 13 Nov 2024 12:17:07 GMT, Matthias Baesken wrote: > When trying LTO (configure flag --enable-jvm-feature-link-time-opt=yes) on > Linux x86_64, gcc 11.3.0, we run into a lot of warnings and finally into this > error : > > .. tons of free and malloc related warnings ... > > > inli