Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v55]

2024-11-06 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v50]

2024-11-06 Thread Thomas Stuefe
On Tue, 5 Nov 2024 16:43:35 GMT, Roman Kennke wrote: >> @egahlin / @mgronlun could you please review the JFR parts of this PR? One >> change is for getting the right prototype header, the other is for avoiding >> an endless loop/assert in a corner case. > >> @rkennke can you include this small

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v30]

2024-11-06 Thread Thomas Stuefe
On Wed, 6 Nov 2024 04:40:24 GMT, Julian Waters wrote: > I think you may be throwing the baby out with the bath water when it comes to > `__stdcall`. It may be that 32-bit requires `__stdcall` but I don't see > anything that states `__stdcall` is ONLY for 32-bit! stdcall and cdecl are 32-bit Wi

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v30]

2024-11-06 Thread Thomas Stuefe
On Wed, 6 Nov 2024 09:12:02 GMT, Thomas Stuefe wrote: > > I think you may be throwing the baby out with the bath water when it comes > > to `__stdcall`. It may be that 32-bit requires `__stdcall` but I don't see > > anything that states `__stdcall` is ONLY for 32-bit! > > stdcall and cdecl are

Disabling JVM features like for example jvmci or cds

2024-11-06 Thread Baesken, Matthias
Hi, I wanted to try to build a JVM on Linux x86_64 with JVMCI disabled (just to check how the JVM behaves in a test). The configure help output shows a long list how to enable those features --enable-jvm-feature-cds enable jvm feature 'cds' (enable class data sharing

Re: Disabling JVM features like for example jvmci or cds

2024-11-06 Thread Kim Barrett
On 11/6/24 6:46 AM, Baesken, Matthias wrote: Hi, I wanted to try to build a JVM on Linux x86_64 with JVMCI disabled (just to check how the JVM behaves in a test). The configure help output shows a long  list how to enable those features --enable-jvm-feature-cds enable jvm feature 'cds' (ena

RE: Disabling JVM features like for example jvmci or cds

2024-11-06 Thread Baesken, Matthias
>I think `--disable-xxx` is the more usual autoconf way. Though expecting >users to just know that doesn't seem right, so having the help text say >something about it seems like a good idea. >But the relevant help text is probably (mostly?) automatically generated by >the built-in autoconf too

Re: RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v42]

2024-11-06 Thread Severin Gehwolf
On Fri, 1 Nov 2024 18:03:16 GMT, Mandy Chung wrote: >> I expect that the jmodless tests will first build an image (say `image1`) >> using jlink `--generate-linkable-runtime` option and then verify >> `image1/bin/jlink` that links from the run-time image.I don't see >> `--generate-linkable-

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v30]

2024-11-06 Thread Magnus Ihse Bursie
On Tue, 5 Nov 2024 08:58:00 GMT, Kim Barrett wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix: jvm_md.h was included, but not jvm.h... > > src/hotspot/os/windows/os_windows.cpp line 5863: > >> 5861: r

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v31]

2024-11-06 Thread Magnus Ihse Bursie
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 > Port_](https://openjdk.org/jeps/479). > > This is the summary of JEP 479: >> Remove the source code and build support for the Windows 32-bit x86 port. >> This port was [deprecated for removal in JDK >> 21](https://openjd

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v30]

2024-11-06 Thread Magnus Ihse Bursie
On Tue, 5 Nov 2024 16:28:04 GMT, Kim Barrett wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix: jvm_md.h was included, but not jvm.h... > > src/hotspot/os/windows/os_windows.cpp line 5820: > >> 5818: } >>

Re: RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v45]

2024-11-06 Thread Magnus Ihse Bursie
On Wed, 6 Nov 2024 11:24:23 GMT, Severin Gehwolf wrote: >> Please review this patch which adds a jlink mode to the JDK which doesn't >> need the packaged modules being present. A.k.a run-time image based jlink. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >> i

Re: RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v45]

2024-11-06 Thread Severin Gehwolf
> Please review this patch which adds a jlink mode to the JDK which doesn't > need the packaged modules being present. A.k.a run-time image based jlink. > Fundamentally this patch adds an option to use `jlink` even though your JDK > install might not come with the packaged modules (directory `jm

Re: RFR: 8341097: GHA: Demote Mac x86 jobs to build only

2024-11-06 Thread Aleksey Shipilev
On Mon, 30 Sep 2024 08:36:38 GMT, Aleksey Shipilev wrote: > See the discussion in the bug. I think we can stop testing Mac x86 in GHA, > leaving only the build jobs. > > Additional testing: > - [x] GHA passes Not now, bot. I'll probably delay this until the JDK 25 fork. - PR Com

Re: RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v45]

2024-11-06 Thread Mandy Chung
On Wed, 6 Nov 2024 11:24:23 GMT, Severin Gehwolf wrote: >> Please review this patch which adds a jlink mode to the JDK which doesn't >> need the packaged modules being present. A.k.a run-time image based jlink. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >> i

Re: RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v45]

2024-11-06 Thread Mandy Chung
On Wed, 6 Nov 2024 11:24:23 GMT, Severin Gehwolf wrote: >> Please review this patch which adds a jlink mode to the JDK which doesn't >> need the packaged modules being present. A.k.a run-time image based jlink. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >> i

Re: RFR: 8311302: Implement JEP 493: Linking Run-Time Images without JMODs [v40]

2024-11-06 Thread Severin Gehwolf
On Mon, 4 Nov 2024 10:35:45 GMT, Severin Gehwolf wrote: > OK. I would prefer: > > ``` > Capabilities: > Linking from run-time image enabled > ``` > > ... as it would be more in-line with other wording of the feature. I've implemented this now and will update the JEP and the JSR accordingly

RFR: 8268895: Do not filter out man pages from build

2024-11-06 Thread Magnus Ihse Bursie
Due to historical reasons, Oracle builds of OpenJDK do not include the man pages that are present in the OpenJDK source repo. Oracle JDK builds include man pages, and most likely all other OpenJDK builds. There is no need to leave out the man pages; nor to even have a mechanism for doing so. -

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v31]

2024-11-06 Thread Kim Barrett
On Wed, 6 Nov 2024 15:21:10 GMT, Magnus Ihse Bursie wrote: >> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>>

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v30]

2024-11-06 Thread Kim Barrett
On Wed, 6 Nov 2024 15:27:16 GMT, Magnus Ihse Bursie wrote: >> src/java.base/share/native/libjava/NativeLibraries.c line 67: >> >>> 65: strcat(jniEntryName, "_"); >>> 66: strcat(jniEntryName, cname); >>> 67: } >> >> I would prefer this be directly inlined at the sole call (in