Re: RFR: 8342662: C2: Add new phase for backend-specific lowering [v2]

2024-10-27 Thread Jasmine Karthikeyan
On Thu, 24 Oct 2024 11:51:23 GMT, Quan Anh Mai wrote: >> Ah, do you mean having a method in `Node` that holds the lowering code? I >> was originally planning on doing it this way, but I think it would pose some >> problems where certain nodes' `Lower()` methods would only be overridden on >> c

Re: RFR: 8342662: C2: Add new phase for backend-specific lowering [v2]

2024-10-27 Thread Jasmine Karthikeyan
On Fri, 25 Oct 2024 23:30:52 GMT, Vladimir Ivanov wrote: >> Thanks for looking at the build changes, @magicus! I've pushed a commit that >> removes the extra newline in the makefiles and adds newlines to the ends of >> files that were missing them. >> >> Thanks for taking a look as well, @mery

Re: RFR: 8342662: C2: Add new phase for backend-specific lowering [v2]

2024-10-27 Thread Quan Anh Mai
On Mon, 28 Oct 2024 03:55:57 GMT, Jasmine Karthikeyan wrote: >> I mean we might want to run another kind of `Ideal` that will replace the >> normal `Ideal` on a node after its lowering. For example, consider this: >> >> vector v; >> u = v.withLane(0, a).withLane(1, b); >> >> This will

Re: RFR: 8342662: C2: Add new phase for backend-specific lowering [v2]

2024-10-27 Thread Quan Anh Mai
On Sun, 27 Oct 2024 01:55:41 GMT, Jatin Bhateja wrote: >> Thanks for looking at the build changes, @magicus! I've pushed a commit that >> removes the extra newline in the makefiles and adds newlines to the ends of >> files that were missing them. >> >> Thanks for taking a look as well, @meryki