On Thu, 24 Oct 2024 18:58:03 GMT, Hamlin Li wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Conditionalize platform specific parts of
>> CompressedClassPointersEncodingScheme test
>
> test/hotspot/jtreg/runtime/Co
On Thu, 24 Oct 2024 14:05:40 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 23 Oct 2024 21:54:25 GMT, Sean Mullan wrote:
>> test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java line 241:
>>
>>> 239: Properties props = System.getProperties();
>>> 240: props.setProperty(JDK_LANG_PROCESS_ALLOW_AMBIGUOUS_COMMANDS,
>>> "");
>>> 241: System.s
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>>
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Thu, 24 Oct 2024 16:11:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Wed, 23 Oct 2024 01:40:59 GMT, Jiangli Zhou wrote:
> > When trying to sort out the LDFLAGS issues, it turned out that I could not
> > run the linux launcher at all, not even when checking out older commits of
> > this PR. I am almost at a loss here; I assume that this worked when I
> > crea
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 22 Oct 2024 16:22:20 GMT, Roman Kennke wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright
>> - Avoid assert/endless-loop in JFR code
>
> @egahlin / @mgronlun could you please review the JFR
On Tue, 22 Oct 2024 14:55:47 GMT, Chen Liang wrote:
>> Context: https://mail.openjdk.org/pipermail/build-dev/2024-July/045586.html
>>
>> People were confused on a few details around fixing windows space names,
>> including:
>> 1. setshortname can report confusing error message when the director
On Thu, 24 Oct 2024 20:27:33 GMT, Alexey Ivanov wrote:
>> @seanjmullan Can you please advice on some of the following src file javadoc
>> related review comments. Do they need to be handled in this PR? Some of them
>> seem out-of-scope for jep486 PR.
>
> @honkar-jdk I'm inclined to leave it as
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 24 Oct 2024 07:11:16 GMT, David Holmes wrote:
> > the way I did it I'd have to force push
>
> That should not be the case. You can just anti-delta changes.
I did it in a really inefficient way, by checking out all files except for the
files that I wanted to stay. I could not figure out
On Mon, 21 Oct 2024 22:51:54 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Thu, 24 Oct 2024 11:32:27 GMT, Coleen Phillimore wrote:
>> Right, although you might have to wait until there is more cleanup in the
>> JDK code before they disappear completely. To clarify, most uses of
>> privileged actions are only done when a SecurityManager is set but there
>> some cas
On Thu, 24 Oct 2024 07:15:53 GMT, Alan Bateman wrote:
>> but you won't see access_controller_klass or priviledged_action_klass
>> frames, so no need to skip them? Not sure why you'd want to skip class
>> loader frames here.
>
> Right, although you might have to wait until there is more cleanup
On Thu, 24 Oct 2024 02:08:14 GMT, Jasmine Karthikeyan
wrote:
>> src/hotspot/share/opto/phaseX.cpp line 2277:
>>
>>> 2275:
>>> 2276: // Try to find an existing version of the same node
>>> 2277: Node* existing = _igvn->hash_find_insert(n);
>>
>> I think it would be easier if you have a swi
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Thu, 24 Oct 2024 17:16:54 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
This PR addresses an inconsistency in the building of static JDK libraries on
Linux when using Clang.
-
Commit messages:
- Fix inconsistent building of static JDK libraries
Changes: https://git.openjdk.org/jdk/pull/21689/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2168
On Thu, 24 Oct 2024 17:27:33 GMT, Alexey Ivanov wrote:
> > I think we have finally decided that jtreg tag will come after copyright
> > and before imports...Applicable for all modified javax_swing tests in this
> > PR...
>
> Did we agree on that?
Atleast client-dev team did..
See this initial
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Thu, 24 Oct 2024 16:47:52 GMT, Aleksandar Pejovic
wrote:
> This PR addresses an inconsistency in the building of static JDK libraries on
> Linux when using Clang.
This PR disabled partial linking. Partial linking is not a bug. It is currently
only enabled on clang/linux, but the long term
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Thu, 24 Oct 2024 22:07:52 GMT, Magnus Ihse Bursie wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
On Thu, 24 Oct 2024 17:58:55 GMT, Harshitha Onkar wrote:
> It was missed when `-Djava.security.manager=allow` was removed.
It wasn't intentional then, was it?
> Out of curiosity: does it have any impact on the performance of CI testing if
> tests are run in /othervm mode when it is not needed?
On Thu, 24 Oct 2024 16:35:44 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Tue, 22 Oct 2024 16:19:24 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 09:54:05 GMT, Martin Doerr wrote:
> As I understand the comment, it says alignment <= cache line size. But the
> implementation makes alignment >= cache line size. "hyper alignment" means
> alignment > cache line size?
Correct. since encoding range must cover the full klass
On Wed, 23 Oct 2024 18:14:50 GMT, Martin Doerr wrote:
> This code causes test errors in `CompressedClassPointersEncodingScheme.java`
> on s390 and PPC64. It forces the shift to `log_cacheline` which is 7 on PPC64
> and 9 on s390. The test passes when we remove "s > log_cacheline && " from
> th
On Thu, 24 Oct 2024 09:22:34 GMT, Thomas Stuefe wrote:
>>> This code causes test errors in
>>> `CompressedClassPointersEncodingScheme.java` on s390 and PPC64. It forces
>>> the shift to `log_cacheline` which is 7 on PPC64 and 9 on s390. The test
>>> passes when we remove "s > log_cacheline &&
On Thu, 24 Oct 2024 09:12:34 GMT, Thomas Stuefe wrote:
> But then, what exactly is the error? If it's just the test assuming that
> cache line size is log 6, then the test should be fixed for ppc, not hotspot.
that is the problem, test assumes log2 of 6 for chacheline size
-
PR Re
On Thu, 24 Oct 2024 03:33:51 GMT, Julian Waters wrote:
> the way I did it I'd have to force push
That should not be the case. You can just anti-delta changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2434475849
On Mon, 21 Oct 2024 06:12:01 GMT, Quan Anh Mai wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address some changes from code review
>
> src/hotspot/share/opto/compile.cpp line 2464:
>
>> 2462: {
>> 2463:
On Wed, 23 Oct 2024 19:15:01 GMT, Coleen Phillimore wrote:
>> This tracing skips ClassLoader frames, you'll continue to see these when
>> using Class.forName.
>
> but you won't see access_controller_klass or priviledged_action_klass frames,
> so no need to skip them? Not sure why you'd want to
41 matches
Mail list logo
