RFR: 8342704: GHA: Report truncation is broken after JDK-8341424

2024-10-21 Thread Aleksey Shipilev
When GH output is too large, we do not actually truncate it after [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424). The error log would be: Run bash ./.github/scripts/gen-test-results.sh "$GITHUB_STEP_SUMMARY" ./.github/scripts/gen-test-results.sh: line 28: report-utils.sh: No such fi

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Weijun Wang
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Kevin Walls
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Sean Mullan
On Sat, 19 Oct 2024 07:54:07 GMT, Alan Bateman wrote: > There are a couple of micro benchmarks in test/micro that fork with > `jvmArgsPrepend={"-Djava.security.manager=allow"})`, they will need to be > examined. Fixed, will be in next drop. There are a couple of other micro tests that test th

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 18:00:14 GMT, Roman Kennke wrote: >>> I've managed to reproduce the ECoreIndexOf crash locally by running with >>> -XX:+UseSerialGC -XX:+UnlockExperimentalVMOptions >>> -XX:+UseCompactObjectHeaders. The crash happens on line 773 when reading >>> past the needle. >>> >>> ``

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Phil Race
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Stefan Karlsson
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing [v2]

2024-10-21 Thread Aleksey Shipilev
On Sat, 19 Oct 2024 11:57:17 GMT, Fei Yang wrote: >> In JDK-8339548, we switched to use Debian snapshot >> (https://snapshot.debian.org/archive/debian/20240228T034848Z/) for >> bootstrap. The reason is that we don't have a stable Debian release for >> RISC-V yet and Debian "sid" (https://httpr

Integrated: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing

2024-10-21 Thread Fei Yang
On Fri, 18 Oct 2024 01:33:18 GMT, Fei Yang wrote: > In JDK-8339548, we switched to use Debian snapshot > (https://snapshot.debian.org/archive/debian/20240228T034848Z/) for bootstrap. > The reason is that we don't have a stable Debian release for RISC-V yet and > Debian "sid" (https://httpredir

Re: RFR: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing [v2]

2024-10-21 Thread Fei Yang
On Sat, 19 Oct 2024 11:57:17 GMT, Fei Yang wrote: >> In JDK-8339548, we switched to use Debian snapshot >> (https://snapshot.debian.org/archive/debian/20240228T034848Z/) for >> bootstrap. The reason is that we don't have a stable Debian release for >> RISC-V yet and Debian "sid" (https://httpr

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Daniel Fuchs
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Weijun Wang
On Fri, 18 Oct 2024 19:52:35 GMT, Sean Mullan wrote: >> I assume for the second one above you mean >> `javax.security.auth.kerberos.ServicePermission`. These classes still have a >> lot of words like "grant" and "trust". I will make some changes to the >> class descriptions of those classes,

Integrated: 8340818: Add a new jtreg test root to test the generated documentation

2024-10-21 Thread Nizar Benalla
On Mon, 30 Sep 2024 18:53:57 GMT, Nizar Benalla wrote: > Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs.

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v12]

2024-10-21 Thread Nizar Benalla
On Fri, 18 Oct 2024 12:51:46 GMT, Nizar Benalla wrote: >> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following P

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v44]

2024-10-21 Thread Thomas Stuefe
On Wed, 16 Oct 2024 15:37:59 GMT, Coleen Phillimore wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Problem-list SharedBaseAddress tests on aarch64 > > src/hotspot/share/oops/compressedKlass.cpp line 185: > >> 183

Re: RFR: 8342662: C2: Add new phase for backend-specific lowering

2024-10-21 Thread Magnus Ihse Bursie
On Mon, 21 Oct 2024 04:11:03 GMT, Jasmine Karthikeyan wrote: > Hi all, > This patch adds a new pass to consolidate lowering of complex > backend-specific code patterns, such as `MacroLogicV` and the optimization > proposed by #21244. Moving these optimizations to backend code can simplify > s

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

2024-10-21 Thread Erik Joelsson
On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan wrote: > Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Magnus Ihse Bursie
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Coleen Phillimore
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Stefan Karlsson
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

2024-10-21 Thread Magnus Ihse Bursie
On Sun, 20 Oct 2024 02:11:11 GMT, SendaoYan wrote: > Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2024-10-21 Thread Fei Gao
On Wed, 16 Oct 2024 14:00:37 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review the patch? Previously it's >> https://github.com/openjdk/jdk/pull/18605. >> This pr is based on https://github.com/openjdk/jdk/pull/20781. >> >> Thanks! >> >> ## Test >> ### tests: >> * test/jdk/jdk/incubator/v

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v7]

2024-10-21 Thread Magnus Ihse Bursie
On Fri, 18 Oct 2024 18:23:13 GMT, Johan Vos wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Don't hardcode server variant > > src/java.base/unix/native/libjli/java_md.c line 279: > >> 277:

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread SendaoYan
> Hi all, > In > [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), > the keyword is 'TEST_THREAD_FACTORY'. > > So the below test command will print error: > > make test TEST=test/jdk/java/math/BigInteger/TestValueExact.java > CONF=linux-x86_64-server-relea

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread SendaoYan
On Mon, 21 Oct 2024 12:48:55 GMT, Erik Joelsson wrote: >> SendaoYan has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - JTREG="TEST_THREAD_FACTORY=Virtual" >> - Use JTREG="JTREG_TEST_THREAD_FACTORY=Virtual" to make comment more cleaner >

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v7]

2024-10-21 Thread Magnus Ihse Bursie
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread Magnus Ihse Bursie
On Mon, 21 Oct 2024 13:12:55 GMT, SendaoYan wrote: >> Hi all, >> In >> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), >> the keyword is 'TEST_THREAD_FACTORY'. >> >> So the below test command will print error: >> >> make test TEST=test/jdk/java/math/Big

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v23]

2024-10-21 Thread Thomas Stuefe
On Fri, 20 Sep 2024 17:46:21 GMT, Coleen Phillimore wrote: >> Roman Kennke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'lilliput/JEP-450-temporary-fix-branch-2' >> into JDK-8305895-v4 >> - review feed

Integrated: 8339570: Add Tidy build support for JDK tests

2024-10-21 Thread Nizar Benalla
On Fri, 4 Oct 2024 00:17:14 GMT, Nizar Benalla wrote: > Can I get a review for this patch that adds the necessary changes for local > support of the `tidy` library. > > The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` > on Linux and MacOs systems. > > This dependen

Re: RFR: 8339570: Add Tidy build support for JDK tests [v14]

2024-10-21 Thread Nizar Benalla
On Fri, 18 Oct 2024 12:44:36 GMT, Nizar Benalla wrote: >> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Roman Kennke
On Thu, 17 Oct 2024 10:57:24 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Roman Kennke
On Mon, 21 Oct 2024 13:53:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Compact header riscv (#3) >> >> Implement compact headers on RISCV >> - >> >> Co-authored-by: hamli

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 13:53:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Compact header riscv (#3) >> >> Implement compact headers on RISCV >> - >> >> Co-authored-by: hamli

RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread Julian Waters
After 8339120, gcc began catching many different instances of unused code in the Windows specific codebase. Some of these seem to be bugs. I've taken the effort to mark out all the relevant globals and locals that trigger the unused warnings and addressed all of them by commenting out the code a

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread Julian Waters
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v2]

2024-10-21 Thread Daniel Fuchs
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 13:53:58 GMT, Roman Kennke wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Compact header riscv (#3) >> >> Implement compact headers on RISCV >> - >> >> Co-authored-by: hamli

Re: RFR: 8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY [v2]

2024-10-21 Thread Erik Joelsson
On Mon, 21 Oct 2024 13:12:55 GMT, SendaoYan wrote: >> Hi all, >> In >> [make/RunTests.gmk](https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L208), >> the keyword is 'TEST_THREAD_FACTORY'. >> >> So the below test command will print error: >> >> make test TEST=test/jdk/java/math/Big

Re: RFR: 8342704: GHA: Report truncation is broken after JDK-8341424

2024-10-21 Thread Erik Joelsson
On Mon, 21 Oct 2024 14:41:48 GMT, Aleksey Shipilev wrote: > When GH output is too large, we do not actually truncate it after > [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424). The error log > would be: > > > Run bash ./.github/scripts/gen-test-results.sh "$GITHUB_STEP_SUMMARY" > .

Re: RFR: 8342704: GHA: Report truncation is broken after JDK-8341424

2024-10-21 Thread Julian Waters
On Mon, 21 Oct 2024 14:41:48 GMT, Aleksey Shipilev wrote: > When GH output is too large, we do not actually truncate it after > [JDK-8341424](https://bugs.openjdk.org/browse/JDK-8341424). The error log > would be: > > > Run bash ./.github/scripts/gen-test-results.sh "$GITHUB_STEP_SUMMARY" > .

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread David Holmes
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote: > and whatever team is responsible for HotSpot debugging. I don't see anything hotspot related here. I think you would be better off splitting this up into distinct issues and PRs for different areas. I expect the client team in particular

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120

2024-10-21 Thread Julian Waters
On Tue, 22 Oct 2024 01:40:11 GMT, David Holmes wrote: > > and whatever team is responsible for HotSpot debugging. > > I don't see anything hotspot related here. > > I think you would be better off splitting this up into distinct issues and > PRs for different areas. I expect the client team in

Re: RFR: 8342662: C2: Add new phase for backend-specific lowering

2024-10-21 Thread Jatin Bhateja
On Mon, 21 Oct 2024 04:11:03 GMT, Jasmine Karthikeyan wrote: > Hi all, > This patch adds a new pass to consolidate lowering of complex > backend-specific code patterns, such as `MacroLogicV` and the optimization > proposed by #21244. Moving these optimizations to backend code can simplify > s

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Sandhya Viswanathan
On Mon, 21 Oct 2024 18:52:46 GMT, Volodymyr Paprotski wrote: > Thanks @rkennke able to reproduce now.. Sandhya will have a patch soon and I > will re-verify @rkennke @vpaprotsk Please find attached the patch which should fix the problem. [smallneedlefix.patch](https://github.com/user-attachmen

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Roman Kennke
On Mon, 21 Oct 2024 18:00:14 GMT, Roman Kennke wrote: >>> I've managed to reproduce the ECoreIndexOf crash locally by running with >>> -XX:+UseSerialGC -XX:+UnlockExperimentalVMOptions >>> -XX:+UseCompactObjectHeaders. The crash happens on line 773 when reading >>> past the needle. >>> >>> ``

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v46]

2024-10-21 Thread Volodymyr Paprotski
On Mon, 21 Oct 2024 20:31:28 GMT, Roman Kennke wrote: >>> @rkennke Could you post the full command you used please? And perhaps also >>> the seed that gets printed.. having trouble getting it to fail.. >>> >>> So far I added a few options and perrmitations of: >>> `./build/linux-x86_64-server-