Integrated: 8341424: GHA: Collect hs_errs from build time failures

2024-10-09 Thread Aleksey Shipilev
On Wed, 2 Oct 2024 14:45:52 GMT, Aleksey Shipilev wrote: > GHA conveniently collects hs_errs from the test job runs. However, when we > have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the VM, > we don't have these automatically collected. This is annoying when VM crashes

Re: RFR: 8341424: GHA: Collect hs_errs from build time failures [v4]

2024-10-09 Thread Aleksey Shipilev
On Wed, 9 Oct 2024 08:13:32 GMT, Aleksey Shipilev wrote: >> GHA conveniently collects hs_errs from the test job runs. However, when we >> have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the >> VM, we don't have these automatically collected. This is annoying when VM >> cr

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v12]

2024-10-09 Thread Nick Gasson
On Tue, 8 Oct 2024 15:13:06 GMT, Hamlin Li wrote: >> Hamlin Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> keep comma > > Sorry for the inconvenience. Thanks for your quick re-reviews! @Hamlin-Li are you still planning to re-submit

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-10-09 Thread Sandhya Viswanathan
On Wed, 9 Oct 2024 06:25:28 GMT, Roberto Castañeda Lozano wrote: >> Oh! We need to increase the compiler stub size for the indexOf changes. >> Strange that it blows up like this, I was sure there was a better check for >> this somewhere. I changed it like this, let me know if you agree that th

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-10-09 Thread Roberto Castañeda Lozano
On Wed, 9 Oct 2024 16:21:53 GMT, Sandhya Viswanathan wrote: >> That seems to work, thanks @rkennke! >> >> Since the [indexOf >> changes](https://github.com/openjdk/jdk/pull/20677/files#diff-ae1139bb5342494f9761e04389b090c543391bfdd7817af1625e854357c96e63) >> are complex and affect the default

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Phil Race
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v12]

2024-10-09 Thread Hamlin Li
On Tue, 8 Oct 2024 14:56:56 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize

RFR: 8335989: Implement Module Import Declarations (Second Preview)

2024-10-09 Thread Jan Lahoda
This is a current patch for module imports declarations, second preview. At least the JEP number and preview revision will need to be updated in `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is ready to receive feedback. The main changes are: - `requires transitive j

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-10-09 Thread Sandhya Viswanathan
On Wed, 9 Oct 2024 17:41:37 GMT, Roberto Castañeda Lozano wrote: >> Yes, @vpaprotsk could review the changes that we made in >> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp. > > Yes, that would be great. In the meantime, I ran a few thousand times the > randomized test `java/lang/Str

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Erik Österlund
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341806: Gcc version detection failure on Alinux3

2024-10-09 Thread SendaoYan
On Wed, 9 Oct 2024 11:52:13 GMT, SendaoYan wrote: > Hi all, > There is a gcc version detection bug in `make/autoconf/toolchain.m4`. > Before this PR, the gcc version detection shell command is: > > gcc --version 2>&1 | tr "\n" " " | sed -e 's/ *Copyright .*//' | sed -e > 's/^.* ([1-9][0-9]*.[0-

Re: RFR: 8341424: GHA: Collect hs_errs from build time failures [v3]

2024-10-09 Thread Aleksey Shipilev
On Tue, 8 Oct 2024 14:59:39 GMT, Aleksey Shipilev wrote: >> .github/scripts/gen-build-failure-report.sh line 69: >> >>> 67: ) >> $GITHUB_STEP_SUMMARY >>> 68: >>> 69: # With large hs_errs, the summary can easily exceed 1024 kB, the limit >>> set by Github >> >> This code duplication is nagging

Re: RFR: 8341424: GHA: Collect hs_errs from build time failures [v3]

2024-10-09 Thread Aleksey Shipilev
On Tue, 8 Oct 2024 13:11:14 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Gaaah > > src/hotspot/share/cds/cdsConfig.cpp line 281: > >> 279: }; >> 280: >> 281: assert(false, "

Re: RFR: 8341424: GHA: Collect hs_errs from build time failures [v4]

2024-10-09 Thread Aleksey Shipilev
> GHA conveniently collects hs_errs from the test job runs. However, when we > have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the VM, > we don't have these automatically collected. This is annoying when VM crashes > on a particular platform, and not on others. > > We can

ubsan minimal runtime option and OpenJDK

2024-10-09 Thread Baesken, Matthias
Hi, I wanted to try the "minimal runtime" option of ubsan because it might be faster and has other benefits. See https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#minimal-runtime Unfortunately it seems to be available only with clang on Linux, not (yet?) gcc, so I configured --with-ad

Re: RFR: 8341806: Gcc version detection failure on Alinux3

2024-10-09 Thread Magnus Ihse Bursie
On Wed, 9 Oct 2024 11:52:13 GMT, SendaoYan wrote: > Hi all, > There is a gcc version detection bug in `make/autoconf/toolchain.m4`. > Before this PR, the gcc version detection shell command is: > > gcc --version 2>&1 | tr "\n" " " | sed -e 's/ *Copyright .*//' | sed -e > 's/^.* ([1-9][0-9]*.[0-

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Magnus Ihse Bursie
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Stefan Karlsson
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341424: GHA: Collect hs_errs from build time failures [v4]

2024-10-09 Thread Magnus Ihse Bursie
On Wed, 9 Oct 2024 08:13:32 GMT, Aleksey Shipilev wrote: >> GHA conveniently collects hs_errs from the test job runs. However, when we >> have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the >> VM, we don't have these automatically collected. This is annoying when VM >> cr

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Stefan Karlsson
On Wed, 9 Oct 2024 12:57:36 GMT, Axel Boldt-Christmas wrote: >> This is the implementation task for `JEP 490: ZGC: Remove the >> Non-Generational Mode`. See the JEP for details. >> [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) > > Axel Boldt-Christmas has updated the pull request

Re: RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode [v2]

2024-10-09 Thread Axel Boldt-Christmas
> This is the implementation task for `JEP 490: ZGC: Remove the > Non-Generational Mode`. See the JEP for details. > [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) Axel Boldt-Christmas has updated the pull request incrementally with six additional commits since the last revision:

Re: RFR: 8341806: Gcc version detection failure on Alinux3

2024-10-09 Thread Julian Waters
On Wed, 9 Oct 2024 11:52:13 GMT, SendaoYan wrote: > Hi all, > There is a gcc version detection bug in `make/autoconf/toolchain.m4`. > Before this PR, the gcc version detection shell command is: > > gcc --version 2>&1 | tr "\n" " " | sed -e 's/ *Copyright .*//' | sed -e > 's/^.* ([1-9][0-9]*.[0-

Re: RFR: 8341424: GHA: Collect hs_errs from build time failures [v4]

2024-10-09 Thread Julian Waters
On Wed, 9 Oct 2024 08:13:32 GMT, Aleksey Shipilev wrote: >> GHA conveniently collects hs_errs from the test job runs. However, when we >> have a failure during the build, e.g. javac, CDS, jmod, jlink crashes the >> VM, we don't have these automatically collected. This is annoying when VM >> cr

RFR: 8341692: Implement JEP 490: ZGC: Remove the Non-Generational Mode

2024-10-09 Thread Axel Boldt-Christmas
This is the implementation task for `JEP 490: ZGC: Remove the Non-Generational Mode`. See the JEP for details. [JDK-8335850](https://bugs.openjdk.org/browse/JDK-8335850) - Commit messages: - Remove XCollectedHeap from HSDB - Fix typo in TestZUncommitEvent.java - Add missing probl

RFR: 8341806: Gcc version detection failure on Alinux3

2024-10-09 Thread SendaoYan
Hi all, There is a gcc version detection bug in `make/autoconf/toolchain.m4`. Before this PR, the gcc version detection shell command is: gcc --version 2>&1 | tr "\n" " " | sed -e 's/ *Copyright .*//' | sed -e 's/^.* ([1-9][0-9]*.[0-9.]*)[^0-9.].*$/\1/' And this gcc version detection command can

Re: Integrated: 8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-09 Thread Tobias Hartmann
On Thu, 10 Oct 2024 06:36:13 GMT, Christian Hagedorn wrote: > [JDK-8338884](https://bugs.openjdk.org/browse/JDK-8338884) is causing build > failures on linux-x64 in tier1 in our CI: > > [2024-10-10T01:31:30,270Z] ERROR: Build failed for target 'default > (product-bundles test-bundles static-l

Re: Integrated: 8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-09 Thread Christian Hagedorn
On Thu, 10 Oct 2024 06:36:13 GMT, Christian Hagedorn wrote: > [JDK-8338884](https://bugs.openjdk.org/browse/JDK-8338884) is causing build > failures on linux-x64 in tier1 in our CI: > > [2024-10-10T01:31:30,270Z] ERROR: Build failed for target 'default > (product-bundles test-bundles static-l

Integrated: 8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-09 Thread Christian Hagedorn
On Thu, 10 Oct 2024 06:36:13 GMT, Christian Hagedorn wrote: > [JDK-8338884](https://bugs.openjdk.org/browse/JDK-8338884) is causing build > failures on linux-x64 in tier1 in our CI: > > [2024-10-10T01:31:30,270Z] ERROR: Build failed for target 'default > (product-bundles test-bundles static-l

Integrated: 8341882: [BACKOUT] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

2024-10-09 Thread Christian Hagedorn
[JDK-8338884](https://bugs.openjdk.org/browse/JDK-8338884) is causing build failures on linux-x64 in tier1 in our CI: [2024-10-10T01:31:30,270Z] ERROR: Build failed for target 'default (product-bundles test-bundles static-libs-bundles)' in configuration 'linux-x64-debug' (exit code 2) [2024-10

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v3]

2024-10-09 Thread Nizar Benalla
> Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs. > > We also define a new make target `test-docs` meant

Re: RFR: 8340818: Add a new jtreg test root to test the generated documentation [v2]

2024-10-09 Thread Nizar Benalla
> Please review this change that adds a new test root `docs` dedicated to > testing the documentation, which has been a work in progress for a while. > Tests for links, encoding, HTML, accessibility will be later added in > following PRs. > > We also define a new make target `test-docs` meant

Re: RFR: 8335989: Implement Module Import Declarations (Second Preview)

2024-10-09 Thread Alan Bateman
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote: > This is a current patch for module imports declarations, second preview. At > least the JEP number and preview revision will need to be updated in > `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is > ready to rece

Re: RFR: 8335989: Implement Module Import Declarations (Second Preview)

2024-10-09 Thread Alan Bateman
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote: > This is a current patch for module imports declarations, second preview. At > least the JEP number and preview revision will need to be updated in > `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is > ready to rece