On Mon, 7 Oct 2024 11:00:54 GMT, Roman Kennke wrote:
>> src/hotspot/share/oops/compressedKlass.cpp line 31:
>>
>>> 29: #include "oops/compressedKlass.inline.hpp"
>>> 30: #include "runtime/globals.hpp"
>>> 31: #include "runtime/java.hpp"
>>
>> Do you remember why this was added?
>
> Looks like t
On Mon, 7 Oct 2024 14:08:49 GMT, Erik Joelsson wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This d
Hi, I came across some warnings as errors today when trying to build on Linux
with toolchain clang (clang 15 on USE Linux) :
jdk/src/jdk.jpackage/share/native/common/Log.cpp:46:28: error: unused variable
'defaultLogLevel' [-Werror,-Wunused-const-variable]
const Logger::LogLevel defa
On Fri, 4 Oct 2024 00:17:14 GMT, Nizar Benalla wrote:
> Can I get a review for this patch that adds the necessary changes for local
> support of the `tidy` library.
>
> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
> on Linux and MacOs systems.
>
> This dependen
On Mon, 7 Oct 2024 14:09:39 GMT, Erik Joelsson wrote:
>> Can I get a review for this patch that adds the necessary changes for local
>> support of the `tidy` library.
>>
>> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh`
>> on Linux and MacOs systems.
>>
>> This d
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Tue, 1 Oct 2024 19:25:39 GMT, Mikael Vidstedt wrote:
> With the JDK 23 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 24.
>
> Testing: tier1-5, GHA
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21296#pullrequest
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef api to vectorize the math operations in vector api.
>
> On machine with vec
On Fri, 4 Oct 2024 11:15:37 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 19 Sep 2024 05:36:41 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 787:
>>
>>> 785: // The gap is always equal to min-fill-size, so nothing to do.
>>> 786: return;
>>> 787: }
>>
>> Reading the comment, it is not obvious that this is co
On Fri, 27 Sep 2024 16:31:55 GMT, Yudi Zheng wrote:
>> This is my current work-in-progress code:
>> https://github.com/stefank/jdk/compare/pull/20677...stefank:jdk:lilliput_remove_prototype_header_wip_2
>>
>> I've made some large rewrites and I'm currently running it through
>> functional testi
On Mon, 30 Sep 2024 10:33:20 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vectorize
On Mon, 7 Oct 2024 09:50:16 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vectorize
On Mon, 7 Oct 2024 10:49:39 GMT, Roman Kennke wrote:
>> Did you figure out if the code above is correct w.r.t.
>> `MinObjectAlignment=16`?
>
> When MinObjectAlignment=16, then that method does nothing anyway:
>
>
> if (MinObjAlignment > 1) {
> return;
> }
>
>
>
> I think what it rea
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 7 Oct 2024 08:49:58 GMT, Stefan Karlsson wrote:
>> Style note: The added code is inserted between a comment and the code that
>> the comment refers to. It would be nice to tidy this up.
>
> Did you figure out if the code above is correct w.r.t.
> `MinObjectAlignment=16`?
When MinObject
On Mon, 7 Oct 2024 08:25:55 GMT, Stefan Karlsson wrote:
>> Roman Kennke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 76 commits:
>>
>> - Merge remote-tracking branch 'rkennke/JDK-8305895-v4' into JDK-8305895-v4
>> - Revert "D
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 7 Oct 2024 08:44:16 GMT, Stefan Karlsson wrote:
>> Roman Kennke has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 76 commits:
>>
>> - Merge remote-tracking branch 'rkennke/JDK-8305895-v4' into JDK-8305895-v4
>> - Revert "D
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 7 Oct 2024 09:50:16 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vectorize
On Tue, 1 Oct 2024 19:25:39 GMT, Mikael Vidstedt wrote:
> With the JDK 23 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 24.
>
> Testing: tier1-5, GHA
This pull request has now been integrated.
Changeset: 23f3ca25
Author:Mikael Vidstedt
URL:
https://git.o
On Tue, 1 Oct 2024 19:25:39 GMT, Mikael Vidstedt wrote:
> With the JDK 23 GA out it's time to bump the minimum boot JDK version for
> mainline/JDK 24.
>
> Testing: tier1-5, GHA
Thank you for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/21296#issuecomment-2397726097
On Fri, 4 Oct 2024 10:41:46 GMT, Roman Kennke wrote:
>> @rkennke The small loop looks to me that it will run over the end of the
>> array.
>> Say the haystack_len is 7, the index below would be 0 after the shrq
>> instruction, and the movq(XMM_TMP1, Address(haystack, index,
>> Address::times_
24 matches
Mail list logo
