> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef api to vectorize the math operations in vector api.
>
> On machine with vec
See the discussion in the bug. I think we can stop testing Mac x86 in GHA,
leaving only the build jobs.
Additional testing:
- [x] GHA passes
-
Commit messages:
- Fix
Changes: https://git.openjdk.org/jdk/pull/21257/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21257&ran
On Thu, 26 Sep 2024 13:14:04 GMT, Hamlin Li wrote:
>> Hi,
>> Can you help to review this patch?
>> Thanks!
>>
>> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
>> the sleef source (in particular the generated sleef inline headers). We use
>> sleef api to vectorize
On Mon, 30 Sep 2024 09:01:24 GMT, Ludovic Henry wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test macro
>
> src/hotspot/share/opto/vectorIntrinsics.cpp line 2044:
>
>> 2042: }
>> 2043:
>> 2044: if (addr =
On Mon, 30 Sep 2024 08:36:38 GMT, Aleksey Shipilev wrote:
> See the discussion in the bug. I think we can stop testing Mac x86 in GHA,
> leaving only the build jobs.
>
> Additional testing:
> - [x] GHA passes
This change seems premature. Various companies (Oracle, SAP, others?) are still
sup
On Thu, 12 Sep 2024 13:20:14 GMT, Emanuel Peter wrote:
> Indeed, I could re-enable all tests in:
>
> ```
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
> test/hotspot/jtreg/compiler/loopopts/su
On Mon, 30 Sep 2024 10:39:33 GMT, Kim Barrett wrote:
> This change seems premature. Various companies (Oracle, SAP, others?) are
> still supporting macos-x64 on mainline.
Maybe premature, maybe not. We always run against the runner availability in
GHA. AFAIU, MacOS 13 will EOL 3 years after re
On Fri, 27 Sep 2024 16:23:15 GMT, Roman Kennke wrote:
>> I believe the code in the patch is good enough as-is, especially if
>> `UseCompactObjectHeaders` is slated to go away. The existing `if` will
>> prevent the < 16 byte header code from being emitted, which is the desired
>> behavior - i.
