On Fri, 27 Sep 2024 02:22:58 GMT, Fei Yang wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix test macro
>
> src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c line 51:
>
>> 49: // the dynamic roun
The jtreg test build/AbsPathsInImage.java fails with OOM when using
ubsan-enabled binaries (on Linux x86_64).
Reason seems to be that the ubsan-enabled binaries are much larger than
'normal' product binaries.
(for debug binaries the test is already disabled)
Error is :
java.lang.OutOfMemoryError:
On Fri, 27 Sep 2024 07:06:44 GMT, Hamlin Li wrote:
>> src/jdk.incubator.vector/linux/native/libsleef/lib/vector_math_rvv.c line 51:
>>
>>> 49: // the dynamic rounding mode is always RNE.
>>> 50:
>>> 51: #ifdef DEBUG
>>
>> Question: Should we check for `NDEBUG` macro (A macro specified by C/C++
On Fri, 27 Sep 2024 10:05:08 GMT, Matthias Baesken wrote:
> The jtreg test build/AbsPathsInImage.java fails with OOM when using
> ubsan-enabled binaries (on Linux x86_64).
> Reason seems to be that the ubsan-enabled binaries are much larger than
> 'normal' product binaries.
> (for debug binarie
On Fri, 27 Sep 2024 08:10:35 GMT, Fei Yang wrote:
>> `NDEBUG` is only used in sleefdp.c which is the original sleef code, and we
>> don't use that file in jdk directly, in java.base module of jdk it uses
>> `DEBUG` but not use `NDEBUG`.
>> Based on above information, I think `DEBUG` is better.
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 12 Sep 2024 15:42:59 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/opto/machnode.cpp line 390:
>>
>>> 388: t = t->make_ptr();
>>> 389: }
>>> 390: if (t->isa_narrowklass() && CompressedKlassPointers::shift() == 0) {
>>
>> Does this change have any effect? `UseCompressedClassPoin
On Fri, 27 Sep 2024 08:24:50 GMT, Roman Kennke wrote:
>> @rkennke I reviewed [rkennke@
>> 097c2af](https://github.com/rkennke/jdk/commit/097c2afa04397773e514552dfb942aa889bfa2c1)
>> and the code looks good to me. I would prefer this approach instead of not
>> generating the IndexOf intrinsic.
On Thu, 26 Sep 2024 17:25:06 GMT, Scott Gibbons wrote:
>> @sviswa7 or @asgibbons WDYT about including
>> https://github.com/rkennke/jdk/commit/097c2afa04397773e514552dfb942aa889bfa2c1
>> as part of compact object headers implementation? Otherwise we would have
>> to disable indexOf intrinsic w
On Fri, 27 Sep 2024 14:44:35 GMT, Scott Gibbons wrote:
>> I like to have the functional connection: if - for whatever reason - the
>> array base offset is smaller than 16, we need to deal with that. The reason
>> for this happens to be `UseCompactObjectHeaders`, but that may not be clear
>> to
On Thu, 19 Sep 2024 14:22:51 GMT, Stefan Karlsson wrote:
>> We haven't decided whether or not we will git rid of
>> ```Klass::_prototype_header``` before intergrating this PR, or not. @stefank
>> could point you to a WIP branch, if that's helpful.
>
> This is my current work-in-progress code:
>
11 matches
Mail list logo
