Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v6]

2024-09-26 Thread Hamlin Li
On Thu, 26 Sep 2024 02:15:34 GMT, Fei Yang wrote: >> I see sleef code only set frm to RNE, but I'm not quite sure. >> Even if we can make sure current sleef only set frm to RNE, seems to me we >> can not depends on current implement, it could change. Although good news is >> we don't update sle

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roberto Castañeda Lozano
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roberto Castañeda Lozano
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roman Kennke
On Thu, 26 Sep 2024 15:59:50 GMT, Roberto Castañeda Lozano wrote: >> Ok, this is indeed relevant and helpful. This could segfault if we happen to >> read from the very first object on the heap. I can solve this by allowing to >> copy only 8 bytes onto the stack: >> https://github.com/rkennke/

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roberto Castañeda Lozano
On Thu, 26 Sep 2024 13:58:02 GMT, Roman Kennke wrote: > Does this look correct to you? Or better to do it as a follow-up? I do not feel confident enough to review this part. If you want to include https://github.com/rkennke/jdk/commit/097c2afa04397773e514552dfb942aa889bfa2c1 in this changeset,

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roman Kennke
On Thu, 26 Sep 2024 08:55:44 GMT, Roberto Castañeda Lozano wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Allow LM_MONITOR on 32-bit platforms > > src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4008: > >> 400

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v6]

2024-09-26 Thread Hamlin Li
On Thu, 26 Sep 2024 07:54:32 GMT, Hamlin Li wrote: >> Just a bit worried about the fact that manipunating CSR could be very costly >> on RISC-V. Another choice would be adding an assertion about FP rounding >> mode expecting RNE when returning back from the SLEEF routine. I also >> checked flo

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v7]

2024-09-26 Thread Hamlin Li
> Hi, > Can you help to review this patch? > Thanks! > > This patch is based on https://github.com/openjdk/jdk/pull/20781 which added > the sleef source (in particular the generated sleef inline headers). We use > sleef api to vectorize the math operations in vector api. > > On machine with vec

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v8]

2024-09-26 Thread Hamlin Li
> Hi, > Can you help to review this patch? > Thanks! > > This patch is based on https://github.com/openjdk/jdk/pull/20781 which added > the sleef source (in particular the generated sleef inline headers). We use > sleef api to vectorize the math operations in vector api. > > On machine with vec

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v27]

2024-09-26 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roman Kennke
On Thu, 26 Sep 2024 13:04:57 GMT, Roberto Castañeda Lozano wrote: >> This comes from an assert in `LibraryCallKit::inline_string_indexOfI` and I >> believe we can perhaps remove that assert and the !UCOH clause. I checked a >> couple of tests that tripped that assert, and they seem to work fin

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roberto Castañeda Lozano
On Thu, 26 Sep 2024 11:39:02 GMT, Roman Kennke wrote: >> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4008: >> >>> 4006: #ifdef COMPILER2 >>> 4007: if ((UseAVX == 2) && EnableX86ECoreOpts && >>> !UseCompactObjectHeaders) { >>> 4008: generate_string_indexof(StubRoutines::_string_index

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Roberto Castañeda Lozano
On Wed, 25 Sep 2024 12:53:17 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v26]

2024-09-26 Thread Scott Gibbons
On Thu, 26 Sep 2024 16:15:39 GMT, Roman Kennke wrote: >>> Does this look correct to you? Or better to do it as a follow-up? >> >> I do not feel confident enough to review this part. If you want to include >> https://github.com/rkennke/jdk/commit/097c2afa04397773e514552dfb942aa889bfa2c1 >> in t

Integrated: 8340552: Harden TzdbZoneRulesCompiler against missing zone names

2024-09-26 Thread Florian Weimer
On Fri, 20 Sep 2024 16:09:13 GMT, Florian Weimer wrote: > 8340552: Harden TzdbZoneRulesCompiler against missing zone names This pull request has now been integrated. Changeset: 1bc13a1c Author:Florian Weimer URL: https://git.openjdk.org/jdk/commit/1bc13a1c10a580f84f1b7686c95344ec263

Re: RFR: 8320500: [vectorapi] RISC-V: Optimize vector math operations with SLEEF [v8]

2024-09-26 Thread Fei Yang
On Thu, 26 Sep 2024 13:14:04 GMT, Hamlin Li wrote: >> Hi, >> Can you help to review this patch? >> Thanks! >> >> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added >> the sleef source (in particular the generated sleef inline headers). We use >> sleef api to vectorize