On Thu, 19 Sep 2024 08:32:38 GMT, Hamlin Li wrote:
> Hi,
> Can you help to review this patch?
> Thanks!
>
> This patch is based on https://github.com/openjdk/jdk/pull/20781 which added
> the sleef source (in particular the generated sleef inline headers). We use
> sleef api to vectorize the ma
On Thu, 19 Sep 2024 17:20:36 GMT, Roberto Castañeda Lozano
wrote:
>> AFAIK, this happens only when using compressed oops with a heap-base in r27.
>> When running with that setting, we would get addresses like r27[nklass] or
>> r27[nklass]+offset, both with scale=8. You would need large heaps,
On Thu, 19 Sep 2024 16:35:14 GMT, Hamlin Li wrote:
>> Sorry, I had to remind myself of how this works. We actually set this as a
>> separate parameter on the Setup macro: `OPTIMIZATION := HIGH`
>
> Thanks. I'm sorry too, I'm not familiar with the build system.
> What you expected could be someth
On Thu, 19 Sep 2024 05:51:00 GMT, Aleksey Shipilev wrote:
> `remove-bundles` step does not depend on `test-macos-aarch64`, which means it
> can run before macos-aarch64 tests start to run, which would fail those
> steps. This is not frequent, but will happen if macos-aarch64 runners are
> lagg
On Thu, 19 Sep 2024 05:51:00 GMT, Aleksey Shipilev wrote:
> `remove-bundles` step does not depend on `test-macos-aarch64`, which means it
> can run before macos-aarch64 tests start to run, which would fail those
> steps. This is not frequent, but will happen if macos-aarch64 runners are
> lagg
On Thu, 19 Sep 2024 12:08:46 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 20 Sep 2024 17:34:09 GMT, Coleen Phillimore wrote:
>> Yes. Some background:
>>
>> - wastage can only occur for larger Klass* alignments (aka class space arena
>> alignment property), so only for +COH (note to self, maybe assert)
>> - wastage is, by definition, not aligned to the require
On Wed, 18 Sep 2024 13:57:29 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/memory/classLoaderMetaspace.cpp line 87:
>>
>>> 85: klass_alignment_words,
>>> 86: "class arena");
>>> 87: }
>>
>> As per my comment in the header file, change the code to this:
>>
>> ```c++
>> if (cl
On Fri, 20 Sep 2024 12:31:18 GMT, Roman Kennke wrote:
>> Thanks @rkennke, I tried running test tiers 1-3 using different compressed
>> OOPs configurations but could not reach this code, unfortunately. Could you
>> provide a reproducer? The reason I am particularly interested is because I'd
>>
On Thu, 19 Sep 2024 12:08:46 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Wed, 18 Sep 2024 12:54:34 GMT, Roman Kennke wrote:
>> src/hotspot/share/oops/markWord.inline.hpp line 90:
>>
>>> 88: ShouldNotReachHere();
>>> 89: return markWord();
>>> 90: #endif
>>
>> Is the ifdef _LP64 necessary, since UseCompactObjectHeaders should always be
>> false for 32 bits?
>
On Thu, 19 Sep 2024 14:22:51 GMT, Stefan Karlsson wrote:
>> We haven't decided whether or not we will git rid of
>> ```Klass::_prototype_header``` before intergrating this PR, or not. @stefank
>> could point you to a WIP branch, if that's helpful.
>
> This is my current work-in-progress code:
>
On Fri, 20 Sep 2024 16:09:13 GMT, Florian Weimer wrote:
> 8340552: Harden TzdbZoneRulesCompiler against missing zone names
Looks good. Please update the copyright year before the push. Also, add a
"noreg-build" label to the JBS issue if you are not going to add a regression
test.
8340552: Harden TzdbZoneRulesCompiler against missing zone names
-
Commit messages:
- 8340552: Harden TzdbZoneRulesCompiler against missing zone names
Changes: https://git.openjdk.org/jdk/pull/21112/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21112&range=00
Issue: htt
15 matches
Mail list logo
