Re: RFR: 8329816: Add SLEEF version 3.6.1 [v5]

2024-09-16 Thread Ludovic Henry
On Fri, 30 Aug 2024 16:57:18 GMT, Magnus Ihse Bursie wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> sep

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v15]

2024-09-16 Thread Roberto Castañeda Lozano
On Fri, 13 Sep 2024 13:11:45 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v8]

2024-09-16 Thread Magnus Ihse Bursie
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request in

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v6]

2024-09-16 Thread Magnus Ihse Bursie
> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to > optimize vector math operations by leveraging the SLEEF library. For legal > reasons the actual contribution of the SLEEF files needs to be handled > separately. > > This is a new attempt at solving > [JDK-8329816](ht

Re: Is it possible to have the build in github's PR checks section to keep compiling files after an error?

2024-09-16 Thread Magnus Ihse Bursie
Yeah, that is probably a good idea. We could use `make -k`. The additional cost of continuing to build even in a failed build is pretty small compared to the overhead of having to resubmit the entire GHA several times. I opened https://bugs.openjdk.org/browse/JDK-8340185. /Magnus On 2024-09-

RFR: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file

2024-09-16 Thread Jaikiran Pai
Can I please get a review of this trivial change in the `LauncherCommon.gmk` file which replaces the use of the outdated `-ms` option with `-Xms`? This is a cleanup prior to the effort of deprecating the outdated `-ms` launcher option for removal. Local build on a macosx M1 passed with this cha

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v16]

2024-09-16 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (

Re: RFR: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file

2024-09-16 Thread Magnus Ihse Bursie
On Mon, 16 Sep 2024 11:31:57 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change in the `LauncherCommon.gmk` > file which replaces the use of the outdated `-ms` option with `-Xms`? > > This is a cleanup prior to the effort of deprecating the outdated `-ms` > launcher op

Tool suggestion: binsider

2024-09-16 Thread Magnus Ihse Bursie
I recently learned about "binsider", a new text-based UI tool for analyzing ELF files. It seems pretty nice. It does not really give you anything that was not already available through other means, but it does so in a way that provides better navigation and overview. I have just tested it for

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v17]

2024-09-16 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v11]

2024-09-16 Thread Roman Kennke
On Thu, 12 Sep 2024 13:13:01 GMT, Roman Kennke wrote: >>> @rkennke Can you please explain the changes in these tests: >>> >>> ``` >>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java >>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java >>> test/hot

Re: RFR: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file

2024-09-16 Thread Julian Waters
On Mon, 16 Sep 2024 11:31:57 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change in the `LauncherCommon.gmk` > file which replaces the use of the outdated `-ms` option with `-Xms`? > > This is a cleanup prior to the effort of deprecating the outdated `-ms` > launcher op

Re: RFR: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file

2024-09-16 Thread Jaikiran Pai
On Mon, 16 Sep 2024 11:31:57 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change in the `LauncherCommon.gmk` > file which replaces the use of the outdated `-ms` option with `-Xms`? > > This is a cleanup prior to the effort of deprecating the outdated `-ms` > launcher op

Integrated: 8340194: Replace usage of -ms with -Xms in LauncherCommon.gmk make file

2024-09-16 Thread Jaikiran Pai
On Mon, 16 Sep 2024 11:31:57 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change in the `LauncherCommon.gmk` > file which replaces the use of the outdated `-ms` option with `-Xms`? > > This is a cleanup prior to the effort of deprecating the outdated `-ms` > launcher op

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v37]

2024-09-16 Thread Severin Gehwolf
> Please review this patch which adds a jlink mode to the JDK which doesn't > need the packaged modules being present. A.k.a run-time image based jlink. > Fundamentally this patch adds an option to use `jlink` even though your JDK > install might not come with the packaged modules (directory `jm

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v17]

2024-09-16 Thread Axel Boldt-Christmas
On Mon, 16 Sep 2024 13:28:00 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8329816: Add SLEEF version 3.6.1 [v6]

2024-09-16 Thread Mikael Vidstedt
On Mon, 16 Sep 2024 10:30:46 GMT, Magnus Ihse Bursie wrote: >> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to >> optimize vector math operations by leveraging the SLEEF library. For legal >> reasons the actual contribution of the SLEEF files needs to be handled >> sep

Re: RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]

2024-09-16 Thread Stephen Colebourne
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote: >> This is a follow on fix to >> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out >> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone." >> Same fix, i.e, replacing `startsWith()` with `regionM

Re: RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]

2024-09-16 Thread Naoto Sato
On Mon, 16 Sep 2024 18:57:42 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> tz files aligned with the default TzdbZoneRulesProvider list > > make/jdk/src/classes/build/tools/tzdb/TzdbZoneRul

Re: RFR: 8339803: Acknowledge case insensitive unambiguous keywords in tzdata files [v2]

2024-09-16 Thread Stephen Colebourne
On Mon, 16 Sep 2024 19:30:56 GMT, Naoto Sato wrote: >> make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesProvider.java line 308: >> >>> 306: if (off < tokens.length) { >>> 307: String dayRule = tokens[off++]; >>> 308: if (dayRule.regionMatches(true, 0

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v8]

2024-09-16 Thread Daniel Jeliński
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request in