On Mon, 9 Sep 2024 10:16:24 GMT, Thomas Schatzl wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/gc/shared/gcForwarding.hpp line 41:
>
>> 39: * bits (to indicat
On Mon, 9 Sep 2024 10:21:54 GMT, Thomas Schatzl wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bit counts in GCForwarding
>
> src/hotspot/share/gc/shared/collectedHeap.cpp line 232:
>
>> 230: }
>> 231:
>>
On Mon, 9 Sep 2024 14:58:07 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/oops/oop.hpp line 134:
>>
>>> 132: inline Klass* forward_safe_klass(markWord m) const;
>>> 133: inline size_t forward_safe_size();
>>> 134: inline void forward_safe_init_mark();
>>
>> Given the comment th
On Mon, 9 Sep 2024 15:01:10 GMT, Thomas Schatzl wrote:
>> Just to be clear, the second part of the quoted sentence is important:
>>> could be any value *that is not a valid field offset*
>
>> could be any value that is not a valid field offset
>
> I understand that that "random value" needs
On Mon, 9 Sep 2024 12:12:23 GMT, Thomas Schatzl wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/objArrayKlass.inli
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 14:08:53 GMT, Roman Kennke wrote:
>> Yes, I'm interested in it. Thanks for raising the discussion. :)
>
> If anybody is doing it, please send me a patch, or we can do it as a
> follow-up PR.
Thanks. I'll send it to you if I finish it in time, otherwise I will do it in a
sepa
On Tue, 10 Sep 2024 08:51:56 GMT, David Holmes wrote:
> This seems trivially fine to me. The JEP isn't really relevant for this C
> code as we have C99 as a minimum for a while now.
>
> Thanks
We actually have C11 as a minimum, C99 for Unix and C89 for Windows was our old
standard, but that h
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Tue, 10 Sep 2024 08:37:43 GMT, Roman Kennke wrote:
>>> could be any value that is not a valid field offset
>>
>> I understand that that "random value" needs to satisfy this condition.
>
> With compact headers, this value should only be used in C2, and not really as
> an actual offset. An
On Tue, 10 Sep 2024 08:41:16 GMT, Roman Kennke wrote:
>> src/hotspot/share/oops/objArrayKlass.inline.hpp line 74:
>>
>>> 72: void ObjArrayKlass::oop_oop_iterate(oop obj, OopClosureType* closure) {
>>> 73: // In this assert, we cannot safely access the Klass* with compact
>>> headers.
>>> 74:
On Tue, 10 Sep 2024 07:53:23 GMT, Roman Kennke wrote:
>> src/hotspot/share/gc/shared/collectedHeap.cpp line 232:
>>
>>> 230: }
>>> 231:
>>> 232: // With compact headers, we can't safely access the class, due
>>
>> Suggestion:
>>
>> // With compact headers, we can't safely access the kla
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request inc
On Mon, 9 Sep 2024 15:49:57 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/compressedKlass
On Mon, 9 Sep 2024 15:50:50 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/compressedKlass
On Tue, 10 Sep 2024 12:03:59 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/oops/compressedKlass.cpp line 214:
>>
>>> 212: ss.print("Class space size (%zu) exceeds the maximum possible size
>>> (%zu)",
>>> 213: len, max_encoding_range_size());
>>> 214: vm_exit_during_initi
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 9 Sep 2024 15:59:43 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with six additional
>> commits since the last revision:
>>
>> - More touch-ups, fix Shenandoah oop iterator
>> - Remove asserts in XArrayKlass::oop_oop_iterate()
>> - Various
On Mon, 9 Sep 2024 16:01:10 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/compressedKlass.hpp line 43:
>>
>>> 41:
>>> 42: // Tiny-class-pointer mode
>>> 43: static int _tiny_cp; // -1, 0=true, 1=false
>>
>> Suggestion:
>>
>> static int _tiny_cp; // -1 = uninitialized, 0 = true
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Tue, 10 Sep 2024 09:56:26 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337143: Remove loading libnet from Inet6AddressImpl; delete commented out
>> #include in Windows IOUtil.c
>
>
On Wed, 21 Aug 2024 22:14:40 GMT, Magnus Ihse Bursie wrote:
>> As a preparation for Hermetic Java, we need to have a way to look up during
>> runtime if we are using a statically linked library or not.
>>
>> This change will be the first step needed towards compiling the object files
>> only o
On Tue, 10 Sep 2024 13:30:05 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 71:
>>
>>> 69: -framework Foundation \
>>> 70: -framework SystemConfiguration, \
>>> 71: LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib
>>> versio
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Mon, 9 Sep 2024 17:40:03 GMT, Coleen Phillimore wrote:
>> Roman Kennke has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Try to avoid lea in loadNklass (aarch64)
>> - Fix release build error
>
> src/hotspot/share/oops/compressedKlass
This is a follow on fix to
[JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out that
TZ data files allow abbreviation of keywords, such as "ZO" for "Zone." Same
fix, i.e, replacing `startsWith()` with `regionMatches()` was applied.
-
Commit messages:
- initial
On Tue, 10 Sep 2024 11:06:28 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8337143: Remove loading libnet from Inet6AddressImpl; delete commented out
>> #include in Windows IOUtil.c
>
>
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The pull request
On Tue, 10 Sep 2024 15:15:26 GMT, Daniel Jeliński wrote:
>> I believe this question has already been answered
>> [here](https://github.com/openjdk/jdk/pull/20317/files#r1707599113).
>
> well I'm not satisfied with the answers :) I removed mswsock.lib from libnio
> dependencies
> [here](https:/
On Tue, 10 Sep 2024 13:51:55 GMT, Josef Eisl wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Also update build to link properly
>
> src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 135:
>
>> 13
On Tue, 10 Sep 2024 19:45:01 GMT, Naoto Sato wrote:
> This is a follow on fix to
> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
> Same fix, i.e, replacing `startsWith()` with `regionMatch
> This is a follow on fix to
> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
> Same fix, i.e, replacing `startsWith()` with `regionMatches()` was applied.
Naoto Sato has updated the pull re
On Tue, 10 Sep 2024 22:17:51 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverte
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Tue, 10 Sep 2024 22:39:38 GMT, Naoto Sato wrote:
>> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1375:
>>
>>> 1373: Files.walk(Path.of(tzDataDir), 1,
>>> FileVisitOption.FOLLOW_LINKS)
>>> 1374: .filter(p -> p.toFile().isFile())
>>> 1375:
On Tue, 10 Sep 2024 22:53:15 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> Looks good to me
Thanks, @justin-curtis-lu. @coffeys, woul
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Tue, 10 Sep 2024 21:42:08 GMT, Magnus Ihse Bursie wrote:
>> well I'm not satisfied with the answers :) I removed mswsock.lib from libnio
>> dependencies
>> [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89)
>> and the buil
40 matches
Mail list logo
