RE: [External] : RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-12 Thread Baesken, Matthias
Hi Erik, the '--release N-1' sounds like a good idea ; where do we have to set it ? Best regards, Matthias >To me that sounds like GHA are miss-configured for the update releases. To >work around this, perhaps we should set an explicit '--release N-1' argument >when building source intende

Re: RFR: 8338108: Give better error message in configure if a full XCode is missing

2024-08-12 Thread Aleksey Shipilev
On Fri, 9 Aug 2024 10:27:25 GMT, Magnus Ihse Bursie wrote: > The XCode command lines tools is almost, but not quite, enough to build the > JDK. We still need the metal and metallib tools. The error message given by > configure should be improved to indicate if this is the problem with the > us

Re: [External] : RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-12 Thread Erik Joelsson
There is a variable BOOT_JDK_SOURCETARGET exported from configure and picked up in JavaCompilation.gmk. We should probably change the name of the variable as well to avoid confusion. /Erik On 8/12/24 12:08 AM, Baesken, Matthias wrote: Hi Erik, the '--release N-1'   sounds like a good idea ;

RE: [External] : RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-12 Thread Baesken, Matthias
You mean instead of BOOT_JDK_SOURCETARGET use BOOT_JDK_RELEASETARGET (and set '--release N-1' there) ? Best regards, Matthias From: Erik Joelsson Sent: Monday, 12 August 2024 14:30 To: Baesken, Matthias ; Magnus Ihse Bursie ; build-dev@openjdk.org Subject: Re: [External] : RE: jdk21

Re: [External] : RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-12 Thread Erik Joelsson
Something like that yes. Maybe just BOOT_JDK_RELEASE, or possibly BOOT_JDK_RELEASE_FLAG? /Erik On 8/12/24 5:56 AM, Baesken, Matthias wrote: You mean instead of BOOT_JDK_SOURCETARGET   use BOOT_JDK_RELEASETARGET   (and set '--release N-1'  there)  ? Best regards, Matthias *From:*Erik Joels

RE: [External] : RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-12 Thread Baesken, Matthias
I created https://bugs.openjdk.org/browse/JDK-8338205 8338205: replace BOOT_JDK_SOURCETARGET Best regards, Matthias >Something like that yes. Maybe just BOOT_JDK_RELEASE, or possibly >BOOT_JDK_RELEASE_FLAG?

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v33]

2024-08-12 Thread Severin Gehwolf
On Mon, 24 Jun 2024 14:33:51 GMT, Severin Gehwolf wrote: >> Please review this patch which adds a jlink mode to the JDK which doesn't >> need the packaged modules being present. A.k.a run-time image based jlink. >> Fundamentally this patch adds an option to use `jlink` even though your JDK >>

RE: [External] : RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-12 Thread Baesken, Matthias
Unfortunately using --release is not working in our build. We run very soon into this error : error: exporting a package from system module java.base is not allowed with --release Best regards, Matthias >I created > >https://bugs.openjdk.org/browse/JDK-8338205 >8338205: replace BOOT_JDK_SOU

Re: Need CCATS for OpenJDK 8 (ECCN 5D992.c)

2024-08-12 Thread tim . bell
Hello OpenJDK can't provide export control certification information for third parties. Contact the vendor providing your JDK 8 runtime for this information. Best regards- Tim Bell OpenJDK.org infrastructure team On 8/12/24 13:34, Hemantkumar Prakashbhai Makhijani wrote: Hello Jdk8u, build

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

2024-08-12 Thread Daniel Fuchs
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request inc

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

2024-08-12 Thread Magnus Ihse Bursie
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request inc

Integrated: 8338108: Give better error message in configure if a full XCode is missing

2024-08-12 Thread Magnus Ihse Bursie
On Fri, 9 Aug 2024 10:27:25 GMT, Magnus Ihse Bursie wrote: > The XCode command lines tools is almost, but not quite, enough to build the > JDK. We still need the metal and metallib tools. The error message given by > configure should be improved to indicate if this is the problem with the > us

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

2024-08-12 Thread Alan Bateman
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request inc

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

2024-08-12 Thread Brian Burkhalter
On Mon, 12 Aug 2024 15:46:13 GMT, Alan Bateman wrote: > please do not integrate this change until I get time Sure, of course I will not. Thanks to @magicus and @dfuch for helping to make it better. - PR Comment: https://git.openjdk.org/jdk/pull/20317#issuecomment-2284529067

Re: RFR: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

2024-08-12 Thread Magnus Ihse Bursie
On Mon, 12 Aug 2024 05:25:49 GMT, Kim Barrett wrote: > Please review this change to remove -Wzero-as-null-pointer-constant warnings > produced by the gtest framework when such warnings are enabled. > > Warnings from the 3rd party GoogleTest are suppressed by disabling that > warning when compili

Re: RFR: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

2024-08-12 Thread David Holmes
On Mon, 12 Aug 2024 05:25:49 GMT, Kim Barrett wrote: > Please review this change to remove -Wzero-as-null-pointer-constant warnings > produced by the gtest framework when such warnings are enabled. > > Warnings from the 3rd party GoogleTest are suppressed by disabling that > warning when compili

Re: RFR: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

2024-08-12 Thread Julian Waters
On Mon, 12 Aug 2024 05:25:49 GMT, Kim Barrett wrote: > Please review this change to remove -Wzero-as-null-pointer-constant warnings > produced by the gtest framework when such warnings are enabled. > > Warnings from the 3rd party GoogleTest are suppressed by disabling that > warning when compili

Re: RFR: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

2024-08-12 Thread Kim Barrett
On Mon, 12 Aug 2024 20:38:43 GMT, Magnus Ihse Bursie wrote: >> Please review this change to remove -Wzero-as-null-pointer-constant warnings >> produced by the gtest framework when such warnings are enabled. >> >> Warnings from the 3rd party GoogleTest are suppressed by disabling that >> warning

Integrated: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

2024-08-12 Thread Kim Barrett
On Mon, 12 Aug 2024 05:25:49 GMT, Kim Barrett wrote: > Please review this change to remove -Wzero-as-null-pointer-constant warnings > produced by the gtest framework when such warnings are enabled. > > Warnings from the 3rd party GoogleTest are suppressed by disabling that > warning when compili