On Thu, 8 Aug 2024 21:23:58 GMT, Brian Burkhalter wrote:
>> Thanks for the suggestions. I will look into it.
>
> Without loading libnet in Inet6AddressImpl, the test
> java/net/InetAddress/NullCharInHostnameDriver.java fails with
> UnsatisfiedLinkError:
>
> java.lang.UnsatisfiedLinkError: 'jav
On Thu, 8 Aug 2024 16:29:18 GMT, Brian Burkhalter wrote:
>> I will check.
>
> `pthread` is still needed:
>
> open/src/java.base/unix/native/libjava/nio/ch/NativeThread.c:83: error:
> undefined reference to 'pthread_kill'
Ok then. Thank you for your thorough checking!
-
PR Review
The XCode command lines tools is almost, but not quite, enough to build the
JDK. We still need the metal and metallib tools. The error message given by
configure should be improved to indicate if this is the problem with the user's
environment.
-
Commit messages:
- 8338108: Give b
> This patch enables BTI branch protection for runtime part on Linux/aarch64
> platform.
>
> Motivation
>
> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
> packages can gain additional hardening by compiling with the GCC/Clang flag
> `-mbranch-protection=flag`. Se
On Wed, 7 Aug 2024 10:40:09 GMT, Fei Gao wrote:
> This patch enables BTI branch protection for runtime part on Linux/aarch64
> platform.
>
> Motivation
>
> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
> packages can gain additional hardening by compiling with th
On Fri, 9 Aug 2024 10:27:25 GMT, Magnus Ihse Bursie wrote:
> The XCode command lines tools is almost, but not quite, enough to build the
> JDK. We still need the metal and metallib tools. The error message given by
> configure should be improved to indicate if this is the problem with the
> us
On Wed, 7 Aug 2024 17:27:00 GMT, Andrew Haley wrote:
> Can you explain why we want to support PAC without BTI? Would anyone use such
> a config?
Thanks for reviewing @theRealAph .
Sorry, I don't quite understand your question. Do you mean why we currently
only support PAC? PAC is mandatory f
On Fri, 9 Aug 2024 13:37:54 GMT, Fei Gao wrote:
>> This patch enables BTI branch protection for runtime part on Linux/aarch64
>> platform.
>>
>> Motivation
>>
>> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
>> packages can gain additional hardening by compiling
On Fri, 9 Aug 2024 09:40:59 GMT, Magnus Ihse Bursie wrote:
>> `pthread` is still needed:
>>
>> open/src/java.base/unix/native/libjava/nio/ch/NativeThread.c:83: error:
>> undefined reference to 'pthread_kill'
>
> Ok then. Thank you for your thorough checking!
Thank you for suggesting it!
-
On Fri, 9 Aug 2024 09:05:49 GMT, Daniel Fuchs wrote:
>> Without loading libnet in Inet6AddressImpl, the test
>> java/net/InetAddress/NullCharInHostnameDriver.java fails with
>> UnsatisfiedLinkError:
>>
>> java.lang.UnsatisfiedLinkError: 'java.net.InetAddress[]
>> java.net.Inet6AddressImpl.loo
On Fri, 9 Aug 2024 15:09:08 GMT, Brian Burkhalter wrote:
>> OK, this test uses a private API to create an instance of Inet6AddressImpl;
>> This explain why in this test Inet6AddressImpl gets loaded before
>> InetAddress.
>>
>> var impl = new Inet6AddressImpl();
>>
>> It should nev
On Fri, 9 Aug 2024 15:47:07 GMT, Daniel Fuchs wrote:
>> Loading "net" was removed from IOUtil so I am thinking that IOUtil must have
>> been initialized somewhere before constructing Inet6AddressImpl, but I've
>> not identified where just yet.
>
> I see. Inet6AddressImpl and Inet4AddressImpl ar
On Thu, 27 Jun 2024 22:03:37 GMT, Mikael Vidstedt wrote:
>> [JDK-8312425](https://bugs.openjdk.org/browse/JDK-8312425) is looking to
>> optimize vector math operations by leveraging the SLEEF library. For legal
>> reasons the actual contribution of the SLEEF files needs to be handled
>> separa
Hello Brian,
(Unfortunately) only members of the respective groups are able to edit
group specific wiki pages, so in this case you need someone in the build
group to handle it for you. Perhaps if you are taking ownership of a
port, you would want to volunteer someone to join the build group an
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
On Fri, 9 Aug 2024 15:58:50 GMT, Brian Burkhalter wrote:
>> I see. Inet6AddressImpl and Inet4AddressImpl are symetric classes
>> implementing InetAddressImpl. Both will make native calls to the "net"
>> library - so both require the library to be loaded.
>>
>> In the JDK, these two classes are
On Thu, 8 Aug 2024 14:33:15 GMT, Brian Burkhalter wrote:
>> src/java.base/windows/native/libjava/IOUtil.c line 37:
>>
>>> 35: #include "nio.h"
>>> 36: #include "nio_util.h"
>>> 37: /* #include "net_util.h" */
>>
>> Is this change intended or is this a left over from some experimentation?
>
> It
On Tue, 16 Jul 2024 20:50:32 GMT, Lutz Schmidt wrote:
> On MacOS, files may have extended attributes attached. These attributes are
> copied together with the files. To prevent issues during further processing,
> the extended attributes of the copies must be removed. This action was
> implemen
To me that sounds like GHA are miss-configured for the update releases.
To work around this, perhaps we should set an explicit '--release N-1'
argument when building source intended to run on the bootjdk. It looks
like we currently set '-source N-1 -target N-1' but that isn't enough as
it won't
Hi Erik,
Thanks for reaching out. Matthias Baesken helped us make the changes earlier
this week.
Brian Stafford
Microsoft
On Fri, 9 Aug 2024 10:27:25 GMT, Magnus Ihse Bursie wrote:
> The XCode command lines tools is almost, but not quite, enough to build the
> JDK. We still need the metal and metallib tools. The error message given by
> configure should be improved to indicate if this is the problem with the
> us
On Fri, 9 Aug 2024 13:37:54 GMT, Fei Gao wrote:
>> This patch enables BTI branch protection for runtime part on Linux/aarch64
>> platform.
>>
>> Motivation
>>
>> 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level
>> packages can gain additional hardening by compiling
On Fri, 26 Jul 2024 21:34:07 GMT, Brian Burkhalter wrote:
> > Also think to work through some naming on IOUtil vs. NIOUtil as it won't be
> > obvious to maintainers which class to use.
>
> Maybe `NIOUtil` should be `NetUtil` as its methods appear to be invoked only
> by classes involved in net
23 matches
Mail list logo
