On Wed, 7 Aug 2024 15:59:14 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request wit
On 07. 08. 24 14:02, Zdeněk Žamberský wrote:
I think to have jdk8 build work out of box, it is better to use older
OSes.
Like rhel/centos <= 8. You can use VM or container.
I personally usually use rhel-8 VM, if I want to build jdk8 locally.
Others distros, which should work:
Ubuntu <= 20.04
de
On Mon, 29 Jul 2024 14:55:07 GMT, Alexander Zvegintsev
wrote:
> GTK2 support for Swing/AWT was deprecated for removal in JDK 21.
>
> It's being removed because no platform that supports the JDK needs it.
>
> Manual and automated testing is green.
This pull request has now been integrated.
C
On Wed, 7 Aug 2024 18:13:25 GMT, Brian Burkhalter wrote:
>> `CoreServices` is still necessary ([Uniform Type
>> Identifier](https://developer.apple.com/documentation/uniformtypeidentifiers)s).
>
> The Windows libs are also still required for `TransmitFile` and
> `WSAGetLastError`:
>
> - ```msw
On Wed, 7 Aug 2024 20:35:05 GMT, Jiangli Zhou wrote:
>> Please review this PR that strips the `.llvm_addrsig` section from JDK and
>> hotspot `.a` static libraries when building with clang. Please see
>> https://bugs.openjdk.org/browse/JDK-8336849 description for details.
>
> Jiangli Zhou has u
On Wed, 7 Aug 2024 21:47:19 GMT, Chen Liang wrote:
>> Hm, it feels buggy that it should complain about random entries in the PATH;
>> it should only be an issue if we try to FIXUP a path. I need to look into
>> that.
>
> Can I leave this part as-is?
Yes, leave it in this patch to the documenta
On Thu, 8 Aug 2024 12:26:46 GMT, Magnus Ihse Bursie wrote:
>> Can I leave this part as-is?
>
> Yes, leave it in this patch to the documentation. If I address the core issue
> in configure, I'll update the docs as well.
For reference, I filed this: https://bugs.openjdk.org/browse/JDK-8338059
--
On Thu, 8 Aug 2024 09:11:31 GMT, Daniel Fuchs wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> comm
On Thu, 8 Aug 2024 12:18:04 GMT, Magnus Ihse Bursie wrote:
>> The Windows libs are also still required for `TransmitFile` and
>> `WSAGetLastError`:
>>
>> - ```mswsock.lib: FileDispatcherImpl.obj : error LNK2019: unresolved
>> external symbol TransmitFile```
>> - ```ws2_32.lib: FileDispatcherIm
On Thu, 8 Aug 2024 14:32:25 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/net/Inet6AddressImpl.java line 154:
>>
>>> 152: static {
>>> 153: jdk.internal.loader.BootLoader.loadLibrary("net");
>>> 154: }
>>
>> I am curious about this change - wouldn't it be need
On Thu, 8 Aug 2024 14:31:09 GMT, Brian Burkhalter wrote:
>> And pthread?
>
> I will check.
`pthread` is still needed:
open/src/java.base/unix/native/libjava/nio/ch/NativeThread.c:83: error:
undefined reference to 'pthread_kill'
-
PR Review Comment: https://git.openjdk.org/jdk/pul
On Thu, 8 Aug 2024 15:16:14 GMT, Daniel Fuchs wrote:
>> I have not seen any failures in CI testing. Is there a specific test that
>> would reveal whether this is a problem?
>
> It may be because we have no IPv4 only machine in the CI? It seems strange
> that IPv6 is treated differently than IPv
On Thu, 8 Aug 2024 16:09:55 GMT, Brian Burkhalter wrote:
>> It may be because we have no IPv4 only machine in the CI? It seems strange
>> that IPv6 is treated differently than IPv4 in that respect.
>
> How would you suggest testing this?
I don't know - you added that code to Inet6AddressImpl -
On Thu, 8 Aug 2024 16:18:28 GMT, Daniel Fuchs wrote:
>> How would you suggest testing this?
>
> I don't know - you added that code to Inet6AddressImpl - so presumably a test
> was failing without that code?
> Which test was that? It wasn't obvious to me that adding code to load the
> "net" libr
On Sat, 20 Jul 2024 00:20:19 GMT, Jiangli Zhou wrote:
> Please review this PR that strips the `.llvm_addrsig` section from JDK and
> hotspot `.a` static libraries when building with clang. Please see
> https://bugs.openjdk.org/browse/JDK-8336849 description for details.
This pull request has n
On Thu, 8 Aug 2024 16:21:30 GMT, Brian Burkhalter wrote:
>> I don't know - you added that code to Inet6AddressImpl - so presumably a
>> test was failing without that code?
>> Which test was that? It wasn't obvious to me that adding code to load the
>> "net" library would be required here.
>
> I
On Thu, 8 Aug 2024 16:39:33 GMT, Daniel Fuchs wrote:
>> I'll have to investigate.
>
> Possibly - if you made isIPv6Supported() in InetAddress.c return false, you
> might be able to see the issue in the same test that you observed failing
> without your change.
>
> InetAddress has a static blo
On Thu, 8 Aug 2024 16:48:24 GMT, Brian Burkhalter wrote:
>> Possibly - if you made isIPv6Supported() in InetAddress.c return false, you
>> might be able to see the issue in the same test that you observed failing
>> without your change.
>>
>> InetAddress has a static block that will load the
18 matches
Mail list logo
