RFR: 8337536: AArch64: Enable BTI branch protection for runtime part

2024-08-07 Thread Fei Gao
This patch enables BTI branch protection for runtime part on Linux/aarch64 platform. Motivation 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level packages can gain additional hardening by compiling with the GCC/Clang flag `-mbranch-protection=flag`. See [1]. 2. In JD

Re: jdk8u: -Wno-regsiter to support newer compilers

2024-08-07 Thread Stewart X Addison
Hi Elazar, > How is adoptium building it? Does it use specific compiler? Yes - Adoptium uses our own build of gcc 7.5.0 to build Temurin's jdk8u on Linux. If you wish to use the same environment as us, the simplest way is to pull the `adoptopenjdk/centos7_build_image` and use that which will be a

RE: jdk21u-dev build issue : 8326332: Unclosed inline tags cause misalignment in summary tables

2024-08-07 Thread Baesken, Matthias
Hi Erik, thanks for the clarification. Unfortunately we do not see this in GHA , so backports look nice and ‘green’ there . And some people with strict version requirements in the company most likely have a problem with an old / unpatched JDK20 . Best regards, Matthias From: Erik Joelss

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files)

2024-08-07 Thread Magnus Ihse Bursie
On Sat, 20 Jul 2024 00:20:19 GMT, Jiangli Zhou wrote: > Please review this PR that strips the `.llvm_addrsig` section from JDK and > hotspot `.a` static libraries when building with clang. Please see > https://bugs.openjdk.org/browse/JDK-8336849 description for details. Thank you Jiangli for t

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files)

2024-08-07 Thread Magnus Ihse Bursie
On Sat, 20 Jul 2024 00:20:19 GMT, Jiangli Zhou wrote: > Please review this PR that strips the `.llvm_addrsig` section from JDK and > hotspot `.a` static libraries when building with clang. Please see > https://bugs.openjdk.org/browse/JDK-8336849 description for details. make/common/native/Link

Re: RFR: 8337536: AArch64: Enable BTI branch protection for runtime part

2024-08-07 Thread Magnus Ihse Bursie
On Wed, 7 Aug 2024 10:40:09 GMT, Fei Gao wrote: > This patch enables BTI branch protection for runtime part on Linux/aarch64 > platform. > > Motivation > > 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level > packages can gain additional hardening by compiling with th

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v3]

2024-08-07 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

2024-08-07 Thread Brian Burkhalter
On Fri, 26 Jul 2024 19:40:24 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request in

Re: RFR: 8337536: AArch64: Enable BTI branch protection for runtime part

2024-08-07 Thread Magnus Ihse Bursie
On Wed, 7 Aug 2024 10:40:09 GMT, Fei Gao wrote: > This patch enables BTI branch protection for runtime part on Linux/aarch64 > platform. > > Motivation > > 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level > packages can gain additional hardening by compiling with th

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-07 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-07 Thread Magnus Ihse Bursie
On Wed, 7 Aug 2024 15:56:06 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request wit

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

2024-08-07 Thread Brian Burkhalter
On Mon, 5 Aug 2024 15:37:46 GMT, Brian Burkhalter wrote: >> make/modules/java.base/lib/CoreLibraries.gmk line 57: >> >>> 55: OPTIMIZATION := HIGH, \ >>> 56: EXTRA_HEADER_DIRS := \ >>> 57: libnio/ch, \ >> >> This will introduce a source code dependency from libjava to libnio. It

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-07 Thread Brian Burkhalter
On Wed, 7 Aug 2024 15:56:06 GMT, Magnus Ihse Bursie wrote: >> Brian Burkhalter has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-07 Thread Brian Burkhalter
On Wed, 7 Aug 2024 16:00:26 GMT, Brian Burkhalter wrote: >> make/modules/java.base/lib/CoreLibraries.gmk line 71: >> >>> 69: -framework Foundation \ >>> 70: -framework SystemConfiguration, \ >>> 71: LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib >>> version.l

Re: RFR: 8337536: AArch64: Enable BTI branch protection for runtime part

2024-08-07 Thread Andrew Haley
On Wed, 7 Aug 2024 10:40:09 GMT, Fei Gao wrote: > This patch enables BTI branch protection for runtime part on Linux/aarch64 > platform. > > Motivation > > 1. Since Fedora 33, glibc+kernel are PAC/BTI enabled by default. User-level > packages can gain additional hardening by compiling with th

Re: Issue cross-compiling idk 8 for powerpc

2024-08-07 Thread Kurt Stine
Hi Magnus, No, I am still unable to cross-compile jdk8u for ppc32. I was able to get the latest community ppc32 build from Azul, but it isn’t the latest/most up-to-date version. Regards, Kurt From: Magnus Ihse Bursie Date: Tuesday, August 6, 2024 at 9:41 AM To: Kurt Stine , "build-dev@openjdk

Re: Issue cross-compiling idk 8 for powerpc

2024-08-07 Thread Aleksey Shipilev
Hi, On 07.08.24 19:30, Kurt Stine wrote: No, I am still unable to cross-compile jdk8u for ppc32. I was able to get the latest community ppc32 build from Azul, but it isn’t the latest/most up-to-date version. I used to build PPC32 binaries for JDK 8u with debootstrapped sysroots and native cro

Re: Issue cross-compiling idk 8 for powerpc

2024-08-07 Thread Aleksey Shipilev
On 07.08.24 19:39, Aleksey Shipilev wrote: On 07.08.24 19:30, Kurt Stine wrote: No, I am still unable to cross-compile jdk8u for ppc32. I was able to get the latest community ppc32 build from Azul, but it isn’t the latest/most up-to-date version. I used to build PPC32 binaries for JDK 8u with

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-07 Thread Brian Burkhalter
On Wed, 7 Aug 2024 16:03:33 GMT, Brian Burkhalter wrote: >> I will check. Thanks for noticing it. > > `CoreServices` is still necessary ([Uniform Type > Identifier](https://developer.apple.com/documentation/uniformtypeidentifiers)s). The Windows libs are also still required for `TransmitFile` a

Integrated: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags

2024-08-07 Thread Leonid Mesnik
On Thu, 1 Aug 2024 18:26:55 GMT, Leonid Mesnik wrote: > There jtreg tests have several additional problemlists > ProblemList-Xcomp.txt > ProblemList-generational-zgc.txt > ProblemList-zgc.txt > Each of them is bound to corresponding execution mode (Xcomp/ZGC) and it > makes sense to treat them

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files) [v2]

2024-08-07 Thread Jiangli Zhou
> Please review this PR that strips the `.llvm_addrsig` section from JDK and > hotspot `.a` static libraries when building with clang. Please see > https://bugs.openjdk.org/browse/JDK-8336849 description for details. Jiangli Zhou has updated the pull request incrementally with one additional co

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files) [v2]

2024-08-07 Thread Jiangli Zhou
On Wed, 7 Aug 2024 15:12:30 GMT, Magnus Ihse Bursie wrote: >> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> - Incorporate comment suggestion from @magicus. Also applied some >> additional minor adjustments on top of the s

Re: RFR: 8336849: Remove .llvm_addrsig section from JDK/VM static libraries (.a files)

2024-08-07 Thread Jiangli Zhou
On Wed, 7 Aug 2024 15:07:51 GMT, Magnus Ihse Bursie wrote: > Are you saying that even using strip can cause lld malfunction? Based on the referenced discussion thread, that seems to be the case. I haven't tested with strip for this issue. > Is there any chance we risk running into problems th

Re: RFR: 8335880: More troubleshooting tips around windows space in path [v3]

2024-08-07 Thread Chen Liang
On Mon, 5 Aug 2024 15:58:37 GMT, Magnus Ihse Bursie wrote: >> configure scans `PATH` which may include other spaced directories, such as >> "Intellij Idea." On a user device, this list can quickly become huge and it >> would be unrealistic for users to generate short paths for every single one

Re: jdk8u: -Wno-regsiter to support newer compilers

2024-08-07 Thread Zdeněk Žamberský
I think to have jdk8 build work out of box, it is better to use older OSes. Like rhel/centos <= 8. You can use VM or container. I personally usually use rhel-8 VM, if I want to build jdk8 locally. Others distros, which should work: Ubuntu <= 20.04 debian <= bullseye (I think) When it comes to ve

Re: jdk8u: -Wno-regsiter to support newer compilers

2024-08-07 Thread Zdeněk Žamberský
Just to clarify, I meant distros, which should just work out of box (currently). That is: installation of dependencies -> configure -> make. According to documentation, without patching, explicit/custom toolchain configuration, etc.. (newer distros often need some additional effort due to newe

Re: jdk8u: -Wno-regsiter to support newer compilers

2024-08-07 Thread Zdeněk Žamberský
Hello, this is known issue, which should get fixed by JDK-8281096: https://github.com/openjdk/jdk8u-dev/pull/357 (see also: https://github.com/openjdk/jdk8u-dev/pull/508) TLDR: Jdk 8 explicitly specifies older c++ version (gnu++98, which not yet deprecated 'register' keyword), but flags are n

Re: jdk8u: -Wno-regsiter to support newer compilers

2024-08-07 Thread Thorsten Glaser
On Wed, 7 Aug 2024, Zdeněk Žamberský wrote: > Others distros, which should work: > Ubuntu <= 20.04 > debian <= bullseye (I think) I maintain OpenJDK 8 for Debian, and my own (local repo and PPA), Debian’s and Ubuntu’s own builds cover Debian wheezy (7) up to unstable and all Ubuntu LTS versions f

Re: Request for assistance in analyzing JDK crash without logs

2024-08-07 Thread David Holmes
On 7/08/2024 3:56 pm, qia nxiao wrote: Hello After compiling and packaging in the local environment, I encountered a crash when using the packaged JDK, and there are no relevant logs. Is there any good method to analyze the cause of the crash? Is there a core dump? Does this happen immediat

Error encountered while packaging version 21.0.3-9 in Windows environment

2024-08-07 Thread qia nxiao
Hello When I try to package version 21.0.3-9 in a Windows environment, I encounter the following error message. Can you help me figure out what might be causing it? d:\code\java\jdk21u-jdk-21.0.3-9\src\hotspot\share\runtime/atomic.hpp(1000): > error C2027: use of undefined type 'Atomic::CmpxchgIm