Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-24 Thread David Holmes
On Sun, 23 Jun 2024 13:18:19 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-24 Thread David Holmes
On Wed, 19 Jun 2024 16:50:22 GMT, Daniel Jeliński wrote: >> We use 2 ParkEvent instances per thread. The ParkEvent objects are never >> freed, but they are recycled when a thread dies, so the number of live >> ParkEvent instances is proportional to the maximum number of threads that >> were li

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-24 Thread David Holmes
On Sun, 23 Jun 2024 09:35:07 GMT, Daniel Jeliński wrote: > the GHA failure looks related, but I can't reproduce it locally. Will dig... The failure in jdk/jshell/ToolTabSnippetTest.java? That test is somewhat flakey - search JBS. - PR Comment: https://git.openjdk.org/jdk/pull/1977

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-24 Thread Daniel Jeliński
On Wed, 19 Jun 2024 16:50:22 GMT, Daniel Jeliński wrote: >> We use 2 ParkEvent instances per thread. The ParkEvent objects are never >> freed, but they are recycled when a thread dies, so the number of live >> ParkEvent instances is proportional to the maximum number of threads that >> were li

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-24 Thread Jan Kratochvil
On Sun, 23 Jun 2024 13:18:19 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334618: ubsan: support setting additional ubsan check options [v3]

2024-06-24 Thread Erik Joelsson
On Fri, 21 Jun 2024 08:29:37 GMT, Matthias Baesken wrote: >> Sometimes it would be helpful to have configure-support for adding >> additional ubsan check options. >> E.g. support new configure option >> '--with-additional-ubsan-checks=' . > > Matthias Baesken has updated the pull request increm

Re: RFR: 8334618: ubsan: support setting additional ubsan check options [v3]

2024-06-24 Thread Erik Joelsson
On Fri, 21 Jun 2024 08:29:37 GMT, Matthias Baesken wrote: >> Sometimes it would be helpful to have configure-support for adding >> additional ubsan check options. >> E.g. support new configure option >> '--with-additional-ubsan-checks=' . > > Matthias Baesken has updated the pull request increm

Re: RFR: 8334618: ubsan: support setting additional ubsan check options [v3]

2024-06-24 Thread Julian Waters
On Fri, 21 Jun 2024 08:29:37 GMT, Matthias Baesken wrote: >> Sometimes it would be helpful to have configure-support for adding >> additional ubsan check options. >> E.g. support new configure option >> '--with-additional-ubsan-checks=' . > > Matthias Baesken has updated the pull request increm

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-24 Thread Kim Barrett
On Sun, 23 Jun 2024 13:18:19 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-24 Thread David Holmes
On Mon, 24 Jun 2024 08:24:56 GMT, Jan Kratochvil wrote: > That's all. That's somewhat of an understatement. :) I'm still unclear how anything ASAN does gets examined by our assertion, but it sounds to me like ASAN is just broken in this area. So I support Kim's conclusion - lets just turn th

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-24 Thread Thomas Stuefe
On Mon, 24 Jun 2024 11:37:07 GMT, David Holmes wrote: > > That's all. > > That's somewhat of an understatement. :) > > I'm still unclear how anything ASAN does gets examined by our assertion, but > it sounds to me like ASAN is just broken in this area. So I support Kim's > conclusion - lets j

Re: RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v9]

2024-06-24 Thread Jorn Vernee
> This PR adds a new JDK tool, called `jnativescan`, that can be used to find > code that accesses native functionality. Currently this includes `native` > method declarations, and methods marked with `@Restricted`. > > The tool accepts a list of class path and module path entries through > `--

Re: RFR: 8317611: Add a tool like jdeprscan to find usage of restricted methods [v9]

2024-06-24 Thread Jorn Vernee
On Mon, 24 Jun 2024 12:57:39 GMT, Jorn Vernee wrote: >> This PR adds a new JDK tool, called `jnativescan`, that can be used to find >> code that accesses native functionality. Currently this includes `native` >> method declarations, and methods marked with `@Restricted`. >> >> The tool accepts

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v7]

2024-06-24 Thread Hamlin Li
> Hi, > Can you help to review the patch? > This pr is based on previous work and discussion in [pr > 16234](https://github.com/openjdk/jdk/pull/16234), [pr > 18294](https://github.com/openjdk/jdk/pull/18294). > > Compared with previous prs, the major change in this pr is to integrate the > sou

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v3]

2024-06-24 Thread Jan Kratochvil
> fastdebug: > > > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error > (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), > pid=878152, tid=878158 > # assert(_thread->is_in_live_stack((address)this)) failed: not on stack? > #

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v4]

2024-06-24 Thread Jan Kratochvil
> fastdebug: > > > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error > (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), > pid=878152, tid=878158 > # assert(_thread->is_in_live_stack((address)this)) failed: not on stack? > #

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v3]

2024-06-24 Thread Jan Kratochvil
On Mon, 24 Jun 2024 14:04:15 GMT, Thomas Stuefe wrote: >> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert "Implement address-use-after-return" >> >> This reverts commit 7e089829f1ebf3d4e5aafe0934bd18db0234136b.

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v3]

2024-06-24 Thread Thomas Stuefe
On Mon, 24 Jun 2024 14:14:36 GMT, Jan Kratochvil wrote: >> make/autoconf/jdk-options.m4 line 448: >> >>> 446: if test "x$TOOLCHAIN_TYPE" = "xclang"; then >>> 447: ASAN_CFLAGS="$ASAN_CFLAGS >>> -fsanitize-address-use-after-return=never" >>> 448: fi >> >> Curious

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v4]

2024-06-24 Thread Thomas Stuefe
On Mon, 24 Jun 2024 14:11:35 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v33]

2024-06-24 Thread Severin Gehwolf
> Please review this patch which adds a jlink mode to the JDK which doesn't > need the packaged modules being present. A.k.a run-time image based jlink. > Fundamentally this patch adds an option to use `jlink` even though your JDK > install might not come with the packaged modules (directory `jm

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

2024-06-24 Thread Jan Kratochvil
> fastdebug: > > > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error > (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), > pid=878152, tid=878158 > # assert(_thread->is_in_live_stack((address)this)) failed: not on stack? > #

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v3]

2024-06-24 Thread Thomas Stuefe
On Mon, 24 Jun 2024 13:45:38 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v8]

2024-06-24 Thread Hamlin Li
> Hi, > Can you help to review the patch? > This pr is based on previous work and discussion in [pr > 16234](https://github.com/openjdk/jdk/pull/16234), [pr > 18294](https://github.com/openjdk/jdk/pull/18294). > > Compared with previous prs, the major change in this pr is to integrate the > sou

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

2024-06-24 Thread Kim Barrett
On Mon, 24 Jun 2024 14:34:37 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v5]

2024-06-24 Thread Kim Barrett
On Mon, 24 Jun 2024 14:34:37 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time

2024-06-24 Thread Ioi Lam
Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve start-up performance. - This PR uses the same framework introduced in #19355 and just added handling for methods. - More filtering is needed when building the default archive in the JDK: constant pool resolution when running t

RFR: 8334598: Default classlist in JDK is not deterministic after JDK-8293980

2024-06-24 Thread Ioi Lam
More filtering is needed when building the default archive in the JDK: constant pool resolution when running the `build.tools.classlist.HelloClasslist` program is not deterministic (due to concurrency in core library classes). This could cause different values in the `@cp` lines in the classlist

Re: RFR: 8309634: Resolve CONSTANT_MethodRef at CDS dump time

2024-06-24 Thread Ioi Lam
On Mon, 24 Jun 2024 17:21:18 GMT, Ioi Lam wrote: > Resolve `CONSTANT_MethodRef` entries during CDS dump time to improve start-up > performance. > > - This PR uses the same framework introduced in #19355 and just added > handling for methods. > - Support for getstatic/putstatic/invokestatic wil

Re: RFR: 8334598: Default classlist in JDK is not deterministic after JDK-8293980

2024-06-24 Thread Calvin Cheung
On Mon, 24 Jun 2024 21:22:48 GMT, Ioi Lam wrote: > More filtering is needed when building the default archive in the JDK: > constant pool resolution when running the > `build.tools.classlist.HelloClasslist` program is not deterministic (due to > concurrency in core library classes). This could

RFR: 8334895: OpenJDK fails to configure on linux aarch64 when CDS is disabled after JDK-8331942

2024-06-24 Thread Vladimir Petko
This PR sets COMPATIBLE_CDS_ALIGNMENT_DEFAULT to auto for aarch64. This allows to avoid configure error on arm64: $ sh configure --disable-jvm-feature-cds ... checking if CDS archive is available... no (CDS is disabled) checking if a default CDS archive should be generated... disabled, from defau

Re: RFR: 8334598: Default classlist in JDK is not deterministic after JDK-8293980

2024-06-24 Thread David Holmes
On Mon, 24 Jun 2024 21:22:48 GMT, Ioi Lam wrote: > More filtering is needed when building the default archive in the JDK: > constant pool resolution when running the > `build.tools.classlist.HelloClasslist` program is not deterministic (due to > concurrency in core library classes). This could