Re: Hermetic Java project meeting

2024-05-30 Thread Magnus Ihse Bursie
On 2024-05-21 20:51, Jiangli Zhou wrote: Magnus will send out his changes as PR draft for initial review for deciding on how to move forward with the non-makefile changes. This is now published in https://github.com/openjdk/jdk/pull/19478. /Magnus

RFR: 8333282: Better warning if newly build JDK fails to run

2024-05-30 Thread Magnus Ihse Bursie
If the newly built JDK fails to run ("DOA"), we will get a strange error message about jdk.compiler-gendata errors from make. The reason is not at all obvious. Instead, we should make a simple check that we can actually use the new JDK before starting to use it for the first time, and report cl

Re: RFR: 8333282: Better warning if newly build JDK fails to run

2024-05-30 Thread Erik Joelsson
On Thu, 30 May 2024 15:02:38 GMT, Magnus Ihse Bursie wrote: > If the newly built JDK fails to run ("DOA"), we will get a strange error > message about jdk.compiler-gendata errors from make. The reason is not at all > obvious. > > Instead, we should make a simple check that we can actually use

Re: RFR: 8330182: Start of release updates for JDK 24 [v9]

2024-05-30 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update symbol files for JDK 23 build 25. - Changes: - all: https://git.openjdk.org/jdk/pull/18787/files - new: https://git.openjdk.org/jdk/pull/1878

Re: RFR: 8333282: Better warning if newly build JDK fails to run

2024-05-30 Thread Magnus Ihse Bursie
On Thu, 30 May 2024 15:02:38 GMT, Magnus Ihse Bursie wrote: > If the newly built JDK fails to run ("DOA"), we will get a strange error > message about jdk.compiler-gendata errors from make. The reason is not at all > obvious. > > Instead, we should make a simple check that we can actually use

Re: RFR: 8330182: Start of release updates for JDK 24 [v10]

2024-05-30 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge branch 'master' into JDK-8330188 - Update symbol files for JDK 23 build 25. - Correct release year. - Merge branch 'master' into

Re: RFR: 8330182: Start of release updates for JDK 24 [v10]

2024-05-30 Thread Iris Clark
On Thu, 30 May 2024 17:11:31 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 18 commits: > > - Merge branch 'master' into JDK-8330188 > - Update symbol files for JDK 23

Re: RFR: 8330182: Start of release updates for JDK 24 [v9]

2024-05-30 Thread Chen Liang
On Thu, 30 May 2024 16:44:21 GMT, Joe Darcy wrote: >> Get JDK 24 underway. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Update symbol files for JDK 23 build 25. src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-N.s

Re: RFR: 8330182: Start of release updates for JDK 24 [v9]

2024-05-30 Thread Jan Lahoda
On Thu, 30 May 2024 18:39:19 GMT, Chen Liang wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update symbol files for JDK 23 build 25. > > src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-N.sym.txt line 1: >

RFR: 8333301: Remove static builds using --enable-static-build

2024-05-30 Thread Magnus Ihse Bursie
The original way of building static libraries in the JDK was to use the configure argument --enable-static-build, which set the value of the make variable STATIC_BUILD. (Note that this is not the same as the source code definition STATIC_BUILD, which will be set by other means as well.) This me

Re: RFR: 8330182: Start of release updates for JDK 24 [v11]

2024-05-30 Thread Joe Darcy
> Get JDK 24 underway. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Temporarily problem list java.lang.instrument tests until jar generation is fixed. - Changes: - all: https://git.openjdk.org/jdk/pull/18787/files -

Re: RFR: 8293980: Resolve CONSTANT_FieldRef at CDS dump time [v3]

2024-05-30 Thread Ioi Lam
On Thu, 30 May 2024 04:15:24 GMT, Dan Heidinga wrote: >> `preresolve_list` has the original CP indices (E.g., `putfield #123` as >> stored in the classfile), but in HotSpot, after bytecode rewriting, the u2 >> following the bytecode is changed to an index into the >> `cpcache()->_resolved_fiel