On Wed, 12 Oct 2022 01:25:22 GMT, Dingli Zhang wrote:
>> I built hsdis with the following parameters from source code of binutils
>> while cross-compiling:
>>
>> --with-hsdis=binutils \
>> --with-binutils-src=/home/dingli/jdk-tools/binutils-2.38
>>
>>
>> But configure will exit with the follo
On Mon, 10 Oct 2022 06:32:09 GMT, Dingli Zhang wrote:
> I built hsdis with the following parameters from source code of binutils
> while cross-compiling:
>
> --with-hsdis=binutils \
> --with-binutils-src=/home/dingli/jdk-tools/binutils-2.38
>
>
> But configure will exit with the following err
Sometimes, the configure script is not called directly, but indirectly, using
e.g. a wrapper script. This happens for instance in the case of using jib.sh.
In such cases, calling "make reconfigure" will not re-execute the original
wrapper script. This can result in subtle bugs.
Instead, make a
In [JDK-8294618](https://bugs.openjdk.org/browse/JDK-8294618), many of the old
references to openjdk.java.net was updated.
The test code was intentionally left out of that change, but some other
instances were missed, though.
This patch will fix those misses (but will still leave test code chan
On Wed, 12 Oct 2022 09:08:55 GMT, Magnus Ihse Bursie wrote:
> In [JDK-8294618](https://bugs.openjdk.org/browse/JDK-8294618), many of the
> old references to openjdk.java.net was updated.
>
> The test code was intentionally left out of that change, but some other
> instances were missed, though
Markdown files are basically source code for documentation. It should have the
same whitespace checks as all other source code, so we don't get spurious
trailing whitespace changes.
-
Commit messages:
- 8295205: Add jcheck whitespace checking for markdown files
Changes: https://gi
In autoconf 2.71, there is a warning generated for calling AC_CHECK_HEADERS
with a variable.
It is not clear to me why they consider this to be a problem, but the warning
is printed whenever you run configure with autoconf 2.71 or newer, and it is
annoying.
We're only doing this in one place.
On Tue, 27 Sep 2022 19:07:04 GMT, Magnus Ihse Bursie wrote:
>>> @shipilev I had hoped this PR would trigger warning hunting in Hotspot, but
>>> I did not anticipate that it would happen even before it was pushed! ;-)
>>> Let me know when you are done fixing individual warnings; there seem to be
On Wed, 28 Sep 2022 19:52:27 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> hotspot.
>
> Any warnings that were only triggered in a few files wer
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> hotspot.
>
> Any warnings that were only triggered in a few files wer
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> hotspot.
>
> Any warnings that were only triggered in a few files wer
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> hotspot.
>
> Any warnings that were only triggered in a few files wer
On Wed, 12 Oct 2022 10:35:08 GMT, Aleksey Shipilev wrote:
>> @shipilev So you want me to integrate this first, and then you follow up
>> with your fixes?
>
> Hey @magicus, are you going forward with this PR, or?
@shipilev In a "tenth time's the charm" spirit, here's what I do think is
actually
On Wed, 12 Oct 2022 10:35:08 GMT, Aleksey Shipilev wrote:
>> @shipilev So you want me to integrate this first, and then you follow up
>> with your fixes?
>
> Hey @magicus, are you going forward with this PR, or?
> @shipilev In a "tenth time's the charm" spirit, here's what I do think is
> actu
It is a trivial addition to our GHA scripts to allow the user to trigger a
manual run, and to provide additional arguments to `make` and `configure` for
that run. (Not all arguments will succeed though, if it conflicts with the GHA
setup.) But it is an easy way to test some specific ways of buil
On Tue, 11 Oct 2022 16:02:41 GMT, Andrew Haley wrote:
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and
On Tue, 11 Oct 2022 16:50:33 GMT, Andrew Haley wrote:
> Also: this patch is Linux-only. I'll ask for help from build experts to make
> the tests GCC-only; it's not clear to me how.
@theRealAph We currently have a more or less 1-to-1 relationship between OS and
compiler. From a portability pers
On Thu, 29 Sep 2022 00:09:37 GMT, Mike Duigou wrote:
> The OpenJDK build system does not support building when the source code
> resides on a path that contains a space. This requirement is documented in
> the build instructions but not enforced by the configure script.
>
> This change adds an
On Tue, 11 Oct 2022 08:18:08 GMT, Christian Hagedorn
wrote:
>> The DWARF debugging symbols emitted by Clang is different from what GCC is
>> emitting. While GCC produces a complete `.debug_aranges` section (which is
>> required in the DWARF parser), Clang does not. As a result, the DWARF parse
On Tue, 11 Oct 2022 08:18:08 GMT, Christian Hagedorn
wrote:
>> The DWARF debugging symbols emitted by Clang is different from what GCC is
>> emitting. While GCC produces a complete `.debug_aranges` section (which is
>> required in the DWARF parser), Clang does not. As a result, the DWARF parse
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
> System
On Wed, 12 Oct 2022 11:05:43 GMT, Magnus Ihse Bursie wrote:
> It is a trivial addition to our GHA scripts to allow the user to trigger a
> manual run, and to provide additional arguments to `make` and `configure` for
> that run. (Not all arguments will succeed though, if it conflicts with the
On Wed, 12 Oct 2022 10:23:13 GMT, Magnus Ihse Bursie wrote:
> In autoconf 2.71, there is a warning generated for calling AC_CHECK_HEADERS
> with a variable.
>
> It is not clear to me why they consider this to be a problem, but the warning
> is printed whenever you run configure with autoconf 2
On Wed, 12 Oct 2022 08:07:35 GMT, Magnus Ihse Bursie wrote:
> Sometimes, the configure script is not called directly, but indirectly, using
> e.g. a wrapper script. This happens for instance in the case of using jib.sh.
>
> In such cases, calling "make reconfigure" will not re-execute the origi
On Wed, 12 Oct 2022 09:08:55 GMT, Magnus Ihse Bursie wrote:
> In [JDK-8294618](https://bugs.openjdk.org/browse/JDK-8294618), many of the
> old references to openjdk.java.net was updated.
>
> The test code was intentionally left out of that change, but some other
> instances were missed, though
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
Thank you! Since I enabled visible whitespace
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 10:23:13 GMT, Magnus Ihse Bursie wrote:
> In autoconf 2.71, there is a warning generated for calling AC_CHECK_HEADERS
> with a variable.
>
> It is not clear to me why they consider this to be a problem, but the warning
> is printed whenever you run configure with autoconf 2
On Wed, 12 Oct 2022 08:07:35 GMT, Magnus Ihse Bursie wrote:
> Sometimes, the configure script is not called directly, but indirectly, using
> e.g. a wrapper script. This happens for instance in the case of using jib.sh.
>
> In such cases, calling "make reconfigure" will not re-execute the origi
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
This pull request has now been integrated.
Ch
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> hots
On Wed, 12 Oct 2022 10:23:13 GMT, Magnus Ihse Bursie wrote:
> In autoconf 2.71, there is a warning generated for calling AC_CHECK_HEADERS
> with a variable.
>
> It is not clear to me why they consider this to be a problem, but the warning
> is printed whenever you run configure with autoconf 2
On Wed, 12 Oct 2022 09:08:55 GMT, Magnus Ihse Bursie wrote:
> In [JDK-8294618](https://bugs.openjdk.org/browse/JDK-8294618), many of the
> old references to openjdk.java.net was updated.
>
> The test code was intentionally left out of that change, but some other
> instances were missed, though
On Wed, 12 Oct 2022 11:05:43 GMT, Magnus Ihse Bursie wrote:
> It is a trivial addition to our GHA scripts to allow the user to trigger a
> manual run, and to provide additional arguments to `make` and `configure` for
> that run. (Not all arguments will succeed though, if it conflicts with the
On Wed, 12 Oct 2022 13:33:26 GMT, Kim Barrett wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Github workflow changes were not supposed to be in this PR...
>
> make/hotspot/lib/CompileJvm.gmk line 92:
>
>> 9
On Tue, 11 Oct 2022 18:45:56 GMT, Daniel D. Daugherty
wrote:
> It seems strange to me that the native library part is here:
>
> test/hotspot/jtreg/runtime/jni/TestDenormalFloat/libfast-math.c
>
> and the two test files are here:
>
> test/hotspot/jtreg/compiler/floatingpoint/TestDenormalDouble
On Tue, 11 Oct 2022 08:18:08 GMT, Christian Hagedorn
wrote:
>> The DWARF debugging symbols emitted by Clang is different from what GCC is
>> emitting. While GCC produces a complete `.debug_aranges` section (which is
>> required in the DWARF parser), Clang does not. As a result, the DWARF parse
On Wed, 12 Oct 2022 00:38:39 GMT, David Holmes wrote:
> This appears to be a 10 year old bug in gcc. Have we ever had any issues
> reported because of this?
That's what is so insidious about messing with the floating-point control word:
all that happens is people get slightly inaccurate result
On Wed, 12 Oct 2022 11:28:08 GMT, Magnus Ihse Bursie wrote:
> > Also: this patch is Linux-only. I'll ask for help from build experts to
> > make the tests GCC-only; it's not clear to me how.
>
> @theRealAph We currently have a more or less 1-to-1 relationship between OS
> and compiler. From a
On Mon, 10 Oct 2022 15:29:16 GMT, Julian Waters wrote:
>> Several parts of the make system in the JDK has large parts of cluttered if
>> branches dedicated to setting flags for the specific compiler used in the
>> build. This could be more neatly accomplished by instead adding more target
>> c
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
> System
On Wed, 12 Oct 2022 13:58:06 GMT, Andrew Haley wrote:
> We do not support gcc on macos, windows or aix, which leaves linux as the
> only gcc platform in the mainline (ports in separate repos will have to
> handle this themselves). We do support using clang on linux instead of gcc
> (but do not
Inspired by the comment
https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for
JDK-8294623, I realized we need to do at least some kind of version
verification of gtest.
Since gtest do not properly declare its version, this can't be done exactly,
but we can look at some tell-tal
> Inspired by the comment
> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for
> JDK-8294623, I realized we need to do at least some kind of version
> verification of gtest.
>
> Since gtest do not properly declare its version, this can't be done exactly,
> but we can look at
On Wed, 12 Oct 2022 14:11:46 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Tue, 11 Oct 2022 08:18:08 GMT, Christian Hagedorn
wrote:
>> The DWARF debugging symbols emitted by Clang is different from what GCC is
>> emitting. While GCC produces a complete `.debug_aranges` section (which is
>> required in the DWARF parser), Clang does not. As a result, the DWARF parse
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
> System
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
> System
On Wed, 12 Oct 2022 14:19:53 GMT, Magnus Ihse Bursie wrote:
> So you want to provide this dlopen wrapper for other platforms as well?
I'm not sure. It sounds to me like a Linux-only patch would do it, but I think
BSD uses GCC sometimes.
(Open/FreeBSD is downstream of OpenJDK, and I'd love to ge
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition and subtraction result
> is not reduced before the value is re
On Wed, 12 Oct 2022 13:56:56 GMT, Andrew Haley wrote:
> > This appears to be a 10 year old bug in gcc. Have we ever had any issues
> > reported because of this?
>
> That's what is so insidious about messing with the floating-point control
> word: all that happens is people get slightly inaccur
On Wed, 12 Oct 2022 14:37:37 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Wed, 12 Oct 2022 15:48:25 GMT, Aleksey Shipilev wrote:
> Do we need to shuffle^W sort includes in this patch? I presume you'd want
> this patch to be cleanly backportable, which means it should probably be as
> point-y as it can get.
OK, I can back that part out.
> src/hotspot/os/linux/os_
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
> System
> Hi,
>
> May I have this update reviewed? With this update, the result will be always
> reduced in EC limbs addition and subtraction operations in the JDK
> implementation.
>
> In the current implementation, the EC limbs addition and subtraction result
> is not reduced before the value is re
On Wed, 12 Oct 2022 14:20:08 GMT, Magnus Ihse Bursie wrote:
>> Inspired by the comment
>> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for
>> JDK-8294623, I realized we need to do at least some kind of version
>> verification of gtest.
>>
>> Since gtest do not properly de
> A bug in GCC causes shared libraries linked with -ffast-math to disable
> denormal arithmetic. This breaks Java's floating-point semantics.
>
> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>
> One solution is to save and restore the floating-point control word around
> System
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable
>> denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to sav
On Wed, 12 Oct 2022 17:43:47 GMT, Vladimir Ivanov wrote:
> Isn't it an illustration of a more general problem we have with native code
> where it can mess with FP environment at any time?
>
> We already have similar problems with MXCSR register and provide verification
> logic (part of `-Xchec
On Wed, 12 Oct 2022 20:35:09 GMT, Maurizio Cimadamore
wrote:
> Note also that this specific problem is triggered by dlopen itself, because
> certain libraries might have some "bad" (from the perspective of JVM)
> initialization code.
... and it leads to another question whether the JVM itself
On Wed, 12 Oct 2022 14:20:08 GMT, Magnus Ihse Bursie wrote:
>> Inspired by the comment
>> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for
>> JDK-8294623, I realized we need to do at least some kind of version
>> verification of gtest.
>>
>> Since gtest do not properly de
On Thu, 13 Oct 2022 02:56:01 GMT, Dingli Zhang wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains two
>> additional co
On Wed, 12 Oct 2022 14:08:13 GMT, Magnus Ihse Bursie wrote:
> Inspired by the comment
> https://github.com/openjdk/jdk/pull/10503#issuecomment-1275500585 for
> JDK-8294623, I realized we need to do at least some kind of version
> verification of gtest.
>
> Since gtest do not properly declare
66 matches
Mail list logo
