On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
> FWIW I think these changes to the makefiles are routine enough at this point
> that we don't need to involve someone from the build team, but they can be
> approved by any reviewer.
I agree. Just addin
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Will add with the benchmark.
-
PR Comment: https://git.openjdk.org/jdk/pull/26035#issuecomment-3018765679
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Approving tentatively, though I think it would be best to rescind this PR and
fold it into a follow-up PR that actually adds a benchmark that needs these
exports.
FWIW I think these changes to the makefi
On Mon, 30 Jun 2025 08:43:16 GMT, David Beaumont wrote:
> Doing it on its own means not having to find someone who can approve both the
> makefile change and the benchmark at the same time. People say that things
> should be split up into independent things, so I did. I mean I can combine
> th
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Doing it on its own means not having to find someone who can approve both the
makefile change and the benchmark at the same time. People say that things
should be split up into independent things, so I di
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Looks reasonable.
-
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26035#pullrequestreview-2969934108
On Sun, 29 Jun 2025 22:19:18 GMT, David Beaumont wrote:
> Added jimage and jrtfs exports.
Is there a reason to do this on its own? Usually the exports are expanded as
benchmarks are added that use internal APIs.
-
PR Comment: https://git.openjdk.org/jdk/pull/26035#issuecomment-301
