Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation [v2]

2025-06-26 Thread duke
On Mon, 23 Jun 2025 18:54:10 GMT, Luigi Montoya wrote: >> Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh >> >> The DevKit currently created on a Windows AArch64 machine uses the x64 >> compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin >> /headers /

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation [v2]

2025-06-24 Thread Erik Joelsson
On Mon, 23 Jun 2025 18:54:10 GMT, Luigi Montoya wrote: >> Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh >> >> The DevKit currently created on a Windows AArch64 machine uses the x64 >> compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin >> /headers /

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation [v2]

2025-06-23 Thread Magnus Ihse Bursie
On Mon, 23 Jun 2025 18:54:10 GMT, Luigi Montoya wrote: >> Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh >> >> The DevKit currently created on a Windows AArch64 machine uses the x64 >> compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin >> /headers /

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation [v2]

2025-06-23 Thread Luigi Montoya
> Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh > > The DevKit currently created on a Windows AArch64 machine uses the x64 > compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin > /headers /out:cl.txt cl.exe" on the compiler in the generated DevKit and

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-23 Thread Magnus Ihse Bursie
On Thu, 19 Jun 2025 23:49:24 GMT, Luigi Montoya wrote: >> So if we run the devkit script on an aarch64 machine, we can create a devkit >> that will work on both x64 and aarch64? But if we run it on x64, the devkit >> that we create will only work on x64? Have I got this right? >> >> If so, I t

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-19 Thread Luigi Montoya
On Thu, 19 Jun 2025 14:09:47 GMT, Magnus Ihse Bursie wrote: >> When you download VS on x64 you just get cross-compilers for aarch64 (I >> don't know why). The `Hostarm64` directory is not created in x64 machines. > > So if we run the devkit script on an aarch64 machine, we can create a devkit >

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-19 Thread Magnus Ihse Bursie
On Tue, 17 Jun 2025 17:57:06 GMT, Luigi Montoya wrote: >> Is this the case when downloading VS on x64 as well, that you get a binary >> that can only be run on aarch64 bundled too? Or is the x64 installation just >> a subset of the aarch64 installation? > > When you download VS on x64 you just

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-17 Thread Luigi Montoya
On Tue, 17 Jun 2025 14:10:29 GMT, Magnus Ihse Bursie wrote: >> Yes, if I download VS on aarch64 I get the four compilers installed. > > Is this the case when downloading VS on x64 as well, that you get a binary > that can only be run on aarch64 bundled too? Or is the x64 installation just > a s

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-17 Thread Magnus Ihse Bursie
On Mon, 16 Jun 2025 17:29:04 GMT, Luigi Montoya wrote: >> I find this confusing, but that's probably since I don't understand what >> Microsoft is shipping and where. >> >> There are 4 relevant compilers: >> 1) A compiler that runs on x64 and generates x64 code (x64 native >> compilation) >> 2

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-16 Thread Luigi Montoya
On Mon, 16 Jun 2025 13:38:34 GMT, Magnus Ihse Bursie wrote: >> When you download the Visual Studio Build Tools on an ARM64 machine, it >> downloads the native binaries for the `x64` architecture under `Hostx64` and >> the native binaries for `arm64` under `Hostarm64`. This devkit script does >

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-16 Thread Magnus Ihse Bursie
On Sun, 15 Jun 2025 04:50:40 GMT, Luigi Montoya wrote: >> I agree with your general premise, that the devkit should be created for the >> platform the devkit script is run on. >> >> When you say that you should produce "native" x64 libraries on aarch64, do >> you mean that they should be run u

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-14 Thread Luigi Montoya
On Sat, 14 Jun 2025 11:59:32 GMT, Magnus Ihse Bursie wrote: >> I was thinking we could create the devkit based on the platform where the >> script is being run. For example, running `createWindowsDevkit.sh` on: >> >> - Windows x64 would produce: >> - Native x86 libraries >> - Native x64 lib

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-14 Thread Magnus Ihse Bursie
On Fri, 13 Jun 2025 19:27:20 GMT, Luigi Montoya wrote: >> make/devkit/createWindowsDevkit.sh line 163: >> >>> 161: else >>> 162: cp -r "$VS_INSTALL_DIR/${VC_SUBDIR}/bin/Hostx64/arm64" >>> $DEVKIT_ROOT/VC/bin/ >>> 163: fi >> >> It seems to make sense to have a single devkit since there seem

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-13 Thread Luigi Montoya
On Fri, 13 Jun 2025 13:58:48 GMT, Magnus Ihse Bursie wrote: >> Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh >> >> The DevKit currently created on a Windows AArch64 machine uses the x64 >> compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin >> /head

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-13 Thread Magnus Ihse Bursie
On Thu, 15 May 2025 22:16:34 GMT, Luigi Montoya wrote: > Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh > > The DevKit currently created on a Windows AArch64 machine uses the x64 > compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin > /headers /out:c

Re: RFR: 8357079: Fix Windows AArch64 DevKit Creation

2025-06-12 Thread Erik Joelsson
On Thu, 15 May 2025 22:16:34 GMT, Luigi Montoya wrote: > Fix path for Visual Studio arm64 binaries in createWindowsDevkit.sh > > The DevKit currently created on a Windows AArch64 machine uses the x64 > compiler binaries (e.g. cl.exe). This can be inspected by running "dumpbin > /headers /out:c