On Thu, 22 May 2025 12:54:54 GMT, Aleksey Shipilev wrote:
>> Jiangli Zhou has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 36 additional
>> commi
On Wed, 21 May 2025 22:09:15 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
On Thu, 22 May 2025 12:54:54 GMT, Aleksey Shipilev wrote:
> Taking a look at this today, sorry.
@shipilev I was going to integrate, then saw your above comment. I'll hold off
then. There are benefits for integrating and enabling testing on static-jdk in
GHA. If there is nothing major (or block
On Wed, 21 May 2025 22:09:15 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
On Wed, 21 May 2025 22:09:15 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
On Fri, 16 May 2025 20:23:00 GMT, Magnus Ihse Bursie wrote:
> I approved this but then I noticed that there were failures in the last GHA
> run for the new static run. You need to fix or problemlist them before
> integrating.
Right, I'll hold off integrating this PR, until the static testing g
On Thu, 15 May 2025 19:44:39 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
On Thu, 15 May 2025 19:44:39 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
On Thu, 15 May 2025 00:25:40 GMT, Jiangli Zhou wrote:
>> Did you try this?
>
> I missed your above suggestion earlier. Experimenting with this. Thanks for
> the suggestion.
I went with using an explicit `extra-options` step to set up the extra
command-line options for `make test-prebuilt` to h
On Wed, 14 May 2025 06:40:09 GMT, Magnus Ihse Bursie wrote:
> The code alternates between `if [[ '${{ inputs.static-suffix }}' != '' ]]`
> and `if: ${{ inputs.static-suffix == '-static' }}`. I don't really care about
> which you chose, but please pick one and stick to it.
Replaced `if [[ '${{
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
On Wed, 14 May 2025 06:37:09 GMT, Magnus Ihse Bursie wrote:
>> I think you could add something like
>>
>> ${{ inputs.extra-test-options }}
>>
>> in the `make test-prebuilt` command line, and then set it up as arguments
>> when calling the test workflow.
>
> Did you try this?
I missed your ab
On Mon, 12 May 2025 22:28:29 GMT, Jiangli Zhou wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>> .git
On Tue, 6 May 2025 15:50:01 GMT, Magnus Ihse Bursie wrote:
>>> Do we really need to duplicate all this code? From what I can see, this is
>>> just to be able to send in the JDK_FOR_COMPILE argument, right?
>>
>> Yaml syntax is new to me. I went with that as it worked. :-) The static case
>> se
On Mon, 5 May 2025 20:59:08 GMT, Jiangli Zhou wrote:
>> .github/workflows/main.yml line 234:
>>
>>> 232: with:
>>> 233: platform: linux-x64
>>> 234: make-target: 'product-bundles test-bundles static-jdk-bundles'
>>
>> This will make us build the tests and the normal JDK twice, o
On Mon, 5 May 2025 14:55:54 GMT, Magnus Ihse Bursie wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add $static_jdk_bundle_zip$static_jdk_bundle_tar_gz for bundle-found check.
>
> .github/workflows/main.yml line 36
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/actions/get-bundles/action.yml.
> - Add `static-suffix` param
On Mon, 5 May 2025 21:39:15 GMT, Jiangli Zhou wrote:
>> .github/workflows/test.yml line 95:
>>
>>> 93: - test-name: 'hs/tier1 common'
>>> 94: test-suite: 'test/hotspot/jtreg/:tier1_common'
>>> 95: debug-suffix: ${{ inputs.debug-suffix }}
>>
>> I don't understan
On Mon, 5 May 2025 14:59:04 GMT, Magnus Ihse Bursie wrote:
> Do we really need to duplicate all this code? From what I can see, this is
> just to be able to send in the JDK_FOR_COMPILE argument, right?
Yaml syntax is new to me. I went with that as it worked. :-) The static case
sets the `JDK_F
On Mon, 5 May 2025 14:57:08 GMT, Magnus Ihse Bursie wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>>
On Mon, 5 May 2025 14:52:38 GMT, Magnus Ihse Bursie wrote:
>> Please review this PR that adds a `test-linux-x64-static` job, which runs
>> tier1 tests on the static-jdk 'release' binary created from the
>> `linux-x64-static` build job in GHA. Following are the details on the
>> changes:
>>
>>
On Thu, 1 May 2025 22:46:00 GMT, Jiangli Zhou wrote:
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/action
On Thu, 1 May 2025 22:46:00 GMT, Jiangli Zhou wrote:
> Please review this PR that adds a `test-linux-x64-static` job, which runs
> tier1 tests on the static-jdk 'release' binary created from the
> `linux-x64-static` build job in GHA. Following are the details on the changes:
>
> .github/action
32 matches
Mail list logo
