Re: RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-02 Thread Magnus Ihse Bursie
On Wed, 2 Apr 2025 08:00:25 GMT, Julian Waters wrote: > How does the __GNUC__ check affect clang?? Isn't that just for gcc? No, clang disguises as gcc in several ways, and this is one of them. In effect, you can consider `__GNUC__` to be not a check for a particular compiler, but for complianc

Re: RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-02 Thread Julian Waters
On Wed, 2 Apr 2025 02:00:39 GMT, David Holmes wrote: > > there was already a pragma but due to incorrect restrictions it did not > > apply to clang. > > How does the `__GNUC__` check affect clang?? Isn't that just for gcc? clang has a tendency to like to pretend to be other compilers, it defin

Re: RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-01 Thread David Holmes
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote: > there was already a pragma but due to incorrect restrictions it did not apply > to clang. How does the `__GNUC__` check affect clang?? Isn't that just for gcc? - PR Comment: https://git.openjdk.org/jdk/pull/24357#issueco

Re: RFR: 8353458: Don't pass -Wno-format-nonliteral to CFLAGS

2025-04-01 Thread Erik Joelsson
On Tue, 1 Apr 2025 13:22:47 GMT, Magnus Ihse Bursie wrote: > The proper way to disable warnings is to use the DISABLED_WARNINGS arguments. > In this particular case, there was already a pragma but due to incorrect > restrictions it did not apply to clang. Marked as reviewed by erikj (Reviewer)