Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-27 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-20 Thread David Holmes
On Thu, 20 Mar 2025 12:38:37 GMT, Magnus Ihse Bursie wrote: > Is there any gain then in changing away from -lpthread? That is clearly > defined, link with libpthread, with no side effects. "If it ain't broke..." True - what we have works and using `-pthread` might subtly change things. ---

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-20 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 10:44:30 GMT, snake66 wrote: >>> Another follow-up is if it would hurt to include $LIBPTHREAD for _all_ >>> Hotspot tests, to avoid the huge list. @dholmes-ora Do you have anything >>> coming to mind directly that would make that infeasible, or is it just a >>> matter of te

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-17 Thread snake66
On Mon, 17 Mar 2025 06:41:31 GMT, David Holmes wrote: >> @magicus why can't we just use `-pthread` everywhere? My recollection is >> that `-pthread` both sets compiler directives needed for pthread programming >> and links to libpthread, so it seems to be what we should be using. ?? > >> Anothe

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-16 Thread David Holmes
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote: >>> What is the intended way of using this? Do you run make with >>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the >>> specific way of linking to pthread? >> >> This is in preparation of the upcoming BSD port, which use

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-15 Thread Erik Joelsson
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread Magnus Ihse Bursie
On Fri, 7 Mar 2025 00:18:14 GMT, David Holmes wrote: >>> What is the intended way of using this? Do you run make with >>> LIBPTHREAD=-pthread or do you apply a patch on libraries.m4 for the >>> specific way of linking to pthread? >> >> This is in preparation of the upcoming BSD port, which use

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread duke
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-11 Thread Magnus Ihse Bursie
On Thu, 6 Mar 2025 13:27:15 GMT, snake66 wrote: >> Abstracting this out seems reasonable to me, though I should say I thought >> we already used `-pthread` rather than `-lpthread`. >> >> Needs build team approval before integrating. > >> Abstracting this out seems reasonable to me, though I sho

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-10 Thread Magnus Ihse Bursie
On Sat, 8 Mar 2025 13:39:44 GMT, snake66 wrote: >> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that >> it's possible to parameterize this for platforms that use different flags >> for enabling posix threads. >> >> This work is a continuation of the work done by Greg Lew

Re: RFR: 8351322: Parameterize link option for pthreads [v2]

2025-03-08 Thread snake66
> Replace hardcoded instances of `-lpthread` with `$(LIBPTHREAD)`, so that it's > possible to parameterize this for platforms that use different flags for > enabling posix threads. > > This work is a continuation of the work done by Greg Lewis in [1], but > generalized for the full JDK, and set