On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
> > (hint: Use e.g. make java.desktop-libs-only JOBS=1 LOG=info to get a build
> > speed number that you can compare a
On Wed, 29 Jan 2025 23:25:51 GMT, Magnus Ihse Bursie wrote:
> (hint: Use e.g. make java.desktop-libs-only JOBS=1 LOG=info to get a build
> speed number that you can compare across compiler flag changes)
That does not work/compile, it leads to
make java.desktop-libs-only JOBS=1 LOG=info
Gen
On Fri, 31 Jan 2025 13:59:45 GMT, Julian Waters wrote:
> Still, for some simple cases like e.g. BUILD_LIBSPLASHSCREEN changing the opt
> level from LOW to SIZE is probably the best
> thing to do after some more testing.
The size optimization worked pretty well on most platforms , have to look
On Fri, 31 Jan 2025 12:16:54 GMT, Matthias Baesken wrote:
> > I don't think there is much point in being able to vary the opt level; it
> > is more about spending the time to find the most appropriate opt level, and
> > once you've done that, you can update the makefile directly.
>
> You want
On Thu, 30 Jan 2025 19:47:55 GMT, Magnus Ihse Bursie wrote:
> I don't think there is much point in being able to vary the opt level; it is
> more about spending the time to find the most appropriate opt level, and once
> you've done that, you can update the makefile directly.
You want to optim
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
I don't think there is much point in being able to vary the opt level; it is
more about spending the time to find the
On Wed, 29 Jan 2025 23:25:51 GMT, Magnus Ihse Bursie wrote:
>As has been pointed out e.g. by Phil, not all libraries are performance
>critical. With that said, maybe such libraries should be
> optimized for size instead? (In many cases that also brings along a speed
> performance, even if it b
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
The problem with changing optimization levels is that folks are generally
conservative and worried that things might b
On Tue, 28 Jan 2025 14:35:45 GMT, Matthias Baesken wrote:
> BUILD_LIBAWT_XAWT LOW
Regarding BUILD_LIBAWT_XAWT I wonder why LOW is set; there is some java2d / OGL
coding in the lib and there the performance is probably important?
java.desktop/libawt_xawt/AccelGlyphCache.o
java.desktop/libawt_xa
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
Thanks for the reviews !
> Not all libraries do especially performance critical things.
Agree, it was not my suggesti
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
Marked as reviewed by serb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23332#pullrequestrev
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
Marked as reviewed by prr (Reviewer).
Not all libraries do especially performance critical things.
For the client ones
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
Hi Erik, thanks for the review !
I noticed this issue, while going through the make rules of our libs; any
idea wh
On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to
> HIGHEST so we can avoid the resetting.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23332#pullrequestre
14 matches
Mail list logo
