On Tue, 8 Apr 2025 18:32:16 GMT, Chen Liang wrote:
>> The problem is the Taglet class is part of the build system, and I don't
>> think we have a way to test these build classes (I coulndn't find any tests
>> for the other build Taglets). I could replicate the Taglet class in the
>> test, but
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Fri, 31 Jan 2025 16:58:08 GMT, Chen Liang wrote:
>> Please review a patch to add a JavaDoc Taglet to the JDK build system that
>> allows to add preview-related notes to non-preview API elements, as well as
>> a hidden javadoc option to add elements with preview notes to the preview
>> summa
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Mon, 3 Feb 2025 10:41:17 GMT, Hannes Wallnöfer wrote:
>> make/jdk/src/classes/build/tools/taglet/PreviewNote.java line 94:
>>
>>> 92: if (tag.getKind() == UNKNOWN_INLINE_TAG) {
>>> 93: UnknownInlineTagTree inlineTag = (UnknownInlineTagTree)
>>> tag;
>>> 94:
On Wed, 9 Apr 2025 17:55:26 GMT, Roger Riggs wrote:
> It would, IMHO, look better if it was a BOLD prefix of the first sentence.
I partly agree, but I also think the stamp-like nature serves a purpose. Note
that deprecated members and restricted methods use the same format, sometimes
adding a
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Wed, 9 Apr 2025 15:45:41 GMT, Roger Riggs wrote:
> For methods that have "@PreviewFeature(feature =
> PreviewFeature.Feature.VALUE_OBJECTS, reflective=true)" annotations the first
> (summary) line in the list of methods is "Preview." without any decoration.
> Is that intended?
Yes, that's
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
On Tue, 8 Apr 2025 06:51:20 GMT, Hannes Wallnöfer wrote:
>> make/jdk/src/classes/build/tools/taglet/PreviewNote.java line 112:
>>
>>> 110: """);
>>> 111: return sb.toString();
>>> 112: } else {
>>
>> What does this else block do? I
On Tue, 8 Apr 2025 18:08:57 GMT, Chen Liang wrote:
>> The else block generates the closing tag for the note. As you see in the PR
>> description, the tag syntax resembles HTML open/close tags. This is a
>> compromise to be able to locate the note within the description (which isn't
>> possible
On Tue, 8 Apr 2025 18:19:21 GMT, Hannes Wallnöfer wrote:
>> Such usage should be reflected in `testPreviewNoteTag`, which currently does
>> not use it as open/close tags.
>
> The problem is the Taglet class is part of the build system, and I don't
> think we have a way to test these build class
On Mon, 7 Apr 2025 18:32:55 GMT, Chen Liang wrote:
>> Please review a patch to add a JavaDoc Taglet to the JDK build system that
>> allows to add preview-related notes to non-preview API elements, as well as
>> a hidden javadoc option to add elements with preview notes to the preview
>> summar
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote:
> Please review a patch to add a JavaDoc Taglet to the JDK build system that
> allows to add preview-related notes to non-preview API elements, as well as a
> hidden javadoc option to add elements with preview notes to the preview
> sum
17 matches
Mail list logo
