On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
Thanks for reviewing!
-
PR Comment: https://git.openjdk.org/jdk/pull/21800#issuecomment-2450952400
On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
Marked as reviewed by ihse (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21800#pullrequestreview-2409050109
On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21800#pullrequestreview-2409051253
On Thu, 31 Oct 2024 12:12:21 GMT, Claes Redestad wrote:
>> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
>> micro `jvmArgs` flags.
>
> I had hoped you'd exclaim "Trivial!" and review, but I'm sure someone will
> step up soon enough. :-)
> @cl4es so what happens if
On Thu, 31 Oct 2024 12:12:21 GMT, Claes Redestad wrote:
>> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
>> micro `jvmArgs` flags.
>
> I had hoped you'd exclaim "Trivial!" and review, but I'm sure someone will
> step up soon enough. :-)
@cl4es so what happens if so
On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
Makes sense. Should be safe since we no longer have explicit prepend args, and
make only exposes this one option for VM args.
-
On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
I had hoped you'd exclaim "Trivial!" and review, but I'm sure someone will step
up soon enough. :-)
-
PR Comment: https://
On Thu, 31 Oct 2024 08:53:07 GMT, Claes Redestad wrote:
> Update RunTests.gmk to use `-jvmArgsPrepend` to avoid overwriting built-in
> micro `jvmArgs` flags.
Nice, thank you for fixing this! This fixes it for me, I checked this manually,
this way https://github.com/openjdk/jdk/pull/21683#issue
