Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Erik Joelsson
On Wed, 23 Oct 2024 21:20:45 GMT, Magnus Ihse Bursie wrote: > > I'm not sure that error was caused by this issue. That would imply that I > > had strange file attributes on files in my build directory, and I don't > > think I do. > > I can't see what else did. I think the strange attributes ar

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Magnus Ihse Bursie
On Wed, 23 Oct 2024 17:26:35 GMT, Erik Joelsson wrote: > I'm not sure that error was caused by this issue. That would imply that I had > strange file attributes on files in my build directory, and I don't think I > do. I can't see what else did. I think the strange attributes are injected a b

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Erik Joelsson
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote: > The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large > number of individual copy rules, which can execute in any order. The > "install-file" (our copy) macro on macos includes a check for weird > attributes using `

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Magnus Ihse Bursie
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote: > The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large > number of individual copy rules, which can execute in any order. The > "install-file" (our copy) macro on macos includes a check for weird > attributes using `

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Lutz Schmidt
On Wed, 23 Oct 2024 12:32:44 GMT, Erik Joelsson wrote: >> make/common/FileUtils.gmk line 141: >> >>> 139: $(CHMOD) -h u+w '$(call DecodeSpace, $@)'; \ >>> 140: $(XATTR) -cs '$(call DecodeSpace, $@)'; \ >>> 141:fi >> >> What about running chmod only against real files?

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Lutz Schmidt
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote: > The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large > number of individual copy rules, which can execute in any order. The > "install-file" (our copy) macro on macos includes a check for weird > attributes using `

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Erik Joelsson
On Wed, 23 Oct 2024 07:23:44 GMT, Lutz Schmidt wrote: >> The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large >> number of individual copy rules, which can execute in any order. The >> "install-file" (our copy) macro on macos includes a check for weird >> attributes usin

Re: RFR: 8342858: Make target mac-jdk-bundle fails on chmod command

2024-10-23 Thread Lutz Schmidt
On Tue, 22 Oct 2024 21:30:40 GMT, Erik Joelsson wrote: > The target mac-jdk-bundle can fail randomly. MacBundles.gmk defines a large > number of individual copy rules, which can execute in any order. The > "install-file" (our copy) macro on macos includes a check for weird > attributes using `