On Mon, 16 Sep 2024 19:30:56 GMT, Naoto Sato wrote:
>> make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesProvider.java line 308:
>>
>>> 306: if (off < tokens.length) {
>>> 307: String dayRule = tokens[off++];
>>> 308: if (dayRule.regionMatches(true, 0
On Mon, 16 Sep 2024 18:57:42 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> make/jdk/src/classes/build/tools/tzdb/TzdbZoneRul
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Wed, 11 Sep 2024 18:33:59 GMT, Sean Coffey wrote:
> maybe you can verify with a few simple edits to a tzdata file and building
Yes, that is exactly what I did for this testing.
-
PR Comment: https://git.openjdk.org/jdk/pull/20940#issuecomment-2344538481
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Wed, 11 Sep 2024 15:13:25 GMT, Sean Coffey wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> LGTM
>
> `sun/util/calendar/zi/TestZoneInfo310.java` exe
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Tue, 10 Sep 2024 22:53:15 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> Looks good to me
Thanks, @justin-curtis-lu. @coffeys, woul
On Tue, 10 Sep 2024 22:42:37 GMT, Naoto Sato wrote:
>> This is a follow on fix to
>> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
>> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
>> Same fix, i.e, replacing `startsWith()` with `regionM
On Tue, 10 Sep 2024 22:39:38 GMT, Naoto Sato wrote:
>> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverter.java line 1375:
>>
>>> 1373: Files.walk(Path.of(tzDataDir), 1,
>>> FileVisitOption.FOLLOW_LINKS)
>>> 1374: .filter(p -> p.toFile().isFile())
>>> 1375:
On Tue, 10 Sep 2024 22:17:51 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> make/jdk/src/classes/build/tools/cldrconverter/CLDRConverte
> This is a follow on fix to
> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
> Same fix, i.e, replacing `startsWith()` with `regionMatches()` was applied.
Naoto Sato has updated the pull re
On Tue, 10 Sep 2024 19:45:01 GMT, Naoto Sato wrote:
> This is a follow on fix to
> [JDK-8339644](https://bugs.openjdk.org/browse/JDK-8339644). It turned out
> that TZ data files allow abbreviation of keywords, such as "ZO" for "Zone."
> Same fix, i.e, replacing `startsWith()` with `regionMatch
13 matches
Mail list logo
