Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Erik Joelsson
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Coleen Phillimore
On Mon, 2 Dec 2024 15:11:54 GMT, Magnus Ihse Bursie wrote: >> src/hotspot/os/linux/os_linux.cpp line 590: >> >>> 588: >>> 589: // Found the full path to the binary. It is normally of this >>> structure: >>> 590: // /lib//libjvm.so >> >> You could change to server I believe, since t

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Magnus Ihse Bursie
On Mon, 2 Dec 2024 15:10:08 GMT, Coleen Phillimore wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into static-jdk-image >> - Remove LDFLAGS_STATIC_JDK >> -

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Jiangli Zhou
On Mon, 2 Dec 2024 15:12:24 GMT, Magnus Ihse Bursie wrote: >> Hotspot changes look fine. >> >> Thanks > > @dholmes-ora @coleenp @erikj79 Thanks for your reviews! @magicus Thanks for integrating the changes, particularly reworking and making the statically linked launcher build changes cleaner!

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Magnus Ihse Bursie
On Tue, 26 Nov 2024 21:20:10 GMT, David Holmes wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into static-jdk-image >> - Remove LDFLAGS_STATIC_JDK >> - Ren

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-12-02 Thread Coleen Phillimore
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-11-26 Thread David Holmes
On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamic

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v21]

2024-11-26 Thread Magnus Ihse Bursie
> As a prerequisite for Hermetic Java, we need a statically linked `java` > launcher. It should behave like the normal, dynamically linked `java` > launcher, except that all JDK native libraries should be statically, not > dynamically, linked. > > This patch is the first step towards this goal.